[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 added a comment. Thanks! I suppose this won't be in the next patch release (10.0.1) but instead in the next major ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79559/new/ https://reviews.llvm.org/D79559 ___

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 added a comment. Good to know, thanks! It's also my first time using `arc`, so I had to poke around a bit. In any case I didn't seem to include that whitespace fix even after squashing the commits together. If this is fine as is, then great. No I don't have commit access. Repository:

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 263477. Geod24 added a comment. Merge whitespace-removing commit into the main one Since I can't seem to get arc to comply. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79559/new/ https://reviews.llvm.org/D795

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 263463. Geod24 added a comment. Add missing commit See previous diff. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79559/new/ https://reviews.llvm.org/D79559 Files: lldb/source/Plugins/TypeSystem/Clang/Type

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 263462. Geod24 added a comment. Remove a trailing whitespace in TypeSystemClang.cpp The pre-merge checks are apparently failing, and from what I can gather from the logs, it seems to be because of a whitespace issue: [2020-05-12T16:19:00.309Z] + clang-tidy

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 263442. Geod24 added a comment. Remove un-needed main & use x86_64-pc-gnu as target instead of host Since we're not running the program anymore, we no longer need a main. The comment, build step, and IR of the test were updated accordingly. Repository: rG

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 263401. Geod24 added a comment. Changed the test from running to 'type lookup string' Due to bug https://bugs.llvm.org/show_bug.cgi?id=45856 the test was originally runnable, but a non-runnable alternative was suggested during review. Repository: rG LLVM

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 updated this revision to Diff 262818. Geod24 added a comment. Added Shell test A shell test was added using LLVM IR. The test has to run the generated binary, as there is currently a (likely) bug that leads to types being printed differently before and after 'run' is issued. Repository:

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 created this revision. Geod24 added a reviewer: clayborg. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Geod24 added a comment. I wasn't sure what would be the best place / how to add an unit test for this. Could a reviewer provide some pointers ? The D programmi

[Lldb-commits] [PATCH] D79559: [lldb] Also recognize DWARF UTF base types using their size

Geod24 added a comment. I wasn't sure what would be the best place / how to add an unit test for this. Could a reviewer provide some pointers ? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79559/new/ https://reviews.llvm.org/D79559 ___