[Lldb-commits] [PATCH] D118405: [LLD][MinGW] Add --heap argument support

mati865 created this revision. mati865 added a reviewer: mstorsjo. mati865 added a project: lld. Herald added a subscriber: dang. mati865 requested review of this revision. Herald added a project: LLVM. Herald added a subscriber: llvm-commits. Noticed in https://github.com/msys2/MINGW-packages/pul

[Lldb-commits] [PATCH] D87517: [MinGW] Use lib prefix for libraries

mati865 added a comment. `-DLLVM_ENABLE_PROJECTS="clang;lldb" -DLLVM_BUILD_LLVM_DYLIB=1` with only this patch applied (`<` is before, `>` is after): $ diff <(cd ../build && find ./ | sort) <(cd ../build2/ && find ./ | sort) 38a39,41 > ./bin/libLLVM.dll > ./bin/libLTO.dll > ./bin/libRem

[Lldb-commits] [PATCH] D87517: [MinGW] Use lib prefix for libraries

mati865 added a comment. I haven't tried ` BUILD_SHARED_LIBS=TRUE` TBH. Effects visible at first glance: bin/LLVM.dll -> bin/libLLVM.dll bin/LTO.dll -> bin/libLTO.dll lib/liblibclang.a -> lib/libclang.a lib/liblibclang.dll.a -> lib/libclang.a lib/libliblldb.d

[Lldb-commits] [PATCH] D87517: [MinGW] Use lib prefix for libraries

mati865 updated this revision to Diff 291224. mati865 added a comment. Also adjusted llvm-config. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D87517/new/ https://reviews.llvm.org/D87517 Files: clang/tools/libclang/CMakeLists.txt lldb/source/A

[Lldb-commits] [PATCH] D87517: [MinGW] Use lib prefix for libraries

mati865 created this revision. mati865 added a reviewer: LLVM. mati865 added projects: LLVM, clang, LLDB. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, JDevlieghere, mgorny. mati865 requested review of this revision. In MinGW world, UNIX like `lib` prefix is preferred. This p

[Lldb-commits] [PATCH] D86521: Revert "Use find_library for ncurses"

mati865 added a comment. FYI this doesn't fully fix MinGW issue: $ cat tools/llvm-config/BuildVariables.inc | grep LLVM_SYSTEM_LIBS #define LLVM_SYSTEM_LIBS "-lpsapi -lshell32 -lole32 -luuid -ladvapi32 -lz.dll" It's because libraries are found by their import library which is `libz.dll.a` i

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

mati865 added a comment. @phosek > Looks like that's an issue introduced by D86134 > or D86245 . Indeed, I apologize for bothering you. Should I move the discussion to one of patches created by @haampie? Continuing the discus

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

mati865 added a comment. @phosek in MSYS2 (targeting x86_64-w64-windows-gnu) Zlib works properly for LLVM 10 but with master I'm now seeing: -- Constructing LLVMBuild project information -- DEBUG zlib_library=D:/msys64/mingw64/lib/libz.dll.a CMake Error at lib/Support/CMakeLists.txt:9 (str

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 updated this revision to Diff 264339. mati865 added a comment. With `_GNU_SOURCE` removed I was able to successfully build everything without this diff. I cannot test it today but I believe this updated diff would have fixed the error. It's up to you whether this should be considered as

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 added a comment. Indeed, I'll see if I can build all LLVM related packages without `_GNU_SOURCE`. Otherwise I'll guard it with `#ifndef _GNU_SOURCE` instead. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D7/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 added a comment. Perhaps you are building with Clang? I don't remember the message but GCC emits error about incompatible definition and declaration of `vasprintf`. I can build it without the patch and paste the error if you want. Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D79999: [lldb] [Windows] Provide vasprintf only for MSVC

mati865 created this revision. mati865 added a project: LLDB. Mingw-w64 provides this function and it has been causing issues for MSYS2 when building lldb. Repository: rG LLVM Github Monorepo https://reviews.llvm.org/D7 Files: lldb/include/lldb/Host/windows/PosixApi.h lldb/source/Ho