[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

poya added a comment. Don't believe I have the necessary permissions to land this myself, so would need some help to get this committed to the repo. Thanks. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82835/new/ https://reviews.llvm.org/D82835

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

poya marked an inline comment as done. poya added inline comments. Comment at: lldb/source/Expression/REPL.cpp:460 sub_result.GetMatches(matches); +// Prepend command prefix that was excluded in the completion request +if (request.GetCursorIndex() == 0) { ---

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

poya created this revision. poya added a reviewer: teemperor. Herald added a project: LLDB. poya added a comment. Tests for the Swift REPL in https://github.com/apple/llvm-project/pull/1388 When tabbing to complete LLDB commands in REPL, characters would at best be missing but at worst cause th

[Lldb-commits] [PATCH] D82835: [lldb] Fix missing characters when autocompleting LLDB commands in REPL

poya added a comment. Tests for the Swift REPL in https://github.com/apple/llvm-project/pull/1388 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82835/new/ https://reviews.llvm.org/D82835 ___ lldb-commi

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya removed a reviewer: teemperor. poya added a comment. This revision is now accepted and ready to land. Removing Raphael as reviewer hoping that it will allow me to close this already merged revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D69880: [lldb] Fix exception breakpoint not being resolved when set on dummy target

poya added a comment. Thanks, currently no commit access, so would like to ask you for that favor as well Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69880/new/ https://reviews.llvm.org/D69880 ___ lldb-commits m

[Lldb-commits] [PATCH] D69880: [lldb] Fix exception breakpoint not being resolved when set on dummy target

poya added a comment. @jingham I think this might have slipped through the cracks, do you think you'll have time to help me review and commit this one, or advice on a suitable alternate reviewer? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69880/new/ https:

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya updated this revision to Diff 230251. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/D70393 Files: lldb/source/Plugins/Language/ObjC/Cocoa.cpp Index: lldb/source/Plugins/Language/ObjC/Cocoa.cpp ==

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya updated this revision to Diff 230248. poya added a comment. Remove helper function Hardcode quote character to " with assert to catch future changes CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/D70393 Files: lldb/source/Plugins/Language/ObjC/

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya marked 3 inline comments as not done. poya added a comment. Sorry for marking comments as done, not used to the tool. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/D70393 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya marked 2 inline comments as done. poya added inline comments. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:662 +static void NSURL_ConcatSummary(StreamString &first, const StreamString &second, +std::string prefix, std::string suffix) { teem

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya added a comment. In D70393#1751514 , @teemperor wrote: > But having a test for this upstream is what should ideally happen instead of > just testing this downstream. There is already a test for the NSURL data formatter upstream for the ObjC contex

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya marked an inline comment as done. poya added a comment. Comment at: lldb/source/Plugins/Language/ObjC/Cocoa.cpp:662 +static void NSURL_ConcatSummary(StreamString &first, const StreamString &second, +std::string prefix, std::string suffix) { teemper

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya added a comment. @davide Thanks for the review, and while I haven't been able to reproduce the test failure locally with my configuration, I reviewed the code and corrected a potential memory issue that might have been the cause for the failure. If not, do you mind sharing more info on the

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya updated this revision to Diff 230045. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70393/new/ https://reviews.llvm.org/D70393 Files: lldb/source/Plugins/Language/ObjC/Cocoa.cpp Index: lldb/source/Plugins/Language/ObjC/Cocoa.cpp ==

[Lldb-commits] [PATCH] D70393: [lldb] Fix NSURL data formatter truncation issue in Swift

poya created this revision. poya added a reviewer: davide. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Remove hardcoded string prefix length assumption causing issues when concatenating summary for NSURL in NSURLSummaryProvider. Provider relies on concatenat

[Lldb-commits] [PATCH] D69880: [lldb] Fix exception breakpoint not being resolved when set on dummy target

poya created this revision. poya added a reviewer: jingham. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. Ensure that breakpoint ivar is properly set in exception breakpoint resolver so that exception breakpoints set on dummy targets are resolved once real ta

[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

poya added a comment. No commit access, so would need some assistance getting this change into the repo. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69425/new/ https://reviews.llvm.org/D69425 ___ lldb-commits mailing list lldb-commits@li

[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

poya updated this revision to Diff 227406. poya added a comment. Added a test CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69425/new/ https://reviews.llvm.org/D69425 Files: lldb/source/Commands/CommandObjectBreakpoint.cpp lldb/test/Shell/Breakpoint/Inputs/dummy-target.c lldb/tes

[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

poya added a comment. Sure, I'll try to add a test in test/Shell/Breakpoint once I get the tests up and running on my machine. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69425/new/ https://reviews.llvm.org/D69425 _

[Lldb-commits] [PATCH] D69425: [lldb] Fix broken -D option for breakpoint set command

poya created this revision. poya added a reviewer: jingham. Herald added subscribers: lldb-commits, JDevlieghere. Herald added a project: LLDB. BreakpointDummyOptionGroup was using //g_breakpoint_modify_options// rather than //g_breakpoint_dummy_options// causing the -D option for //breakpoint s