markmentovai added inline comments.
Comment at: lldb/source/Plugins/Process/minidump/MinidumpParser.cpp:241-242
+
+ const CrashpadInfo *crashpad_info =
+ reinterpret_cast(data.data());
+
Check that crashpad_info->version is 1 before attempting to treat what
markmentovai accepted this revision.
markmentovai added a comment.
LGTM too.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D66633/new/
https://reviews.llvm.org/D66633
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
markmentovai added a comment.
This seems like a step in the right direction.
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D55142/new/
https://reviews.llvm.org/D55142
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llv
markmentovai added inline comments.
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.h:74
+
+ bool IsStripped() override { return false; }
+
labath wrote:
> zturner wrote:
> > Is this always true for breakpad files?
> Well.. the whole point of t
markmentovai added a comment.
Very excited to see this work beginning!
Comment at: source/Plugins/ObjectFile/Breakpad/ObjectFileBreakpad.cpp:66-84
+ if (os == llvm::Triple::Win32) {
+// In binary form, the module id should have 20 bytes: 16 bytes for UUID,
+// and 4 by
markmentovai added a comment.
I know, that was a mistake.
(Unfortunately, I reviewed it. 11 years ago. And now I feel responsible for all
of those malformed minidumps floating around out there.)
If you do need to do this, it seems fine to me, since it’s basically the same
exact workaround. If
markmentovai added a comment.
This has got to be padding.
Breakpad’s structure definitions don’t nail down alignment as they probably
should. A 32-bit system writing an MDRawMemoryList will write what’s intended,
but a 64-bit one will need to insert four bytes of padding after
number_of_memory
