kettenis added a comment.
Looks like a good improvement to me.
https://reviews.llvm.org/D40311
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kettenis added inline comments.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1374
+else if ((note.n_name == LLDB_NT_OWNER_NETBSDCORE) &&
+ (note.n_type == LLDB_NT_NETBSD_NT_PROCINFO)) {
// Set the elf OS version to NetBSD. Also clear the ven
kettenis added a comment.
In https://reviews.llvm.org/D32149#731887, @labath wrote:
> A test would infinitely times more valuable then a demo script. What is the
> tiniest core file you can produce on NetBSD? (on linux we've gotten them down
> to about 20K) Then we could check that in and write
kettenis added a comment.
Generally looks reasonable to me. A few comments inline.
Comment at: source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp:1374
+else if ((note.n_name == LLDB_NT_OWNER_NETBSDCORE) &&
+ (note.n_type == LLDB_NT_NETBSD_NT_PROCINFO)) {
//
kettenis added a comment.
The core file reading bits look ok to me.
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DYLDRendezvous.cpp:383
// On Linux the executable is indicated by an empty path in the entry. On
// FreeBSD and on Android it is the full path to the ex
kettenis added a comment.
On OpenBSD the register context used in core dumps uses the same layout as
ptrace(2). That's not the case on all OSes, but I believe that is the case for
NetBSD as well. Would it be possible to re-use the register context data
structures defined in the source/Plugins
kettenis added a comment.
Can somebody commit this diff for me?
https://reviews.llvm.org/D31131
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kettenis updated this revision to Diff 92938.
kettenis added a comment.
Updated diff to account for the FileSpec.h move.
https://reviews.llvm.org/D31131
Files:
include/lldb/Host/Config.h
include/lldb/Host/Editline.h
include/lldb/Host/Host.h
include/lldb/Host/HostInfo.h
include/lldb/Ho
kettenis added inline comments.
Comment at: source/Plugins/Process/Utility/RegisterContextOpenBSD_i386.cpp:48
+ GPR gpr;
+ FPR_i386 i387;
+};
krytarowski wrote:
> no DBG regs here?
OpenBSD doesn't actually implement access to the debug registers.
https://revi
kettenis updated this revision to Diff 92861.
kettenis added a comment.
Apologies. Previous diff contained a bogus change to DYLDRendezvous.cpp and a
formatting botch. Please review this updated version instead,
https://reviews.llvm.org/D31131
Files:
include/lldb/Host/Config.h
include/ll
kettenis updated this revision to Diff 92857.
kettenis marked an inline comment as done.
kettenis edited the summary of this revision.
kettenis added a comment.
Herald added subscribers: srhines, rengolin, emaste, aemerson.
New diff. This one adds support for OpenBSD/amd64, OpenBSD/arm, OpenBSD/ar
kettenis marked 2 inline comments as done.
kettenis added a comment.
Will revise the diff based on your comments. Thanks!
Comment at: include/lldb/Host/Config.h:35
+
+#include "lldb/Host/openbsd/Config.h"
krytarowski wrote:
> krytarowski wrote:
> > Missing in
kettenis created this revision.
Herald added a subscriber: mgorny.
Add basic OpenBSD support. This is enough to be able to analyze core dumps for
OpenBSD/amd64, but not much beyond that.
Note that part of the changes to
source/Plugins/ObjectFile/ELF/ObjectFileELF.cpp fix a bug that probably aff
13 matches
Mail list logo
