[Lldb-commits] [PATCH] D75925: [lldb] reject `.debug_arange` sections with nonzero segment size

This revision was automatically updated to reflect the committed changes. Closed by commit rG0fa3320931e9: [lldb] reject `.debug_arange` sections with nonzero segment size (authored by ldrumm). Changed prior to commit: https://reviews.llvm.org/D75925?vs=249663&id=249913#toc Repository: rG LL

[Lldb-commits] [PATCH] D75925: [lldb] reject `.debug_arange` sections with nonzero segment size

ldrumm updated this revision to Diff 249663. ldrumm added a comment. I found similar unittests for other DWARF entries which allow me to check more about the parser state, so I went with Pavel's suggestion for the testcase Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https

[Lldb-commits] [PATCH] D75925: [lldb] reject `.debug_arange` sections with nonzero segment size

ldrumm created this revision. ldrumm added reviewers: clayborg, jasonmolenda. ldrumm added a project: LLDB. If a producer emits a nonzero segment size, `lldb` will silently read incorrect values and crash, or do something worse later, as the tuple size is expected to be 2, rather than 3.

[Lldb-commits] [PATCH] D28028: Fix a couple of incorrect format strings

This revision was automatically updated to reflect the committed changes. Closed by commit rL290359: Fix a couple of incorrect format string warnings (authored by ldrumm). Changed prior to commit: https://reviews.llvm.org/D28028?vs=82334&id=82354#toc Repository: rL LLVM https://reviews.llvm

[Lldb-commits] [PATCH] D28028: Fix a couple of incorrect format strings

ldrumm updated this revision to Diff 82334. ldrumm added a comment. switched to the new llvm::Format API https://reviews.llvm.org/D28028 Files: source/Interpreter/Args.cpp source/Plugins/ExpressionParser/Clang/IRForTarget.cpp Index: source/Plugins/ExpressionParser/Clang/IRForTarget.cpp ==

[Lldb-commits] [PATCH] D28028: Fix a couple of incorrect format strings

ldrumm created this revision. ldrumm added reviewers: zturner, clayborg. ldrumm added a subscriber: LLDB. This patch fixes use of incorrect `%zi` to format a plain `int`, and switches from using "%llu" to format a uint64_t to using the exact width specifier PRIu64 from inttypes.h https://revie

[Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

ldrumm added a subscriber: LLDB. ldrumm removed rL LLVM as the repository for this revision. ldrumm updated this revision to Diff 82251. ldrumm added a comment. This patch was committed back in March https://reviews.llvm.org/rL263099 and then reverted 2 hours later in https://reviews.llvm.org/rL2

[Lldb-commits] [PATCH] D17719: Track expression language from one place in ClangExpressionParser

ldrumm reopened this revision. ldrumm added a comment. This patch was committed back in March https://reviews.llvm.org/rL263099 and then reverted 2 hours later in https://reviews.llvm.org/rL263107 due to a testing failure on greendragon related to ObjC. Unfortunately, I no longer have access t

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

This revision was automatically updated to reflect the committed changes. Closed by commit rL290117: Expression evaluation for overloaded C functions (redux) (authored by ldrumm). Changed prior to commit: https://reviews.llvm.org/D27223?vs=81753&id=81967#toc Repository: rL LLVM https://revi

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

This revision was automatically updated to reflect the committed changes. Closed by commit rL289956: Fix broken escaping of commands in the build (authored by ldrumm). Changed prior to commit: https://reviews.llvm.org/D26757?vs=79578&id=81761#toc Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

ldrumm added inline comments. Comment at: include/lldb/Core/FastDemangle.h:22 +char * +FastDemangle(const char *mangled_name, size_t mangled_name_length, + std::function primitive_type_hook = nullptr); alexshap wrote: > some thoughts: > (also i assum

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

ldrumm updated this revision to Diff 81753. ldrumm marked 6 inline comments as done. ldrumm added a comment. updated to use StringRef-based parser rather than char pointers https://reviews.llvm.org/D27223 Files: include/lldb/Core/FastDemangle.h packages/Python/lldbsuite/test/expression_com

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm marked 2 inline comments as done. ldrumm added a comment. ping https://reviews.llvm.org/D26757 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D17957: Expression evaluation for overloaded C functions

ldrumm added a comment. New candidate is here Repository: rL LLVM https://reviews.llvm.org/D17957 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [PATCH] D27223: Expression evaluation for overloaded C functions (redux)

ldrumm created this revision. ldrumm added reviewers: spyffe, clayborg. ldrumm added a subscriber: LLDB. Herald added a subscriber: aemerson. This is a redux of Ewan's patch , refactored to properly substitute primitive types using a hook in the itanium demangle

[Lldb-commits] [PATCH] D26757: Fix broken escaping of commands in the build

ldrumm added a subscriber: lldb-commits. ldrumm updated this revision to Diff 79578. ldrumm added a comment. Addressed some unwanted whitespace changes as suggested by @bryant; use `os.dir.curdir` as instead of `.` https://reviews.llvm.org/D26757 Files: CMakeLists.txt scripts/CMakeLists.tx