yuanzi added a comment.
Thanks for the reviews!
Yeah I do not have commit access. It would be great if someone could help with
the commit!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116707/new/
https://reviews.llvm.org/D116707
___
yuanzi marked 3 inline comments as done.
yuanzi added inline comments.
Comment at: lldb/source/Host/common/XML.cpp:157-159
+ std::string attr_str = GetAttributeValue(name, "");
+ llvm::StringRef attr(attr_str);
+ return llvm::to_integer(attr, value, base);
lab
yuanzi updated this revision to Diff 398193.
yuanzi added a comment.
free->xmlFree, remove conversions from std::string to llvm::StringRef.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D116707/new/
https://reviews.llvm.org/D116707
Files:
lldb/in
yuanzi updated this revision to Diff 398009.
yuanzi edited the summary of this revision.
yuanzi added a comment.
Yeah since `xmlGetProp` calls `xmlGetPropNodeValueInternal`, which calls
`xmlStrdup` rather than returning the content or value of the node directly,
`xmlFreeDoc` could not clean it u
yuanzi created this revision.
yuanzi requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
While running heap checker on a test that uses LLDB API, the following memory
leak is found:
RAW: HeapChecker started...
RAW: Leak check _main_ detected
yuanzi created this revision.
yuanzi added a reviewer: LLDB.
yuanzi requested review of this revision.
Herald added a project: LLDB.
Herald added a subscriber: lldb-commits.
While running heap checker on a test that uses LLDB API, the following memory
leak is found:
RAW: HeapChecker started...
RA
