[Lldb-commits] [PATCH] D126668: LLDB: Fix resolving nested template parameters

PatriosTheGreat created this revision. PatriosTheGreat added a reviewer: teemperor. Herald added a reviewer: shafik. Herald added a project: All. PatriosTheGreat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Right now LLDB ignores nested

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat added a comment. Thanks Greg, Can you or someone please take this commit to main branch since I don't have a commit permission? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___ ll

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat added a comment. Hi Greg, Sorry for a delay had an issue with tests local run. I fixed the previous feedback. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 430357. PatriosTheGreat marked 5 inline comments as done. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/sourc

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 429160. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/source/API/SBProcess.cpp lldb/test/API/functionaliti

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat marked 3 inline comments as done. PatriosTheGreat added a comment. Thanks for clarifications. Fixed header doc and parameter name. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 ___

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 428880. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/source/API/SBProcess.cpp Index: lldb/source/API/SBPro

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat marked 3 inline comments as done. PatriosTheGreat added a comment. Hi Greg. Thanks for the review. I fixed the feedback. I forgot the default initialization of plugin_name parameter in SBProcess.i in previous version, but I assume it's still better to explicitly create a separat

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat updated this revision to Diff 428577. PatriosTheGreat edited the summary of this revision. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D125325/new/ https://reviews.llvm.org/D125325 Files: lldb/bindings/interface/SBProcess.i lldb/include/lldb/API/SBProcess.h lldb/so

[Lldb-commits] [PATCH] D125325: Pass plugin_name in SBProcess::SaveCore

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: clayborg, labath. Herald added a project: All. PatriosTheGreat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This CL allows to use minidump save-core functionality (

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

PatriosTheGreat abandoned this revision. PatriosTheGreat added a comment. Closing this revision since Pavel already fixed this in rGc0e3bb4d4ba306 . Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

PatriosTheGreat added a comment. Hi Pavel. Got it, Thanks for fixing and clarification. In D114554#3152953 , @labath wrote: > I've fixed this in rGc0e3bb4d4ba306 > . > >> Not sure if

[Lldb-commits] [PATCH] D114554: Fix TestFileHandle.py. Remove redundant skipIfReproducer annotation

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: DavidSpickett, JDevlieghere, shafik. PatriosTheGreat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. My recent change (https://reviews.llvm.org/D104413) broke the lldb

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat added a comment. Thanks for review! Could you or someone else take this commit to master? I don't have a commit permissions. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___ lldb-

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat added a comment. Friendly ping =) CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat marked 2 inline comments as done. PatriosTheGreat added a comment. Sorry for delay from my side also CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat updated this revision to Diff 371002. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 Files: lldb/bindings/interface/SBDebugger.i lldb/include/lldb/API/SBDebugger.h lldb/include/lldb/Core/Debugger.h lldb/source/API/SBDebu

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat added a comment. Should I send this somehow back to review? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D104413/new/ https://reviews.llvm.org/D104413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat updated this revision to Diff 353875. PatriosTheGreat added a comment. Hi everyone. Thanks for review. In order to move new method code to Debugger class I also had to move there SetInputFile(lldb::FileSP file) method. After I did that -- the reproducer tests started to fail. If

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

PatriosTheGreat updated this revision to Diff 352966. PatriosTheGreat added a comment. Thanks for the review feedback. Looks like moving frame recognizer call to StackFrameList::GetFramesUpTo also fixes infinity recursion issue. Regarding the zeroth frame issue: I'm actually using the lldb-serve

[Lldb-commits] [PATCH] D104413: Fixed use of -o and -k in LLDB under Windows when statically compiled with vcruntime.

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: teemperor, jarin. PatriosTheGreat requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Right now if the LLDB is compiled under the windows with static vcruntime library, th

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

PatriosTheGreat updated this revision to Diff 350596. PatriosTheGreat added a comment. Thanks for your suggestions. I tried both of them, however the solution to patch assert recognizer doesn’t solve the original performance issue. Since the performance degradation doesn’t come from the recogniz

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

PatriosTheGreat updated this revision to Diff 348919. PatriosTheGreat added a comment. Select most related frame only in threads which were stopped with reason. This diff is for further discussion. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D103271/new/ https://reviews.llvm.org/D10327

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

PatriosTheGreat requested review of this revision. PatriosTheGreat added a comment. Thanks for feedback. I made a small sample: https://pastebin.com/F8nde1zi Compile command: clang++ -O0 -g -pthread sample.cpp LLDB command: breakpoint set -f sample.cpp -l 24 --condition 'i == 100' This break sh

[Lldb-commits] [PATCH] D103271: [lldb/Target] Select most relevant frame only in case of signal

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: mib, labath, jarin. PatriosTheGreat added a project: LLDB. Herald added a subscriber: JDevlieghere. PatriosTheGreat requested review of this revision. Herald added a subscriber: lldb-commits. In order to select most relevant f

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat added a comment. Hi Muhammad, Thank you for review. Could you or Pavel commit this to master, since I don't have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 ___ lld

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat updated this revision to Diff 245167. PatriosTheGreat added a comment. In this revision I fix value_regnums and invalidate_regnums serialization in target.xml. However I'm not so sure that this is the cause of problem with ARM tests. >From tests log it seems like there are some u

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat added a comment. Hi Muhammad, Thank you for finding this issue. After I fix that, could I update current review or should I create new one? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat added a comment. Hi Pavel, Thank you for review. Could you also commit this to master, since I don't have commit access? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 ___ lldb-commi

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat updated this revision to Diff 244152. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/Makefile lldb/packages/Python/lldbsuite/test/tool

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat updated this revision to Diff 244130. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/Makefile lldb/packages/Python/lldbsuite/test/tool

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat updated this revision to Diff 243932. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/Makefile lldb/packages/Python/lldbsuite/test/tool

[Lldb-commits] [PATCH] D74217: Add target.xml support for qXfer request.

PatriosTheGreat updated this revision to Diff 243579. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D74217/new/ https://reviews.llvm.org/D74217 Files: lldb/packages/Python/lldbsuite/test/tools/lldb-server/registers-target-xml-reading/Makefile lldb/packages/Python/lldbsuite/test/tool

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat updated this revision to Diff 237604. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70846/new/ https://reviews.llvm.org/D70846 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp lldb

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat added a comment. Made clang-format with last update of diff. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70846/new/ https://reviews.llvm.org/D70846 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.ll

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat marked an inline comment as done. PatriosTheGreat added inline comments. Comment at: lldb/test/Shell/SymbolFile/DWARF/find-basic-function.cpp:67 + +// FULL: Found 0 functions: shafik wrote: > You don't actually run a `FULL` test, is this purpose

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat updated this revision to Diff 234899. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D70846/new/ https://reviews.llvm.org/D70846 Files: lldb/source/Plugins/ExpressionParser/Clang/ClangExpressionDeclMap.cpp lldb/source/Plugins/SymbolFile/DWARF/ManualDWARFIndex.cpp lldb

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat added a comment. It seems like with this CL find-basic-functions logic became inconsistent for macos target and pc-linux. In cases of pc-linux it returns no function with --function-flags=full flag and in macos it returns 7 functions. I think there are 3 ways to fix this: 1. Fi

[Lldb-commits] [PATCH] D70846: Expression eval lookup speedup by not returning methods in ManualDWARFIndex::GetFunctions

PatriosTheGreat created this revision. PatriosTheGreat added reviewers: labath, jarin, aprantl. PatriosTheGreat added a project: LLDB. Herald added a subscriber: arphaman. This change is connected with https://reviews.llvm.org/D69843 In large codebases, we sometimes see Module::FindFunctions (whe