[Lldb-commits] [clang] [compiler-rt] [libc] [lld] [lldb] [llvm] [mlir] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-11-08 Thread Lei Wang via lldb-commits
wlei-llvm wrote: > > > > > > Ping @wlei-llvm > > > > > > > > > > > > > > > Sorry for the delay. The new version addressed my last comment (with > > > > > just minor nits). However, I didn't fully follow the new features > > > > > related to `ProbeMatchSpecs` stuffs. Could you add more descrip

[Lldb-commits] [clang] [compiler-rt] [libc] [lld] [lldb] [llvm] [mlir] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-11-08 Thread Lei Wang via lldb-commits
https://github.com/wlei-llvm approved this pull request. LGTM, thanks for addressing the comments! https://github.com/llvm/llvm-project/pull/99891 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo

[Lldb-commits] [clang] [compiler-rt] [libc] [lld] [lldb] [llvm] [mlir] [BOLT] Match blocks with pseudo probes (PR #99891)

2024-11-08 Thread Lei Wang via lldb-commits
wlei-llvm wrote: > > > > Ping @wlei-llvm > > > > > > > > > Sorry for the delay. The new version addressed my last comment (with just > > > minor nits). However, I didn't fully follow the new features related to > > > `ProbeMatchSpecs` stuffs. Could you add more descriptions to the diff > > >