[Lldb-commits] [PATCH] D155124: [lldb][Windows] Fix TestLocateModuleCallback

luporl accepted this revision. luporl added a comment. This revision is now accepted and ready to land. LGTM. It should fix the buildbot failure. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D155124/new/ https://reviews.llvm.org/D155124 __

[Lldb-commits] [PATCH] D150470: [lldb-vscode] Make tests not wait for 'launch' process events if launch fails.

luporl added a comment. LGTM. With this patch, if I re-enable the restart tests on ARM I get a failure after a few seconds, instead of timing out. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150470/new/ https://reviews.llvm.org/D150470

[Lldb-commits] [PATCH] D42083: [lldb][PPC64] Fixed long double variables dump

luporl added a comment. @labath, can you please commit the changes for me? (I don't have permission to do it) https://reviews.llvm.org/D42083 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/l

[Lldb-commits] [PATCH] D42083: [lldb][PPC64] Fixed long double variables dump

luporl updated this revision to Diff 129939. luporl added a comment. Changed implementation to make only x87DoubleExtended a special case. https://reviews.llvm.org/D42083 Files: source/Core/DumpDataExtractor.cpp Index: source/Core/DumpDataExtractor.cpp ==

[Lldb-commits] [PATCH] D42083: [lldb][PPC64] Fixed long double variables dump

luporl added a comment. @labath, the change you suggested really looks better, by reducing the number of special cases. I tested it on PPC64 and it also fixes the issue, as expected. I'll update the diff. Thanks! Repository: rL LLVM https://reviews.llvm.org/D42083 __