[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-29 Thread Lang Hames via lldb-commits
https://github.com/lhames approved this pull request. https://github.com/llvm/llvm-project/pull/99336 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [llvm] [lldb][RISCV] function calls support in lldb expressions (PR #99336)

2024-09-29 Thread Lang Hames via lldb-commits
lhames wrote: > @lhames could you take a look, please? Hi @dlav-sc. The `RuntimeDyld` changes look ok to me. We are hoping to switch LLDB to ORC / JITLink soon (https://discourse.llvm.org/t/rfc-removing-mcjit-and-runtimedyld/80464), but JITLink's RISCV support is pretty solid already -- I don

[Lldb-commits] [lldb] e6cbea1 - Revert "[lldb] unique_ptr-ify some GetUserExpression APIs. (#106034)"

2024-08-27 Thread Lang Hames via lldb-commits
Author: Lang Hames Date: 2024-08-28T15:49:40+10:00 New Revision: e6cbea11578f197589801297d22b9b3bc4f1bd10 URL: https://github.com/llvm/llvm-project/commit/e6cbea11578f197589801297d22b9b3bc4f1bd10 DIFF: https://github.com/llvm/llvm-project/commit/e6cbea11578f197589801297d22b9b3bc4f1bd10.diff LO

[Lldb-commits] [lldb] [lldb] unique_ptr-ify some GetUserExpression APIs. (PR #106034)

2024-08-27 Thread Lang Hames via lldb-commits
https://github.com/lhames closed https://github.com/llvm/llvm-project/pull/106034 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] unique_ptr-ify some GetUserExpression APIs. (PR #106034)

2024-08-25 Thread Lang Hames via lldb-commits
https://github.com/lhames created https://github.com/llvm/llvm-project/pull/106034 These methods already returned a uniquely owned object, this just makes them self-documenting. >From b115f38e01488e0622f5ab1d064b873f9459efeb Mon Sep 17 00:00:00 2001 From: Lang Hames Date: Mon, 26 Aug 2024 13:

[Lldb-commits] [clang] [lldb] [clang][AST] fix ast-print of extern with >=2 declarators, fixed, fixed (PR #98795)

2024-07-17 Thread Lang Hames via lldb-commits
lhames wrote: > > Regarding the orc-rt test failures: I tried building one of the failing > > objects and I can't reproduce the failure. Perhaps, because the tests are > > run on Windows and I'm running on Linux? It would be very helpful if > > @Prabhuk could run the failing command on a debug

[Lldb-commits] [lldb] [llvm] Add a createError variant without error code (NFC) (PR #93209)

2024-05-27 Thread Lang Hames via lldb-commits
lhames wrote: Late to the party here, but some context might be of interest: `inconvertibleErrorCode` was meant to never be used, except with a documented explanation of why no error code could be supplied. The idea was to make conversion between `Error` and `std::error_code` illegal when no e

[Lldb-commits] [lldb] r323163 - [lldb] Fix some C++ virtual method call bugs in LLDB expression evaluation by

2018-01-22 Thread Lang Hames via lldb-commits
Author: lhames Date: Mon Jan 22 15:53:56 2018 New Revision: 323163 URL: http://llvm.org/viewvc/llvm-project?rev=323163&view=rev Log: [lldb] Fix some C++ virtual method call bugs in LLDB expression evaluation by building method override tables for CXXMethodDecls in DWARFASTParserClang::CompleteTyp

Re: [Lldb-commits] [lldb] r318039 - Revert "[lldb] Use OrcMCJITReplacement rather than MCJIT as the underlying JIT for LLDB"

2017-11-13 Thread Lang Hames via lldb-commits
For the curious: The relocation issue is one of two known incompatibilities between OrcMCJIT and MCJIT. I'm working on an ORC refactor that should eliminate both, at which point we can try this out again (with OrcMCJITReplacement properly #included this time). Cheers, Lang. On Mon, Nov 13, 2017 a

Re: [Lldb-commits] [lldb] r318039 - Revert "[lldb] Use OrcMCJITReplacement rather than MCJIT as the underlying JIT for LLDB"

2017-11-13 Thread Lang Hames via lldb-commits
Oops -- I thought I'd reverted this ages ago. Evidently not. Thanks Pavel! -- Lang. On Mon, Nov 13, 2017 at 6:03 AM, Pavel Labath via lldb-commits < lldb-commits@lists.llvm.org> wrote: > Author: labath > Date: Mon Nov 13 06:03:17 2017 > New Revision: 318039 > > URL: http://llvm.org/viewvc/llvm-p

[Lldb-commits] [lldb] r310984 - Fix typo in variable name.

2017-08-15 Thread Lang Hames via lldb-commits
Author: lhames Date: Tue Aug 15 18:50:32 2017 New Revision: 310984 URL: http://llvm.org/viewvc/llvm-project?rev=310984&view=rev Log: Fix typo in variable name. Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt Modified: lldb/trunk/tools/debugserver/source/CMakeLists.txt URL: http

[Lldb-commits] [lldb] r302584 - Import sys in repo.py.

2017-05-09 Thread Lang Hames via lldb-commits
Author: lhames Date: Tue May 9 15:37:01 2017 New Revision: 302584 URL: http://llvm.org/viewvc/llvm-project?rev=302584&view=rev Log: Import sys in repo.py. The find function in repo.py calls sys.exit on error. Without this import that call to exit will fail, masking the actual error message. This

[Lldb-commits] [lldb] r302314 - Add DidStartExecuting/WillFinishExecuting methods to Expression.

2017-05-05 Thread Lang Hames via lldb-commits
Author: lhames Date: Fri May 5 17:42:13 2017 New Revision: 302314 URL: http://llvm.org/viewvc/llvm-project?rev=302314&view=rev Log: Add DidStartExecuting/WillFinishExecuting methods to Expression. These methods can be used by the derived expression types to perform expression specific and/or lan

[Lldb-commits] [lldb] r301493 - Fix libcxx formatters for changes in r300140.

2017-04-26 Thread Lang Hames via lldb-commits
Author: lhames Date: Wed Apr 26 18:29:59 2017 New Revision: 301493 URL: http://llvm.org/viewvc/llvm-project?rev=301493&view=rev Log: Fix libcxx formatters for changes in r300140. Summary: LLVM r300140 changed the layout and field names of __compressed_pair, which broke LLDB's std::vector, std::ma

[Lldb-commits] [lldb] r301441 - Use llvm::ArrayRef rather than std::vector/std::initializer lists for some

2017-04-26 Thread Lang Hames via lldb-commits
Author: lhames Date: Wed Apr 26 13:15:40 2017 New Revision: 301441 URL: http://llvm.org/viewvc/llvm-project?rev=301441&view=rev Log: Use llvm::ArrayRef rather than std::vector/std::initializer lists for some ValueObject methods. Using ArrayRef allows us to remove some overloads, work with more ar

[Lldb-commits] [lldb] r279327 - [lldb] Use OrcMCJITReplacement rather than MCJIT as the underlying JIT for LLDB

2016-08-19 Thread Lang Hames via lldb-commits
Author: lhames Date: Fri Aug 19 16:27:16 2016 New Revision: 279327 URL: http://llvm.org/viewvc/llvm-project?rev=279327&view=rev Log: [lldb] Use OrcMCJITReplacement rather than MCJIT as the underlying JIT for LLDB expression evaluation. OrcMCJITReplacement is a reimplementation of MCJIT using ORC

[Lldb-commits] [lldb] r264449 - Fix now-ambiguous references to Error.

2016-03-25 Thread Lang Hames via lldb-commits
Author: lhames Date: Fri Mar 25 14:27:24 2016 New Revision: 264449 URL: http://llvm.org/viewvc/llvm-project?rev=264449&view=rev Log: Fix now-ambiguous references to Error. Modified: lldb/trunk/source/Plugins/ExpressionParser/Clang/ClangExpressionParser.cpp Modified: lldb/trunk/source/Plugin