lhames added a comment.
Yeah -- this seems like a good idea to me. Thanks Reid!
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D111454/new/
https://reviews.llvm.org/D111454
___
lldb-commits mailing list
ll
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
Belatedly -- LGTM.
I think an orc-greedy mode for LLI sounds like a great idea. Also, once we have
it we should probably make it the default mode instead of MCJIT.
Repository:
rG LLVM Gith
lhames added a comment.
LGTM.
I haven't looked at process memory management. How hard would your FIXME be to
implement?
- Lang.
https://reviews.llvm.org/D47551
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bi
lhames accepted this revision.
lhames added a comment.
Committed in r323163.
Comment at: Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2106
+// a vtable entry) from overloads (which require distinct entries).
+static bool isOverload(clang::CXXMethodDecl *m1, clang::CXXMethod
lhames updated this revision to Diff 130284.
lhames added a comment.
Updated to address review comments:
- assert changed to lldbassert
- comments added
- test case breakpoint comment simplified
- unused import removed from testcase
- testcase Makefile cleaned up
Repository:
rL LLVM
https://
lhames added inline comments.
Comment at: Plugins/SymbolFile/DWARF/DWARFASTParserClang.cpp:2103
+static bool isOverload(clang::CXXMethodDecl *m1, clang::CXXMethodDecl *m2) {
+ // FIXME: This should detect covariant return types, but currently doesn't.
aprantl
lhames created this revision.
lhames added a reviewer: davide.
lhames added a project: LLDB.
Herald added subscribers: llvm-commits, JDevlieghere.
Failure to build the method override tables results in expression failures on
the following trivial test case:
class Base {
public:
virtual ~
lhames added a comment.
I prefer the lambda syntax: Locking with an argument requires you to know the
idiom (which wasn't immediately obvious to me), whereas the lambda enforces it
implicitly.
We could also consider writing an atomic access adapter for this (and other
types). That would be gen
lhames added inline comments.
Comment at: source/Symbol/ClangExternalASTSourceCommon.cpp:24
+template
+static decltype(std::declval()(std::declval()))
+WithExclusiveSourceMap(FnType fn) {
Does std::result_of::type work as the return type?
http://en.cppreference
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
LGTM. :)
And yes - I think it's reasonable to add that MCJIT unit test case too.
Thanks for working on this!
https://reviews.llvm.org/D32899
__
lhames requested changes to this revision.
lhames added a comment.
This revision now requires changes to proceed.
Hi Pavel,
This should be an llvm-rtdyld lit test (the unit-test is impressive, but this
is RuntimeDyld specific so llvm-rtdyld is more appropriate). I've modified
llvm-rtdyld and Ru
lhames accepted this revision.
lhames added a comment.
This revision is now accepted and ready to land.
Approving the LLDB/Linux working again.
Thanks for digging in to this Pavel. Greg Clayton appears to have hit the same
issue recently too. Digging through bugs.llvm.org, it looks like this mig
12 matches
Mail list logo
