kimgr wrote:
Thanks!
https://github.com/llvm/llvm-project/pull/103388
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
kimgr wrote:
> > Do we need anything more to make progress with this PR?
>
> @kimgr Do you have committer permission? Would you like some help to get this
> merged?
Oh, no, I don't, I would need someone to merge this for me. It's still pretty
early in the v.20 cycle, right, so maybe this is a
kimgr wrote:
> > Is there an out-of-tree scenario where CLANG_RESOURCE_DIR needs to be
> > replaced with something else at runtime, i.e. a real use-case for the
> > optional CustomResourceDir optional argument I removed?
>
> @kimgr I have also looked for this and I haven't found an use-case wh
kimgr wrote:
Do we need anything more to make progress with this PR?
My own primary concerns are basically things I can't check myself:
* Is there an out-of-tree scenario where `CLANG_RESOURCE_DIR` needs to be
replaced with something else at runtime, i.e. a real use-case for the optional
`Cus
kimgr wrote:
@nico You're the original author of this thing back in 2019, maybe you have
some additional information. Please take a look if you have a chance.
https://github.com/llvm/llvm-project/pull/103388
___
lldb-commits mailing list
lldb-commits@
https://github.com/kimgr updated
https://github.com/llvm/llvm-project/pull/103388
From 3722d673ee409c1320c9d66aa2f3f6568ffdfd77 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Kim=20Gr=C3=A4sman?=
Date: Mon, 5 Aug 2024 11:49:32 +0200
Subject: [PATCH] Use CLANG_RESOURCE_DIR more consistently
When Clan
https://github.com/kimgr created
https://github.com/llvm/llvm-project/pull/103388
When Clang is consumed as a library, the CLANG_RESOURCE_DIR definition is not
exported from the CMake system, so external clients will be unable to compute
the same resource dir as Clang itself would, because the
