Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

loladiro added a comment. Sorry I've been away. No this didn't make it in before the Makefiles were removed from trunk. What would you prefer we do? http://reviews.llvm.org/D16284 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lis

Re: [Lldb-commits] [PATCH] D16284: Fix Makefile build

loladiro accepted this revision. loladiro added subscribers: clayborg, hans. loladiro added a comment. This revision is now accepted and ready to land. LGTM. The Makefile system will be removed from trunk very soon, so it might not necessarily make sense there, but I think it would be good to ge

Re: [Lldb-commits] [PATCH] D15715: Don't pack the structs of the jit debug interface

loladiro accepted this revision. loladiro added a comment. This revision is now accepted and ready to land. Ok, I see. Yes, I agree with this change. LGTM. http://reviews.llvm.org/D15715 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http

Re: [Lldb-commits] [PATCH] D15715: Don't pack the structs of the jit debug interface

loladiro added a comment. I don't think that was part of the code I originally had, but I suppose this was added for 32bit compatibility? Would this do the right thing with a 32bit target? http://reviews.llvm.org/D15715 ___ lldb-commits mailing li

Re: [Lldb-commits] [PATCH] D12890: Add plugin.jit-loader.gdb.enable-jit-breakpoint property to make JIT loader breakpoint optional.

loladiro added a subscriber: loladiro. loladiro added a comment. @clayborg Given that this was merged, does it make sense to now allow the JITLoader to be created on OS X as well, but set the setting to false by default? Does that address the performance concern you had initially? http://revie

[Lldb-commits] [lldb] r250751 - Revert r248047 and fix the problem properly

Author: kfischer Date: Mon Oct 19 17:59:16 2015 New Revision: 250751 URL: http://llvm.org/viewvc/llvm-project?rev=250751&view=rev Log: Revert r248047 and fix the problem properly In r248047, I attempted to fix a build breakage introduced by using llvm's regex support from lldb-mi. However, my app

[Lldb-commits] [lldb] r250494 - Fix build with python disabled after r249597

Author: kfischer Date: Fri Oct 16 00:21:23 2015 New Revision: 250494 URL: http://llvm.org/viewvc/llvm-project?rev=250494&view=rev Log: Fix build with python disabled after r249597 Summary: r249597 introduced a usage of GetTypeSummary in lldb-mi. That function used to only be available when python

[Lldb-commits] [lldb] r250493 - Add a missing Mutex Locker in ResetCurrentInlinedDepth

Author: kfischer Date: Fri Oct 16 00:17:25 2015 New Revision: 250493 URL: http://llvm.org/viewvc/llvm-project?rev=250493&view=rev Log: Add a missing Mutex Locker in ResetCurrentInlinedDepth Summary: This function reads m_frames, so it needs to lock the mutex like all other function that access m_

[Lldb-commits] [PATCH] D13638: Add a missing Mutex Locker in ResetCurrentInlinedDepth

loladiro created this revision. loladiro added reviewers: clayborg, jingham. loladiro added a subscriber: lldb-commits. loladiro set the repository for this revision to rL LLVM. This function reads m_frames, so it needs to lock the mutex like all other function that access m_frames. Found using A

Re: [Lldb-commits] [PATCH] D13202: [LLDB] Fix display of value of a vector variables in watchpoint operations

loladiro added a subscriber: loladiro. loladiro added a comment. Shouldn't that test have been inside the test/ folder? Repository: rL LLVM http://reviews.llvm.org/D13202 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm

[Lldb-commits] [PATCH] D13577: Fix build with python disabled after r249597

loladiro created this revision. loladiro added reviewers: evgeny777, ki.stfu, granata.enrico, clayborg. loladiro added a subscriber: lldb-commits. loladiro set the repository for this revision to rL LLVM. r249597 introduced a usage of GetTypeSummary in lldb-mi. That function used to only be avail

[Lldb-commits] [lldb] r248047 - Fix Makefile build by adding LLVMSupport to liblldb

Author: kfischer Date: Fri Sep 18 16:32:10 2015 New Revision: 248047 URL: http://llvm.org/viewvc/llvm-project?rev=248047&view=rev Log: Fix Makefile build by adding LLVMSupport to liblldb `llvm-mi` now depends on the regex functionality available in LLVM's support library. Modified: lldb/trun

[Lldb-commits] [lldb] r246932 - Fix Makefile build

Author: kfischer Date: Sat Sep 5 15:01:56 2015 New Revision: 246932 URL: http://llvm.org/viewvc/llvm-project?rev=246932&view=rev Log: Fix Makefile build Added: lldb/trunk/source/Plugins/ExpressionParser/Clang/Makefile lldb/trunk/source/Plugins/Language/CPlusPlus/Makefile lldb/trunk/s

[Lldb-commits] [lldb] r245808 - Also initialize ScriptInterpreterNone if Python is disabled

Author: kfischer Date: Sun Aug 23 04:05:29 2015 New Revision: 245808 URL: http://llvm.org/viewvc/llvm-project?rev=245808&view=rev Log: Also initialize ScriptInterpreterNone if Python is disabled Summary: We get an assertion otherwise because the None Interpreter cannot be found Reviewers: zturn

[Lldb-commits] [PATCH] D11898: Also initialize ScriptInterpreterNone if Python is disabled

loladiro created this revision. loladiro added a reviewer: zturner. loladiro added a subscriber: lldb-commits. loladiro set the repository for this revision to rL LLVM. We get an assertion otherwise because the None Interpreter cannot be found Repository: rL LLVM http://reviews.llvm.org/D11898