[Lldb-commits] [lldb] [lldb] Fix ubsan violation with plugin loading (PR #126652)

2025-02-11 Thread Keith Smiley via lldb-commits
https://github.com/keith closed https://github.com/llvm/llvm-project/pull/126652 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Fix ubsan violation with plugin loading (PR #126652)

2025-02-10 Thread Keith Smiley via lldb-commits
https://github.com/keith created https://github.com/llvm/llvm-project/pull/126652 This typedef doesn't match the signature below, specifically the signature takes a `lldb:SBDebugger` vs this was defined as `lldb:SBDebugger&`. ``` lldb/source/API/SBDebugger.cpp:199:13: runtime error: call to fu

[Lldb-commits] [lldb] [lldb-dap] Silence Wunused-result warning (PR #126580)

2025-02-10 Thread Keith Smiley via lldb-commits
https://github.com/keith closed https://github.com/llvm/llvm-project/pull/126580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Silence Wunused-result warning (PR #126580)

2025-02-10 Thread Keith Smiley via lldb-commits
keith wrote: showed up since https://github.com/llvm/llvm-project/commit/adb9ef035552d7fc42a34560677f89f4f6421295 https://github.com/llvm/llvm-project/pull/126580 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [lldb] [lldb-dap] Silence Wunused-result warning (PR #126580)

2025-02-10 Thread Keith Smiley via lldb-commits
keith wrote: ``` lldb/tools/lldb-dap/OutputRedirector.cpp:89:5: error: ignoring return value of function declared with 'warn_unused_result' attribute [-Werror,-Wunused-result] 89 | ::write(fd, buf, sizeof(buf)); | ^~~ 1 error generated. ``` https://gith

[Lldb-commits] [lldb] [lldb-dap] Silence Wunused-result warning (PR #126580)

2025-02-10 Thread Keith Smiley via lldb-commits
https://github.com/keith created https://github.com/llvm/llvm-project/pull/126580 None >From bb41fdf6021c7a62bf77096bc4ce31e8e9311577 Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Mon, 10 Feb 2025 19:00:31 + Subject: [PATCH] [lldb-dap] Silence Wunused-result warning --- lldb/tools/ll

[Lldb-commits] [lldb] [llvm] Revert "[LLDB] Add a target.launch-working-dir setting" (PR #114973)

2024-12-20 Thread Keith Smiley via lldb-commits
keith wrote: did this one reland somewhere? https://github.com/llvm/llvm-project/pull/114973 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Escape ? for zsh (PR #112107)

2024-10-14 Thread Keith Smiley via lldb-commits
keith wrote: Oh yea great point. I guess another way to put that is if I copy the exact same invocation and run it directly it works, so that differing is unexpected. https://github.com/llvm/llvm-project/pull/112107 ___ lldb-commits mailing list lldb

[Lldb-commits] [lldb] [lldb] Escape ? for zsh (PR #112107)

2024-10-14 Thread Keith Smiley via lldb-commits
keith wrote: hmm good point. I wonder if the fix here should be around surfacing the error to users then, so they know they have to escape it depending on their use case https://github.com/llvm/llvm-project/pull/112107 ___ lldb-commits mailing list ll

[Lldb-commits] [lldb] [lldb] Escape ? for zsh (PR #112107)

2024-10-12 Thread Keith Smiley via lldb-commits
https://github.com/keith created https://github.com/llvm/llvm-project/pull/112107 Previously on macOS with lldb-argdumper if you ran: ``` lldb -o r -- /tmp/foo "some arg?" ``` It would fail with this error: ``` error: shell expansion failed (reason: lldb-argdumper exited with error 1). consi

[Lldb-commits] [lldb] [LLDB][OSX] Add a fallback support exe directory (PR #103458)

2024-08-13 Thread Keith Smiley via lldb-commits
keith wrote: note that this is similar to lldb-server is discovered on linux as well https://github.com/llvm/llvm-project/pull/103458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB][OSX] Add a fallback support exe directory (PR #103458)

2024-08-13 Thread Keith Smiley via lldb-commits
https://github.com/keith approved this pull request. lgtm, but not a LLDB expert https://github.com/llvm/llvm-project/pull/103458 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Add maybe_unused to err used in asserts (PR #98055)

2024-07-08 Thread Keith Smiley via lldb-commits
https://github.com/keith created https://github.com/llvm/llvm-project/pull/98055 None >From 6a6fc355e3623a0d0aacc465220a562e103e6dfc Mon Sep 17 00:00:00 2001 From: Keith Smiley Date: Mon, 8 Jul 2024 10:28:22 -0700 Subject: [PATCH] [lldb][NFC] Add maybe_unused to err used in asserts --- lldb/t

[Lldb-commits] [clang] [compiler-rt] [lldb] [llvm] [Support] Remove terminfo dependency (PR #92865)

2024-05-21 Thread Keith Smiley via lldb-commits
keith wrote: looks like the .bazelrc still has mentions of this https://github.com/llvm/llvm-project/pull/92865 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Allow env override for LLDB_ARGDUMPER_PATH (PR #91688)

2024-05-14 Thread Keith Smiley via lldb-commits
https://github.com/keith closed https://github.com/llvm/llvm-project/pull/91688 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Allow env override for LLDB_ARGDUMPER_PATH (PR #91688)

2024-05-09 Thread Keith Smiley via lldb-commits
https://github.com/keith created https://github.com/llvm/llvm-project/pull/91688 This mirrors the LLDB_DEBUGSERVER_PATH environment variable and allows you to have lldb-argdumper in a non-standard location and still use it at runtime. >From 98ddf4ed99a10c46a43d9a750bd826623a8c7e6f Mon Sep 17 00

[Lldb-commits] [lldb] 0c4464a - [lldb] Fix formatted log statement

2021-11-18 Thread Keith Smiley via lldb-commits
Author: Keith Smiley Date: 2021-11-18T15:09:38-08:00 New Revision: 0c4464a5bd35dd865f568ed68171208e44df16c7 URL: https://github.com/llvm/llvm-project/commit/0c4464a5bd35dd865f568ed68171208e44df16c7 DIFF: https://github.com/llvm/llvm-project/commit/0c4464a5bd35dd865f568ed68171208e44df16c7.diff

[Lldb-commits] [lldb] 0f3254b - [lldb] Improve help for platform put-file

2021-10-05 Thread Keith Smiley via lldb-commits
Author: Keith Smiley Date: 2021-10-05T10:29:37-07:00 New Revision: 0f3254b29f375d449e815e91d63bef78d9e81354 URL: https://github.com/llvm/llvm-project/commit/0f3254b29f375d449e815e91d63bef78d9e81354 DIFF: https://github.com/llvm/llvm-project/commit/0f3254b29f375d449e815e91d63bef78d9e81354.diff