[Lldb-commits] [PATCH] D114178: [lldb] Fix formatted log statement

This revision was automatically updated to reflect the committed changes. Closed by commit rG0c4464a5bd35: [lldb] Fix formatted log statement (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D114178/new/ https://reviews.llvm.org/D11

[Lldb-commits] [PATCH] D114178: [lldb] Fix formatted log statement

keith created this revision. keith added reviewers: kastiglione, aprantl. keith requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Previously this would output literally without replacements Repository: rG LLVM Github Monorepo https://rev

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

This revision was automatically updated to reflect the committed changes. Closed by commit rG0f3254b29f37: [lldb] Improve help for platform put-file (authored by keith). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110981/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

keith updated this revision to Diff 377010. keith marked an inline comment as done. keith added a comment. Update text about resolving paths Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D110981/new/ https://reviews.llvm.org/D110981 Files: lldb/s

[Lldb-commits] [PATCH] D110981: [lldb] Improve help for platform put-file

keith created this revision. keith added a reviewer: kastiglione. keith requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Herald added a subscriber: JDevlieghere. Previously it was not clear what arguments this required, or what it would do

[Lldb-commits] [PATCH] D49776: Update framework-header-fix to force system sed

keith added a subscriber: kastiglione. keith added a comment. No worries, thanks! - Keith Smiley Repository: rL LLVM https://reviews.llvm.org/D49776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

keith added a comment. No problem! Yes please! :) https://reviews.llvm.org/D49779 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

keith added inline comments. Comment at: cmake/modules/LLDBFramework.cmake:41 +add_custom_target(lldb-framework-headers + DEPENDS ${framework_headers} + COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh xiaobai wrote: > keith wrote: > > xiaobai wrote:

[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

keith updated this revision to Diff 157547. keith added a comment. - Hoist LLDB.framework headers copy out of condition https://reviews.llvm.org/D49779 Files: cmake/modules/LLDBFramework.cmake Index: cmake/modules/LLDBFramework.cmake =

[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

keith added inline comments. Comment at: cmake/modules/LLDBFramework.cmake:41 +add_custom_target(lldb-framework-headers + DEPENDS ${framework_headers} + COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh xiaobai wrote: > keith wrote: > > xiaobai wrote:

[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

keith added inline comments. Comment at: cmake/modules/LLDBFramework.cmake:41 +add_custom_target(lldb-framework-headers + DEPENDS ${framework_headers} + COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh xiaobai wrote: > keith wrote: > > xiaobai wrote:

[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

keith added inline comments. Comment at: cmake/modules/LLDBFramework.cmake:41 +add_custom_target(lldb-framework-headers + DEPENDS ${framework_headers} + COMMAND ${LLDB_SOURCE_DIR}/scripts/framework-header-fix.sh xiaobai wrote: > This should not just depend on `

[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

keith updated this revision to Diff 157525. keith added a comment. - Make headers a post build command https://reviews.llvm.org/D49779 Files: cmake/modules/LLDBFramework.cmake Index: cmake/modules/LLDBFramework.cmake === --- cm

[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

keith added inline comments. Comment at: cmake/modules/LLDBFramework.cmake:21 add_custom_command(TARGET lldb-framework POST_BUILD COMMAND ${CMAKE_COMMAND} -E copy_directory ${CMAKE_CURRENT_BINARY_DIR}/FrameworkHeaders $/Headers COMMAND ${CMAKE_COMMAND} -E create_sym

[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

keith added a comment. It seems like if this was a common occurrence, it would've been fixed earlier, so I'm wondering if there's a difference in the way I'm building lldb that causes this. Using cmake: cmake ../llvm -G Ninja -DCMAKE_BUILD_TYPE=Debug -DCMAKE_EXPORT_COMPILE_COMMANDS=YES -DLLD

[Lldb-commits] [PATCH] D49779: Make framework-header-fix process copied headers

keith created this revision. keith added reviewers: kastiglione, beanz. Herald added a subscriber: mgorny. Previously the framework-header-fix script would change the sources before they were copied, leading to unnecessary rebuilds on repeat `ninja lldb` invocations. This runs the script on the he