[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 added a comment. In D126464#3628819 , @thakis wrote: > What `--author` flag should I use for you when landing this? Hi! Could you please use --author="Kaining Zhong "? Thanks! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/n

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commi

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 added a comment. Hi, sorry to interrupt but I just forgot to mention that I didn't have access to commit. Anyone can please help me land this one if it looks ok? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464 ___

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 added a comment. Herald added a subscriber: Michael137. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 updated this revision to Diff 434391. PRESIDENT810 added a comment. Herald added a subscriber: mgorny. Add tests by introducing llvm-ar to produce thin archives CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126464/new/ https://reviews.llvm.org/D126464 Files: lldb/source/

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 updated this revision to Diff 432857. PRESIDENT810 added a comment. I have refactored my code so it should looks cleaner now, but I'm not sure how to add a test. It seems that adding a test for thin archive on macOS platforms can be not so straightforward. I see that in lldb/test/A

[Lldb-commits] [PATCH] D126464: [lldb] Add support to load object files from thin archives

PRESIDENT810 created this revision. PRESIDENT810 added reviewers: clayborg, jingham, jasonmolenda. Herald added a project: All. PRESIDENT810 requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This fixes https://github.com/llvm/llvm-project/iss