[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-07 Thread Julian Lettner via lldb-commits
https://github.com/yln closed https://github.com/llvm/llvm-project/pull/134323 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/134323 >From 8aa5e0e7f97df7627187bbd8ad4b3df51c798f4f Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Thu, 3 Apr 2025 14:47:53 -0700 Subject: [PATCH 1/5] [LLDB] Update reason for why tests are disabled --- lldb/test/A

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -36,35 +42,59 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() - -self.runCmd( -"env Sanitizer

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/134323 >From 8aa5e0e7f97df7627187bbd8ad4b3df51c798f4f Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Thu, 3 Apr 2025 14:47:53 -0700 Subject: [PATCH 1/4] [LLDB] Update reason for why tests are disabled --- lldb/test/A

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/134323 >From 8aa5e0e7f97df7627187bbd8ad4b3df51c798f4f Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Thu, 3 Apr 2025 14:47:53 -0700 Subject: [PATCH 1/3] [LLDB] Update reason for why tests are disabled --- lldb/test/A

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -36,34 +42,61 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() +# for libsanitizers and remove `skip_line_numb

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -15,17 +15,23 @@ class AsanTestCase(TestBase): @expectedFailureNetBSD @skipUnlessAddressSanitizer def test(self): -self.build(make_targets=["asan"]) +self.build(make_targets=["compiler_rt-asan"]) self.asan_tests() -@skipIf(oslist=no

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -15,17 +15,23 @@ class AsanTestCase(TestBase): @expectedFailureNetBSD @skipUnlessAddressSanitizer def test(self): -self.build(make_targets=["asan"]) +self.build(make_targets=["compiler_rt-asan"]) self.asan_tests() yln wro

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-04 Thread Julian Lettner via lldb-commits
@@ -36,34 +42,61 @@ def setUp(self): self.line_breakpoint = line_number("main.c", "// break line") # Test line numbers: rdar://126237493 -def libsanitizer_tests(self): -target = self.createTestTarget() +# for libsanitizers and remove `skip_line_numb

[Lldb-commits] [lldb] [LLDB] Add integration test for libsanitizers trace collection (PR #134323)

2025-04-03 Thread Julian Lettner via lldb-commits
https://github.com/yln created https://github.com/llvm/llvm-project/pull/134323 Add integration test for libsanitizers trace collection (`SanitizersAllocationTraces=all`). rdar://144244084 >From 8aa5e0e7f97df7627187bbd8ad4b3df51c798f4f Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: T

[Lldb-commits] [lldb] Fix handling of auto_continue for stop hooks (PR #129622)

2025-04-01 Thread Julian Lettner via lldb-commits
https://github.com/yln closed https://github.com/llvm/llvm-project/pull/129622 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] Fix handling of auto_continue for stop hooks (PR #129622)

2025-03-13 Thread Julian Lettner via lldb-commits
@@ -3109,7 +3104,10 @@ bool Target::RunStopHooks() { auto result = cur_hook_sp->HandleStop(exc_ctx, output_sp); switch (result) { case StopHook::StopHookResult::KeepStopped: yln wrote: Should the "auto continue" override only apply to `KeepSt

[Lldb-commits] [lldb] Fix a bug copying the stop hooks from the dummy target. (PR #129340)

2025-03-02 Thread Julian Lettner via lldb-commits
https://github.com/yln approved this pull request. Thanks! https://github.com/llvm/llvm-project/pull/129340 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Fix comment in lldb/Core/ModuleList.h (PR #128602)

2025-02-25 Thread Julian Lettner via lldb-commits
https://github.com/yln closed https://github.com/llvm/llvm-project/pull/128602 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb][NFC] Fix comment in lldb/Core/ModuleList.h (PR #128602)

2025-02-24 Thread Julian Lettner via lldb-commits
https://github.com/yln created https://github.com/llvm/llvm-project/pull/128602 None >From 7df56dcd54371b95baf607efb583ccd420b0570e Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Mon, 24 Feb 2025 15:55:11 -0800 Subject: [PATCH] [lldb][NFC] Fix comment in lldb/Core/ModuleList.h --- lldb/i

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

2025-01-06 Thread Julian Lettner via lldb-commits
https://github.com/yln closed https://github.com/llvm/llvm-project/pull/94794 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

2024-06-27 Thread Julian Lettner via lldb-commits
@@ -90,17 +90,9 @@ void InstrumentationRuntimeASanLibsanitizers::Activate() { if (!process_sp) return; - lldb::ModuleSP module_sp = GetRuntimeModuleSP(); - Breakpoint *breakpoint = ReportRetriever::SetupBreakpoint( - module_sp, process_sp, ConstString("sanitizer

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

2024-06-07 Thread Julian Lettner via lldb-commits
https://github.com/yln updated https://github.com/llvm/llvm-project/pull/94794 >From 40fd912a328cd9f7918a9f9c12f8cfd97094fc2f Mon Sep 17 00:00:00 2001 From: Julian Lettner Date: Fri, 7 Jun 2024 09:20:23 -0700 Subject: [PATCH 1/2] [lldb] Use `Address` to setup breakpoint Use `Address` (instead o

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

2024-06-07 Thread Julian Lettner via lldb-commits
@@ -235,18 +234,13 @@ Breakpoint *ReportRetriever::SetupBreakpoint(ModuleSP module_sp, if (!symbol->ValueIsAddress() || !symbol->GetAddressRef().IsValid()) return nullptr; - Target &target = process_sp->GetTarget(); - addr_t symbol_address = symbol->GetAddressRef().G

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

2024-06-07 Thread Julian Lettner via lldb-commits
@@ -90,17 +90,9 @@ void InstrumentationRuntimeASanLibsanitizers::Activate() { if (!process_sp) return; - lldb::ModuleSP module_sp = GetRuntimeModuleSP(); - Breakpoint *breakpoint = ReportRetriever::SetupBreakpoint( - module_sp, process_sp, ConstString("sanitizer

[Lldb-commits] [lldb] [lldb] Use `Address` to setup breakpoint (PR #94794)

2024-06-07 Thread Julian Lettner via lldb-commits
https://github.com/yln created https://github.com/llvm/llvm-project/pull/94794 Use `Address` (instead of `addr_t`) to setup breakpoint in `ReportRetriever::SetupBreakpoint`. This is cleaner and the breakpoint should now survive re-running of the binary. rdar://124399066 >From 988d184eb52824810f

[Lldb-commits] [lldb] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint (PR #84583)

2024-03-08 Thread Julian Lettner via lldb-commits
yln wrote: @jimingham, thanks for the review and feedback on how to improve the code. Are you okay with us addressing this in a follow-up? > do you know why it was done this way? I don't think we do. I think we just copied what was done in the old ASan plugin. > survives rebuilds I think

[Lldb-commits] [lldb] [LLDB] ASanLibsanitizers Use `sanitizers_address_on_report` breakpoint (PR #84583)

2024-03-08 Thread Julian Lettner via lldb-commits
https://github.com/yln approved this pull request. LGTM, thanks! https://github.com/llvm/llvm-project/pull/84583 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits