Sorry for missing this! What options should I use when running it?
On Mon, Sep 19, 2016 at 2:31 PM, Eugene Zelenko
wrote:
> Eugene.Zelenko added a subscriber: Eugene.Zelenko.
> Eugene.Zelenko added a comment.
>
> Please rebase from trunk and run Clang-format.
>
>
> Repository:
> rL LLVM
>
> h
jafl updated this revision to Diff 67405.
jafl added a comment.
Incorporate additional feedback from Greg Clayton.
Repository:
rL LLVM
https://reviews.llvm.org/D22831
Files:
include/lldb/API/SBAddress.h
Index: include/lldb/API/SBAddress.h
==
jafl updated this revision to Diff 66678.
jafl added a comment.
Incorporated feedback
Repository:
rL LLVM
https://reviews.llvm.org/D22831
Files:
include/lldb/API/SBAddress.h
Index: include/lldb/API/SBAddress.h
===
--- include
I never heard back on this. Should I file a ticket?
Thanks,
John
On Thu, Apr 7, 2016 at 4:59 PM, John Lindal wrote:
> The patch is based off the latest code in the github mirror. It includes
> some documentation changes for other classes, but the primary change is for
> SBAddress. I intend t
The patch is based off the latest code in the github mirror. It includes
some documentation changes for other classes, but the primary change is for
SBAddress. I intend to fill out the other classes in separate patches.
I do not have committer access. Can somebody please merge this in?
Thanks,
The patch is based off the latest code in the github mirror. It includes
some documentation changes for other classes, but the primary change is for
SBAddress. I intend to fill out the other classes in separate patches.
I do not have committer access. Can somebody please merge this in?
Thanks,
> >
> > > isn't quite right. "The scope in which to resolve the address" makes
> it sound like this specifies some context you are using to resolve the
> address,
> > > but it really determines how much information to fetch in the symbol
> context
> > SymbolContextItem (maybe where we document FindFunctions?) But in any
> case, here you can just "specifying how much information to fill in in the
> returned
> > SymbolContext.
> >
> > Jim
> >
> >
> >
> > > On Mar 9, 2016, at 2:24 PM, Jo
ed, Mar 9, 2016 at 11:56 AM, Jim Ingham wrote:
> > In the case of something like SBAddress, I think it would be better to
> have a class header that explains file/load addresses and section offset
> addresses. Then you can just use the terms in the function documentation,
> and they
ion does. It also means it is hard to avoid redundantly redefining
> terms as they are used in different functions.
>
> Thanks for starting this process!
>
> Jim
>
>
> > On Mar 9, 2016, at 11:47 AM, John Lindal via lldb-commits <
> lldb-commits@lists.llvm.org> wrote:
Having completed my C++ app on top of lldb, I would like to improve the
function-level documentation so others don't have to blunder around in the
dark the way I did :)
Here is a patch for SBAddress.h
If this is the right direction, I will work my way through the rest of the
SB*.h files.
Thanks!
11 matches
Mail list logo