Re: [Lldb-commits] [PATCH] D22831: [LLDB] Documentation for SBAddress class

2017-04-04 Thread John Lindal via lldb-commits
Sorry for missing this! What options should I use when running it? On Mon, Sep 19, 2016 at 2:31 PM, Eugene Zelenko wrote: > Eugene.Zelenko added a subscriber: Eugene.Zelenko. > Eugene.Zelenko added a comment. > > Please rebase from trunk and run Clang-format. > > > Repository: > rL LLVM > > h

Re: [Lldb-commits] [PATCH] D22831: [LLDB] Documentation for SBAddress class

2016-08-09 Thread John Lindal via lldb-commits
jafl updated this revision to Diff 67405. jafl added a comment. Incorporate additional feedback from Greg Clayton. Repository: rL LLVM https://reviews.llvm.org/D22831 Files: include/lldb/API/SBAddress.h Index: include/lldb/API/SBAddress.h ==

Re: [Lldb-commits] [PATCH] D22831: [LLDB] Documentation for SBAddress class

2016-08-03 Thread John Lindal via lldb-commits
jafl updated this revision to Diff 66678. jafl added a comment. Incorporated feedback Repository: rL LLVM https://reviews.llvm.org/D22831 Files: include/lldb/API/SBAddress.h Index: include/lldb/API/SBAddress.h === --- include

Re: [Lldb-commits] [PATCH] Updated documentation for SBAddress

2016-06-10 Thread John Lindal via lldb-commits
I never heard back on this. Should I file a ticket? Thanks, John On Thu, Apr 7, 2016 at 4:59 PM, John Lindal wrote: > The patch is based off the latest code in the github mirror. It includes > some documentation changes for other classes, but the primary change is for > SBAddress. I intend t

[Lldb-commits] [PATCH] Updated documentation for SBAddress

2016-04-07 Thread John Lindal via lldb-commits
The patch is based off the latest code in the github mirror. It includes some documentation changes for other classes, but the primary change is for SBAddress. I intend to fill out the other classes in separate patches. I do not have committer access. Can somebody please merge this in? Thanks,

[Lldb-commits] Updated documentation for SBAddress

2016-04-06 Thread John Lindal via lldb-commits
The patch is based off the latest code in the github mirror. It includes some documentation changes for other classes, but the primary change is for SBAddress. I intend to fill out the other classes in separate patches. I do not have committer access. Can somebody please merge this in? Thanks,

Re: [Lldb-commits] Improving the documentation

2016-03-19 Thread John Lindal via lldb-commits
> > > > > isn't quite right. "The scope in which to resolve the address" makes > it sound like this specifies some context you are using to resolve the > address, > > > but it really determines how much information to fetch in the symbol > context

Re: [Lldb-commits] Improving the documentation

2016-03-15 Thread John Lindal via lldb-commits
> > SymbolContextItem (maybe where we document FindFunctions?) But in any > case, here you can just "specifying how much information to fill in in the > returned > > SymbolContext. > > > > Jim > > > > > > > > > On Mar 9, 2016, at 2:24 PM, Jo

Re: [Lldb-commits] Improving the documentation

2016-03-10 Thread John Lindal via lldb-commits
ed, Mar 9, 2016 at 11:56 AM, Jim Ingham wrote: > > In the case of something like SBAddress, I think it would be better to > have a class header that explains file/load addresses and section offset > addresses. Then you can just use the terms in the function documentation, > and they

Re: [Lldb-commits] Improving the documentation

2016-03-09 Thread John Lindal via lldb-commits
ion does. It also means it is hard to avoid redundantly redefining > terms as they are used in different functions. > > Thanks for starting this process! > > Jim > > > > On Mar 9, 2016, at 11:47 AM, John Lindal via lldb-commits < > lldb-commits@lists.llvm.org> wrote:

[Lldb-commits] Improving the documentation

2016-03-09 Thread John Lindal via lldb-commits
Having completed my C++ app on top of lldb, I would like to improve the function-level documentation so others don't have to blunder around in the dark the way I did :) Here is a patch for SBAddress.h If this is the right direction, I will work my way through the rest of the SB*.h files. Thanks!