jansvoboda11 wrote:
Thanks for the concrete example! I think the key thing to realize is that the
`DiagnosticsEngine` and `DiagnosticOptions` used for command-line parsing are
typically throwaway and separate from those used for actual compilation. I
suggest looking at how `cc1_main()` orchest
jansvoboda11 wrote:
Thanks, I'll fix those ASAP.
https://github.com/llvm/llvm-project/pull/139584
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
jansvoboda11 wrote:
Are those in the upstream repo? If so, where are they coming from? I have a
sparse checkout, so it's possible I missed some non-Clang and non-LLDB usages
of `DiagnosticOptions`.
https://github.com/llvm/llvm-project/pull/139584
___
jansvoboda11 wrote:
Reverted the revert, since the build now fails due to the forward-fixes not
being reverted...
https://github.com/llvm/llvm-project/pull/139584
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin
jansvoboda11 wrote:
> @jansvoboda11 I've revered your PR due buildbot failures above (and my local
> build failures with the same error messages). I'm happy to try your revised
> patch to see if it build cleanly. Thanks!
I already forward-fixed both failures: d25f95fdbc5314f30618912e18f00ad4dd
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/139584
Rate limit ยท GitHub
body {
background-color: #f6f8fa;
color: #24292e;
font-family: -apple-system,BlinkMacSystemFont,Segoe
UI,Helvetica,Arial,s
@@ -837,6 +838,7 @@ class ASTUnit {
static std::unique_ptr LoadFromCommandLine(
const char **ArgBegin, const char **ArgEnd,
std::shared_ptr PCHContainerOps,
+ std::shared_ptr DiagOpts,
jansvoboda11 wrote:
Explained above.
https://github.com
@@ -107,6 +107,7 @@ class ASTUnit {
private:
std::unique_ptr LangOpts;
+ std::shared_ptr DiagOpts;
jansvoboda11 wrote:
I was hoping it could be, but the situation is a bit weird. The documentation
for `ASTUnit::LoadFromCommandLine()` says the `Diagnostics
@@ -2032,6 +2032,7 @@ class SourceManagerForFile {
// as they are created in `createSourceManagerForFile` so that they can be
// deleted in the reverse order as they are created.
std::unique_ptr FileMgr;
+ std::unique_ptr DiagOpts;
jansvoboda11 wrote:
I
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/139584
The `DiagnosticOptions` class is currently intrusively reference-counted, which
makes reasoning about its lifetime very difficult in some cases. For example,
`CompilerInvocation` owns the `DiagnosticOption
jansvoboda11 wrote:
Test change LGTM, I was probably trying to get to a minimal test-case and ended
up with something that was relying on implementation details.
https://github.com/llvm/llvm-project/pull/132853
___
lldb-commits mailing list
lldb-commi
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/137668
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/137668
>From 692779413664a17287a1f34d4e3225ae8bc96ae0 Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Mon, 21 Apr 2025 11:55:43 -0700
Subject: [PATCH 1/2] [clang][frontend] Require invocation for
`CompilerInstan
https://github.com/jansvoboda11 created
https://github.com/llvm/llvm-project/pull/137668
This PR makes it so that `CompilerInvocation` needs to be provided to
`CompilerInstance` on construction. There are a couple of benefits in my view:
* Making it impossible to mis-use some `CompilerInstance`
https://github.com/jansvoboda11 closed
https://github.com/llvm/llvm-project/pull/106271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/106271
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/jansvoboda11 updated
https://github.com/llvm/llvm-project/pull/106271
>From 4431265f6be2b989b63e4562fa8def4448d336ab Mon Sep 17 00:00:00 2001
From: Jan Svoboda
Date: Tue, 27 Aug 2024 09:34:01 -0700
Subject: [PATCH 1/7] [clang] `TargetInfo` does not own `TargetOptions`
---
c
https://github.com/jansvoboda11 approved this pull request.
LGTM, thank you!
https://github.com/llvm/llvm-project/pull/132853
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jan Svoboda
Date: 2025-03-25T12:29:08-07:00
New Revision: bdbad3e4320509f632ae8b511d563136343d87d7
URL:
https://github.com/llvm/llvm-project/commit/bdbad3e4320509f632ae8b511d563136343d87d7
DIFF:
https://github.com/llvm/llvm-project/commit/bdbad3e4320509f632ae8b511d563136343d87d7.diff
L
https://github.com/jansvoboda11 approved this pull request.
LGTM sans the missing newline at the end of file and file headers not aligned
to 80 columns.
https://github.com/llvm/llvm-project/pull/99599
___
lldb-commits mailing list
lldb-commits@lists.l
Author: Jan Svoboda
Date: 2024-04-12T10:48:54-07:00
New Revision: 446d38c65f72fd5d242a64182b05683577f683d3
URL:
https://github.com/llvm/llvm-project/commit/446d38c65f72fd5d242a64182b05683577f683d3
DIFF:
https://github.com/llvm/llvm-project/commit/446d38c65f72fd5d242a64182b05683577f683d3.diff
L
https://github.com/jansvoboda11 approved this pull request.
LGTM once CI passes and Flang conflicts are resolved.
https://github.com/llvm/llvm-project/pull/75530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
@@ -1722,6 +1738,11 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions
&Opts, ArgList &Args,
#include "clang/Driver/Options.inc"
#undef CODEGEN_OPTION_WITH_MARSHALLING
+#define DEBUG_OPTION_WITH_MARSHALLING(...)
\
@@ -224,19 +233,20 @@ class CompilerInvocation : public CompilerInvocationBase {
/// @{
// Note: These need to be pulled in manually. Otherwise, they get hidden by
// the mutable getters with the same names.
- using CompilerInvocationBase::getLangOpts;
- using CompilerI
@@ -11,6 +11,7 @@
#include "clang/APINotes/APINotesOptions.h"
#include "clang/Basic/CodeGenOptions.h"
+#include "clang/Basic/DebugOptions.h"
jansvoboda11 wrote:
Wouldn't a forward declaration be enough in this case?
https://github.com/llvm/llvm-project/pull/
@@ -11,46 +11,13 @@
namespace clang {
-CodeGenOptions::CodeGenOptions() {
-#define CODEGENOPT(Name, Bits, Default) Name = Default;
-#define ENUM_CODEGENOPT(Name, Type, Bits, Default) set##Name(Default);
-#include "clang/Basic/CodeGenOptions.def"
+CodeGenOptions::CodeGenOption
https://github.com/jansvoboda11 requested changes to this pull request.
This looks pretty nice, I left just a couple of notes. You might want to take a
look at the CI failures.
https://github.com/llvm/llvm-project/pull/75530
___
lldb-commits mailing l
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/75530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jan Svoboda
Date: 2023-09-29T10:01:37-07:00
New Revision: 2fc90afdac451b49d67c72bd41a99886811dd36c
URL:
https://github.com/llvm/llvm-project/commit/2fc90afdac451b49d67c72bd41a99886811dd36c
DIFF:
https://github.com/llvm/llvm-project/commit/2fc90afdac451b49d67c72bd41a99886811dd36c.diff
L
Author: Jan Svoboda
Date: 2023-08-04T13:57:13-07:00
New Revision: 3f092f37b7362447cbb13f5502dae4bdd5762afd
URL:
https://github.com/llvm/llvm-project/commit/3f092f37b7362447cbb13f5502dae4bdd5762afd
DIFF:
https://github.com/llvm/llvm-project/commit/3f092f37b7362447cbb13f5502dae4bdd5762afd.diff
L
Author: Jan Svoboda
Date: 2023-06-15T11:59:47+02:00
New Revision: 74113a4150d683c9478331ae91018ab9092a634d
URL:
https://github.com/llvm/llvm-project/commit/74113a4150d683c9478331ae91018ab9092a634d
DIFF:
https://github.com/llvm/llvm-project/commit/74113a4150d683c9478331ae91018ab9092a634d.diff
L
Author: Jan Svoboda
Date: 2023-05-30T14:08:04-07:00
New Revision: e348dbc4b2766f17c251b6c305a3b34fbdb9be96
URL:
https://github.com/llvm/llvm-project/commit/e348dbc4b2766f17c251b6c305a3b34fbdb9be96
DIFF:
https://github.com/llvm/llvm-project/commit/e348dbc4b2766f17c251b6c305a3b34fbdb9be96.diff
L
Author: Jan Svoboda
Date: 2021-12-09T11:32:13+01:00
New Revision: e04fc2d88efa60ed5527b90c15d8fc188739e989
URL:
https://github.com/llvm/llvm-project/commit/e04fc2d88efa60ed5527b90c15d8fc188739e989
DIFF:
https://github.com/llvm/llvm-project/commit/e04fc2d88efa60ed5527b90c15d8fc188739e989.diff
L
33 matches
Mail list logo
