https://github.com/jansvoboda11 approved this pull request.
LGTM, thank you!
https://github.com/llvm/llvm-project/pull/132853
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jan Svoboda
Date: 2025-03-25T12:29:08-07:00
New Revision: bdbad3e4320509f632ae8b511d563136343d87d7
URL:
https://github.com/llvm/llvm-project/commit/bdbad3e4320509f632ae8b511d563136343d87d7
DIFF:
https://github.com/llvm/llvm-project/commit/bdbad3e4320509f632ae8b511d563136343d87d7.diff
L
https://github.com/jansvoboda11 approved this pull request.
LGTM sans the missing newline at the end of file and file headers not aligned
to 80 columns.
https://github.com/llvm/llvm-project/pull/99599
___
lldb-commits mailing list
lldb-commits@lists.l
Author: Jan Svoboda
Date: 2024-04-12T10:48:54-07:00
New Revision: 446d38c65f72fd5d242a64182b05683577f683d3
URL:
https://github.com/llvm/llvm-project/commit/446d38c65f72fd5d242a64182b05683577f683d3
DIFF:
https://github.com/llvm/llvm-project/commit/446d38c65f72fd5d242a64182b05683577f683d3.diff
L
https://github.com/jansvoboda11 approved this pull request.
LGTM once CI passes and Flang conflicts are resolved.
https://github.com/llvm/llvm-project/pull/75530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/m
@@ -1722,6 +1738,11 @@ bool CompilerInvocation::ParseCodeGenArgs(CodeGenOptions
&Opts, ArgList &Args,
#include "clang/Driver/Options.inc"
#undef CODEGEN_OPTION_WITH_MARSHALLING
+#define DEBUG_OPTION_WITH_MARSHALLING(...)
\
@@ -224,19 +233,20 @@ class CompilerInvocation : public CompilerInvocationBase {
/// @{
// Note: These need to be pulled in manually. Otherwise, they get hidden by
// the mutable getters with the same names.
- using CompilerInvocationBase::getLangOpts;
- using CompilerI
@@ -11,6 +11,7 @@
#include "clang/APINotes/APINotesOptions.h"
#include "clang/Basic/CodeGenOptions.h"
+#include "clang/Basic/DebugOptions.h"
jansvoboda11 wrote:
Wouldn't a forward declaration be enough in this case?
https://github.com/llvm/llvm-project/pull/
@@ -11,46 +11,13 @@
namespace clang {
-CodeGenOptions::CodeGenOptions() {
-#define CODEGENOPT(Name, Bits, Default) Name = Default;
-#define ENUM_CODEGENOPT(Name, Type, Bits, Default) set##Name(Default);
-#include "clang/Basic/CodeGenOptions.def"
+CodeGenOptions::CodeGenOption
https://github.com/jansvoboda11 requested changes to this pull request.
This looks pretty nice, I left just a couple of notes. You might want to take a
look at the CI failures.
https://github.com/llvm/llvm-project/pull/75530
___
lldb-commits mailing l
https://github.com/jansvoboda11 edited
https://github.com/llvm/llvm-project/pull/75530
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Author: Jan Svoboda
Date: 2023-09-29T10:01:37-07:00
New Revision: 2fc90afdac451b49d67c72bd41a99886811dd36c
URL:
https://github.com/llvm/llvm-project/commit/2fc90afdac451b49d67c72bd41a99886811dd36c
DIFF:
https://github.com/llvm/llvm-project/commit/2fc90afdac451b49d67c72bd41a99886811dd36c.diff
L
Author: Jan Svoboda
Date: 2023-08-04T13:57:13-07:00
New Revision: 3f092f37b7362447cbb13f5502dae4bdd5762afd
URL:
https://github.com/llvm/llvm-project/commit/3f092f37b7362447cbb13f5502dae4bdd5762afd
DIFF:
https://github.com/llvm/llvm-project/commit/3f092f37b7362447cbb13f5502dae4bdd5762afd.diff
L
Author: Jan Svoboda
Date: 2023-06-15T11:59:47+02:00
New Revision: 74113a4150d683c9478331ae91018ab9092a634d
URL:
https://github.com/llvm/llvm-project/commit/74113a4150d683c9478331ae91018ab9092a634d
DIFF:
https://github.com/llvm/llvm-project/commit/74113a4150d683c9478331ae91018ab9092a634d.diff
L
Author: Jan Svoboda
Date: 2023-05-30T14:08:04-07:00
New Revision: e348dbc4b2766f17c251b6c305a3b34fbdb9be96
URL:
https://github.com/llvm/llvm-project/commit/e348dbc4b2766f17c251b6c305a3b34fbdb9be96
DIFF:
https://github.com/llvm/llvm-project/commit/e348dbc4b2766f17c251b6c305a3b34fbdb9be96.diff
L
Author: Jan Svoboda
Date: 2021-12-09T11:32:13+01:00
New Revision: e04fc2d88efa60ed5527b90c15d8fc188739e989
URL:
https://github.com/llvm/llvm-project/commit/e04fc2d88efa60ed5527b90c15d8fc188739e989
DIFF:
https://github.com/llvm/llvm-project/commit/e04fc2d88efa60ed5527b90c15d8fc188739e989.diff
L
16 matches
Mail list logo