Jlalond wrote:
@dmpots adding you after our conversation yesterday as an FYI
https://github.com/llvm/llvm-project/pull/136040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -157,6 +162,23 @@ class CompletionRequest {
size_t GetCursorIndex() const { return m_cursor_index; }
+ size_t GetMaxReturnElements() const { return m_max_return_elements; }
+
+ /// Returns true if the maximum number of completions has not been reached
+ /// yet, hence
@@ -230,6 +232,9 @@ class SymbolCompleter : public Completer {
// Now add the functions & symbols to the list - only add if unique:
for (const SymbolContext &sc : sc_list) {
+if (m_match_set.size() >= m_request.GetMaxNumberOfResultsToAdd())
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/136040
Recently I was debugging a Minidump with a few thousand ranges, and came across
the (now deleted) comment:
```
// I don't have a sense of how frequently this is called or how many memory
// ranges a Minidum
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/136040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond commented:
Just a nit or to. LGTM, but I'll defer to Greg.
https://github.com/llvm/llvm-project/pull/134563
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commit
@@ -1217,28 +1217,36 @@
PluginManager::GetSymbolLocatorCreateCallbackAtIndex(uint32_t idx) {
}
ModuleSpec
-PluginManager::LocateExecutableObjectFile(const ModuleSpec &module_spec) {
+PluginManager::LocateExecutableObjectFile(const ModuleSpec &module_spec,
+
@@ -1217,28 +1217,36 @@
PluginManager::GetSymbolLocatorCreateCallbackAtIndex(uint32_t idx) {
}
ModuleSpec
-PluginManager::LocateExecutableObjectFile(const ModuleSpec &module_spec) {
+PluginManager::LocateExecutableObjectFile(const ModuleSpec &module_spec,
+
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/134563
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/134961
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
> LGTM, though the comment in `AddData` seemed useful, even though it had a
> couple of typos. Why remove it?
I recently landed changes that did add chunking of the data so the comment was
no longer accurate. Now we'll only ever get chunks up to the `MAX_CHUNK_SIZE`
https://git
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/129307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
Did some additional validation offline, where I save a jumbo Minidump (50gb).
We have improved disk IO and a flat memory profile.
https://github.com/llvm/llvm-project/pull/129307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
@@ -969,6 +969,64 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+lldb_private::DataBufferHeap &data_buffer,
+const lldb_private::CoreFileMemoryRange &range, uint64_t &bytes_read) {
+
+
@@ -0,0 +1,33 @@
+//===-- DAPError.h
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/Jlalond approved this pull request.
https://github.com/llvm/llvm-project/pull/132255
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond approved this pull request.
Much improved! I should've noticed this in my first patch but great fix for the
flakiness
https://github.com/llvm/llvm-project/pull/134157
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/134163
The motivation for this patch is that in Statistics.cpp we [check to see if the
module symfile is
loaded](https://github.com/llvm/llvm-project/blob/990a086d9da0bc2fd53a6a4c95ecbbe23a297a83/lldb/source/Target/St
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/134341
Reverts llvm/llvm-project#134163
Reverting while @clayborg and I come up with a better API
>From e789e78d20c0dfe70d4e977b259460f1c8008515 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 3 Apr 2025 20:4
Jlalond wrote:
> > @JDevlieghere @bulbazord Is there a Discourse on the recent changes to the
> > terminal colors? On Linux I'm getting this white bar that crosses the whole
> > terminal. I think this is part of your reverse video change Jonas?
> >  package has a
> progress bar that allows you to write:
>
> ```
> for i in track(range(20), description="Processing..."):
>
Jlalond wrote:
> > Neat! While I don't love the reverse video, is there an easier way to
> > update the status line color other than setting the entire format like so?
> > ```
> > settings set statusline-format "${ansi.bg.blue}{${target.file.basename}}{ |
> > ${line.file.basename}:${line.number
Jlalond wrote:
@JDevlieghere @bulbazord Is there a Discourse on the recent changes to the
terminal colors? On Linux I'm getting this white bar that crosses the whole
terminal. I think this is part of your reverse video change Jonas?
+
+Additionally f
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/133527
>From ec90252f34b358e1eba65f4b430d267833fa9ec8 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 28 Mar 2025 15:01:31 -0700
Subject: [PATCH 1/4] Implement methods for 'with' in python
---
.../bindings/in
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/133527
We recently added an explicit finalize to SBProgress, #128966. I realized while
adding some additional implementations of SBProgress that we should to add
`with` support for ease of use. This patch addresses ad
Jlalond wrote:
> I am fine with this being always enabled. I will defer to Jonas to make sure
> he is
So @JDevlieghere and I agreed on adding this to the default listener which is
currently the case. But because we only tested DAP after we added the new
broadcast bit, this fell through the cr
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/133309
>From d55d7e328300134c723cbc7d0f67ac8c1309ebbb Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Thu, 27 Mar 2025 13:15:46 -0700
Subject: [PATCH] Configure sbprogress events to be emitted for the CLI
---
lldb
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/133309
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/133309
In the original SBProgress patch, #123837, I didn't ensure the debugger was
broadcasting these events to the CLI. This patch addresses that.
https://github.com/user-attachments/assets/5eb93a46-1db6-4d46-a6b7-2b
@@ -0,0 +1,33 @@
+//===-- DAPError.h
===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -142,6 +142,13 @@ class MinidumpFileBuilder {
lldb_private::Status AddDirectory(llvm::minidump::StreamType type,
uint64_t stream_size);
lldb::offset_t GetCurrentDataEndOffset() const;
+
+ // Read a memory region from the process and w
https://github.com/Jlalond approved this pull request.
Left one comment on the unused template. Otherwise LGTM, I'd wait for Jeffrey
to give you a final sign off
https://github.com/llvm/llvm-project/pull/130841
___
lldb-commits mailing list
lldb-commi
@@ -392,9 +391,57 @@ struct DAP {
void SetThreadFormat(llvm::StringRef format);
- InstructionBreakpoint *GetInstructionBreakpoint(const lldb::break_id_t
bp_id);
+ template
+ BreakpointType *GetBreakpointFromStopReason(lldb::SBThread &thread) {
+// Check to see if h
@@ -392,9 +391,59 @@ struct DAP {
void SetThreadFormat(llvm::StringRef format);
- InstructionBreakpoint *GetInstructionBreakpoint(const lldb::break_id_t
bp_id);
+ template
+ BreakpointType *GetBreakpointFromStopReason(lldb::SBThread &thread) {
+// Check to see if h
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+const std::unique_ptr &data_up,
+const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) {
+ if (!data_up)
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+const std::unique_ptr &data_up,
+const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) {
+ if (!data_up)
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/129605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -171,3 +171,35 @@ def test_functionality(self):
self.continue_to_next_stop()
x_val = self.dap_server.get_local_variable_value("x")
self.assertEqual(x_val, "10")
+
+@skipIfWindows
+def test_breakpoint_reason(self):
+"""Tests setting dat
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/129307
>From 1cfd90c01dbd4358577c0bd62a88a1191848693a Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 28 Feb 2025 11:38:35 -0800
Subject: [PATCH 1/7] Update MinidumpFileBuilder to read and write in chunks
---
@@ -969,12 +969,89 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
-static uint64_t
-GetLargestRangeSize(const std::vector &ranges) {
- uint64_t max_size = 0;
- for (const auto &core_range : ranges)
-max_size = std::max(max_size, core_range.ran
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+const std::unique_ptr &data_up,
+const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) {
+ if (!data_up)
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+const std::unique_ptr &data_up,
+const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) {
+ if (!data_up)
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/129307
>From 2f77beefb752ffdae908101d75381268203311d6 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 28 Feb 2025 11:38:35 -0800
Subject: [PATCH 1/6] Update MinidumpFileBuilder to read and write in chunks
---
@@ -392,9 +391,59 @@ struct DAP {
void SetThreadFormat(llvm::StringRef format);
- InstructionBreakpoint *GetInstructionBreakpoint(const lldb::break_id_t
bp_id);
+ template
+ BreakpointType *GetBreakpointFromStopReason(lldb::SBThread &thread) {
+// Check to see if h
@@ -962,28 +962,43 @@ llvm::json::Value CreateThreadStopped(DAP &dap,
lldb::SBThread &thread,
body.try_emplace("reason", "step");
break;
case lldb::eStopReasonBreakpoint: {
-ExceptionBreakpoint *exc_bp = dap.GetExceptionBPFromStopReason(thread);
+ExceptionBre
@@ -392,9 +391,59 @@ struct DAP {
void SetThreadFormat(llvm::StringRef format);
- InstructionBreakpoint *GetInstructionBreakpoint(const lldb::break_id_t
bp_id);
+ template
+ BreakpointType *GetBreakpointFromStopReason(lldb::SBThread &thread) {
+// Check to see if h
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+const std::unique_ptr &data_up,
+const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) {
+ if (!data_up)
@@ -969,6 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
+Status MinidumpFileBuilder::ReadWriteMemoryInChunks(
+const std::unique_ptr &data_up,
+const lldb_private::CoreFileMemoryRange &range, uint64_t *bytes_read) {
+ if (!data_up)
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/129605
>From 6c8f3ee0b033917213c802ddd978c63f8947616b Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 3 Mar 2025 15:12:29 -0800
Subject: [PATCH 1/2] Drop markdown backticks for codeblock
---
lldb/bindings/int
https://github.com/Jlalond approved this pull request.
https://github.com/llvm/llvm-project/pull/130202
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/129605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/129605
>From 6c8f3ee0b033917213c802ddd978c63f8947616b Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 3 Mar 2025 15:12:29 -0800
Subject: [PATCH 1/2] Drop markdown backticks for codeblock
---
lldb/bindings/int
Jlalond wrote:
Attached are some images of docstrings I'm cleaning up (I also made the mess
:P).
SBSaveCore formatting breaks on the newline
SBProgress has quote blocks instead of just a code block
![imag
Jlalond wrote:
@clayborg These are those docstring cleanups I pinged you about
https://github.com/llvm/llvm-project/pull/129605
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@JDevlieghere I should've closed this, but I'm actually going to fix a couple
spots around the codebase. It looks like Swig will give a codeblock on `::`,
looking at `SBTarget.docstrings.i`. So I'm going to reuse this patch to fix
atleast SBProcess, SBProgress, and I think Memor
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/124648
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -969,12 +969,83 @@ Status MinidumpFileBuilder::DumpDirectories() const {
return error;
}
-static uint64_t
-GetLargestRangeSize(const std::vector &ranges) {
- uint64_t max_size = 0;
- for (const auto &core_range : ranges)
-max_size = std::max(max_size, core_range.ran
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/129307
>From 2f77beefb752ffdae908101d75381268203311d6 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 28 Feb 2025 11:38:35 -0800
Subject: [PATCH 1/4] Update MinidumpFileBuilder to read and write in chunks
---
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/129307
I recently received an internal error report that LLDB was OOM'ing when
creating a Minidump. In my 64b refactor we made a decision to acquire buffers
the size of the largest memory region so we could read all o
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/129307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/129307
>From 2f77beefb752ffdae908101d75381268203311d6 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Fri, 28 Feb 2025 11:38:35 -0800
Subject: [PATCH 1/2] Update MinidumpFileBuilder to read and write in chunks
---
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/129307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
Jlalond wrote:
@labath / @clayborg to preempt some expected feedback, I intend to expose this
chunk size in a future setting
https://github.com/llvm/llvm-project/pull/129307
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/4] Add a finalize method to the sbprogress, with an
associated
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/3] Add a finalize method to the sbprogress, with an
associated
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/3] Add a finalize method to the sbprogress, with an
associated
@@ -12,3 +12,10 @@ and will always send an initial progress update, updates when
Progress::Increment() is called, and also will make sure that a progress
completed update is reported even if the user doesn't explicitly cause one
to be sent.") lldb::SBProgress;
https://github.com/Jlalond closed
https://github.com/llvm/llvm-project/pull/128971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 7597ee080abcaaa8b88af316409feb849fb6d7f2 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/2] Add a finalize method to the sbprogress, with an
associated
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128971
>From ac90ec73ccfb02923ff0343189d2efaeb6108fa3 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:48:14 -0800
Subject: [PATCH 1/4] Fix bad optional access in sbprogress
---
lldb/source/API/
@@ -12,3 +12,10 @@ and will always send an initial progress update, updates when
Progress::Increment() is called, and also will make sure that a progress
completed update is reported even if the user doesn't explicitly cause one
to be sent.") lldb::SBProgress;
@@ -33,3 +33,17 @@ def test_without_external_bit_set(self):
expected_string = "Test progress first increment"
progress.Increment(1, expected_string)
self.assertFalse(listener.PeekAtNextEvent(event))
+
+def test_progress_finalize(self):
+"""Te
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 3c4b333869c17005deb8d4e9307babc94d0dc9b5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/3] Add a finalize method to the sbprogress, with an
associated
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128971
>From ac90ec73ccfb02923ff0343189d2efaeb6108fa3 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:48:14 -0800
Subject: [PATCH 1/3] Fix bad optional access in sbprogress
---
lldb/source/API/
@@ -33,3 +33,15 @@ def test_without_external_bit_set(self):
expected_string = "Test progress first increment"
progress.Increment(1, expected_string)
self.assertFalse(listener.PeekAtNextEvent(event))
+
+def test_with_external_bit_set(self):
+"
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128971
>From ac90ec73ccfb02923ff0343189d2efaeb6108fa3 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:48:14 -0800
Subject: [PATCH 1/2] Fix bad optional access in sbprogress
---
lldb/source/API/
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/128971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -40,7 +40,10 @@ SBProgress::~SBProgress() = default;
void SBProgress::Increment(uint64_t amount, const char *description) {
LLDB_INSTRUMENT_VA(amount, description);
- m_opaque_up->Increment(amount, description);
+ std::optional description_opt;
+ if (description && des
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 3c4b333869c17005deb8d4e9307babc94d0dc9b5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/2] Add a finalize method to the sbprogress, with an
associated
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/128966
>From 3c4b333869c17005deb8d4e9307babc94d0dc9b5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Wed, 26 Feb 2025 15:38:24 -0800
Subject: [PATCH 1/2] Add a finalize method to the sbprogress, with an
associated
https://github.com/Jlalond edited
https://github.com/llvm/llvm-project/pull/128966
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/Jlalond created
https://github.com/llvm/llvm-project/pull/128971
This fixes the obvious, but untested case of sending None/Null to SBProgress.
This was an oversight on my part.
>From ac90ec73ccfb02923ff0343189d2efaeb6108fa3 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date:
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 0587ba8239dbbd22aa40bde23d61f9504975817d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/9] Only include title on the first message
---
lldb/include/l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 0587ba8239dbbd22aa40bde23d61f9504975817d Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/9] Only include title on the first message
---
lldb/include/l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/8] Only include title on the first message
---
lldb/include/l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/9] Only include title on the first message
---
lldb/include/l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/7] Only include title on the first message
---
lldb/include/l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/7] Only include title on the first message
---
lldb/include/l
@@ -428,14 +453,35 @@ void ProgressEventThreadFunction(DAP &dap) {
done = true;
}
} else {
-uint64_t progress_id = 0;
-uint64_t completed = 0;
-uint64_t total = 0;
-bool is_debugger_specific = false;
-const char *m
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/6] Only include title on the first message
---
lldb/include/l
Jlalond wrote:
@clayborg
DAP with a detail and a total
Indeterminate with an increment detail
Then with an indete
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/6] Only include title on the first message
---
lldb/include/l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/5] Only include title on the first message
---
lldb/include/l
https://github.com/Jlalond updated
https://github.com/llvm/llvm-project/pull/124648
>From 12ff645735c1dbf51e58b9f80d4e3e13a0babdf5 Mon Sep 17 00:00:00 2001
From: Jacob Lalonde
Date: Mon, 27 Jan 2025 13:41:58 -0800
Subject: [PATCH 1/4] Only include title on the first message
---
lldb/include/l
1 - 100 of 637 matches
Mail list logo
