[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

jfb accepted this revision. jfb added a subscriber: jordan_rose. jfb added a comment. This revision is now accepted and ready to land. More of an FYI, @jordan_rose might be interested in this. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D69148/new/ https://reviews.llvm.org/D69148 __

[Lldb-commits] [PATCH] D69148: Disable exit-on-SIGPIPE in lldb

jfb added inline comments. Comment at: lldb/tools/driver/Driver.cpp:864 + // in LLDB leaves behind temporary objects). + llvm::sys::SetExitOnFailedPipeWrite(/*ExitOnFailedWrite=*/false); + Could this instead pass a lambda, like other signal handlers? So sigpipe

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

jfb added inline comments. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)->GetID() == thread_id)) { + m_threads.erase(it); jingham wrote: >

[Lldb-commits] [PATCH] D65555: [lldb] [Process/NetBSD] Enable reporting of new and exited threads [WIP]

jfb requested changes to this revision. jfb added inline comments. This revision now requires changes to proceed. Comment at: lldb/source/Plugins/Process/NetBSD/NativeProcessNetBSD.cpp:737 + for (auto it = m_threads.begin(); it != m_threads.end(); ++it) { +if (*it && ((*it)-

[Lldb-commits] [PATCH] D65493: Modernize atomic detection and usage

jfb updated this revision to Diff 212479. jfb added a comment. - Remove from cmake Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65493/new/ https://reviews.llvm.org/D65493 Files: clang-tools-extra/clangd/CMakeLists.txt lldb/source/Utility/CMak

[Lldb-commits] [PATCH] D65493: Modernize atomic detection and usage

jfb created this revision. jfb added reviewers: rnk, Bigcheese, __simt__. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, kadircet, arphaman, dexonsmith, jkorous, hiraditya, mgorny. Herald added projects: clang, LLDB, LLVM. Some of the cmake checks are obsolete and make bootstr

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb closed this revision. jfb added a comment. https://reviews.llvm.org/rL367282 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249 ___ lldb-commits mailing list l

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb added a comment. In D65249#1605523 , @rnk wrote: > I have concerns that some of the patches that you landed prior to this will > cause issues with old versions of MSVC, but in isolation, this is fine, and > if anyone complains, we can address it on a

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb added a comment. In D65249#1603431 , @BillyONeal wrote: > (In fact I observe many patterns in this review like: > > enum { Foo = alignof(void*); } > aligned_storage_t<1234, Foo> x; > > and then a bunch of casting to treat it as a char buffer; if it wa

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h, remove AlignedCharArray

jfb updated this revision to Diff 212252. jfb added a comment. Significantly simplify the patch. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249 Files: llvm/include/llvm/Support/AlignOf.h llvm/unittests

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a comment. In D65249#1603278 , @BillyONeal wrote: > > @BillyONeal do you know if 19.11 has the aligned_storage issue on x86? > > aligned_storage is still capped at what the library can fake with unions. It > would be an ABI break to change it to

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a subscriber: BillyONeal. jfb added a comment. In D65249#1603133 , @rnk wrote: > I still think this concern applies: > https://reviews.llvm.org/D64417#1576675 > > I'm not sure how to track down an 19.11 release to test if we can pass > std::ali

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb created this revision. jfb added a reviewer: chandlerc. Herald added subscribers: llvm-commits, lldb-commits, cfe-commits, dexonsmith, jkorous, hiraditya, javed.absar. Herald added projects: clang, LLDB, LLVM. jfb added a comment. This is the main event: https://reviews.llvm.org/D65249#change

[Lldb-commits] [PATCH] D65249: [NFC] use C++11 in AlignOf.h

jfb added a comment. This is the main event: https://reviews.llvm.org/D65249#change-IWk6CtRl45h6 The rest is side-show. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D65249/new/ https://reviews.llvm.org/D65249

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

jfb added a comment. In D63363#1546837 , @labath wrote: > In D63363#1546504 , @jfb wrote: > > > In D63363#1546490 , @xiaobai wrote: > > > > > In D63363#1546464

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

jfb added a comment. In D63363#1546490 , @xiaobai wrote: > In D63363#1546464 , @jfb wrote: > > > Can you describe what the goal of your plugin architecture is? Maybe you > > need an RFC by email before moving stuff

[Lldb-commits] [PATCH] D63363: [Signals] Create a plugin directory just for signals

jfb added a comment. Can you describe what the goal of your plugin architecture is? Maybe you need an RFC by email before moving stuff around. I want to understand what you're going for because as they are today the signals mostly work, and aren't really tested (because injecting these conditi

[Lldb-commits] [PATCH] D57990: Use std::make_shared in LLDB (NFC)

jfb added a comment. Do you ever use weak pointers? The single allocation is good until you start holding on to more things (because you can't just keep the block around, you need the entire allocation), so you should make sure you won’t be delaying memory being reclaimed. Repository: rLLDB