YungRaj wrote:
> > > I was hoping to fix everything in one Pull Request so that it at least
> > > becomes usable once this merges.
> >
> >
> > The LLVM project generally
> > [prefers](https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity)
> > smaller patches as they're eas
https://github.com/YungRaj edited
https://github.com/llvm/llvm-project/pull/101062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
YungRaj wrote:
> > I was hoping to fix everything in one Pull Request so that it at least
> > becomes usable once this merges.
>
> The LLVM project generally
> [prefers](https://llvm.org/docs/CodeReview.html#code-reviews-speed-and-reciprocity)
> smaller patches as they're easier to review. We
YungRaj wrote:
I got it working.
But symbolicating backtraces is still broken. Setting breakpoints by address,
reading memory, disassembling memory, etc is now working.
https://github.com/llvm/llvm-project/blob/40b4fd7a3e81d32b29364a1b15337bcf817659c0/lldb/source/Core/Section.cpp#L229
In `Se
YungRaj wrote:
> This patch fixes the deserialization of the "address" field which surely can
> be tested in isolation. The existing test (`TestObjectFileJSON.py`) has
> `address` set to zero, which is why this happens to work today. It should be
> possible to either update the test or add a n
YungRaj wrote:
> The change itself looks good modulo formatting. Can you please update one of
> the existing tests to cover this use case?
This doesn't get symbolication fully working. We still need to prevent the
object file from being read when inspecting the symbolicated addresses through
https://github.com/YungRaj edited
https://github.com/llvm/llvm-project/pull/101062
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/YungRaj created
https://github.com/llvm/llvm-project/pull/101062
This is a dummy pull request to demonstrate the changes I made in to get
symbolication working using JSON Object/Symbol files
https://discourse.llvm.org/t/lldb-support-renaming-symbols-by-address-using-a-symbol
