[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

HenriqueBucher added a comment. I mean my **local** changes, can I consider this done and clean up? Sorry for the very newbie question. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 ___

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

HenriqueBucher added a comment. Is there anything to be done at this point? Can I reset my branch? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 ___ lldb-comm

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

HenriqueBucher added a comment. Got a very nice email from Chris Lattner with the approval. Very nice. Dude I took the plunge and did it. I hope it went through right. Please let me know if I screwed it up. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

This revision was automatically updated to reflect the committed changes. Closed by commit rG5a52c5c42669: Summary: This documentation patch adds information to allow remote users to… (authored by HenriqueBucher). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.

[Lldb-commits] [PATCH] D135577: Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solve

HenriqueBucher updated this revision to Diff 467313. HenriqueBucher retitled this revision from "Summary:" to "Summary: This documentation patch adds information to allow remote users to also use the plugin as it will be invisible to them using the current instructions. It solves issue #58252.".

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher updated this revision to Diff 467310. HenriqueBucher added a comment. Visual Studio code has different folders for plugins when used by local users and users remoting into the box. The current instructions show how to install the lldb-vscode plugin only for the local users and it

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher added a comment. I assume not since I have never committed on any LLVM project. But I would like to as I plan to contribute more in the future. Just sent Chris Clattner an email with the request. Note: The reason the summary is so terse is that the ARC tool opens two windows and

[Lldb-commits] [PATCH] D135607: Summary:

HenriqueBucher added a comment. To be frank, I think this formatting is silly and wrong now that I am looking at it. Looking at the rendered markdown at Github you can see that the browser itself word wraps for y

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher added a comment. Ok submitted another patch. Added you as reviewer. Check if it is okay. https://reviews.llvm.org/D135607 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 __

[Lldb-commits] [PATCH] D135607: Summary:

HenriqueBucher created this revision. HenriqueBucher added reviewers: JDevlieghere, clayborg. Herald added a project: All. HenriqueBucher requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Reformatted doc text so it is more or less around 80 c

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher added inline comments. Comment at: lldb/tools/lldb-vscode/README.md:39 +It is important to note that the directory `~/.vscode/extensions` works for users logged in locally to the machine. If you are remoting into the box using Visual Studio Code's Remote plugin

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher updated this revision to Diff 466538. HenriqueBucher added a comment. Removed 2 extra blank lines Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 Files: lldb/tools/lldb-vscode/README.md

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher updated this revision to Diff 466537. HenriqueBucher added a comment. Formatted text to wrap in 80 columns Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135577/new/ https://reviews.llvm.org/D135577 Files: lldb/tools/lldb-vscode/RE

[Lldb-commits] [PATCH] D135577: Summary:

HenriqueBucher created this revision. HenriqueBucher added a reviewer: clayborg. Herald added a project: All. HenriqueBucher requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This documentation patch adds information to allow remote users to