abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.
Looks ok but I would like a testcase to go with the change.
Repository:
rLLDB LLDB
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D59015/new/
https://reviews.llvm.org/D59015
___
abidh accepted this revision.
abidh added a comment.
This revision is now accepted and ready to land.
The lldb-mi bits look ok to me.
Comment at: tools/lldb-mi/MIUtilString.h:36
va_list vArgs);
+
static bool IsAllValidAlphaAndNumeric(cons
abidh added inline comments.
Comment at: source/Symbol/ObjectFile.cpp:695
+ "One or more breakpoints intersect section '%s'",
+ section_sp->GetName().AsCString());
return error;
If WriteMemory is not setting the error in some ca
abidh added a comment.
This check used to be there above the loop and was removed when you reported
that changes in pointers are not being tracked in
http://lists.llvm.org/pipermail/lldb-dev/2017-May/012428.html
I think putting it on individual child is probably good enough compromise.
https:
abidh updated this revision to Diff 85280.
abidh added a comment.
Use GetLogIfAnyCategoryIsSet as advised in comments.
https://reviews.llvm.org/D28808
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
abidh updated this revision to Diff 85278.
abidh added a comment.
Added a check for case when entry address is not valid.
https://reviews.llvm.org/D28944
Files:
include/lldb/Core/Module.h
include/lldb/Symbol/ObjectFile.h
source/Commands/CommandObjectTarget.cpp
source/Core/Module.cpp
s
abidh marked an inline comment as done.
abidh added a comment.
Greg, any further comment on this patch.
https://reviews.llvm.org/D28808
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
abidh created this revision.
This commit adds an option to set PC to the entry point of the file loaded
using "target module load" command. In https://reviews.llvm.org/D28804, Greg
asked me to separate this part under a different option.
https://reviews.llvm.org/D28944
Files:
include/lldb/C
abidh closed this revision.
abidh added a comment.
Committed in 292499. Removed this bit "set PC to its entry address." before
committing as it is not being done now.
https://reviews.llvm.org/D28804
___
lldb-commits mailing list
lldb-commits@lists.
abidh updated this revision to Diff 84979.
abidh added a comment.
Changed the name of the option. Added LoadInMemory function to Module and
ObjectFile class and moved the functionality of writing to memory there.
Removed part which set the pc.
https://reviews.llvm.org/D28804
Files:
include/
abidh marked 2 inline comments as done.
abidh added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:4006-4007
+if (log)
+ log->Warning("Packet size is too small."
+ "LLDB may face problems while writing me
abidh updated this revision to Diff 84857.
abidh added a comment.
Updated log calls as advised.
https://reviews.llvm.org/D28808
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
===
abidh added inline comments.
Comment at: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3999
+ // time, we take a maximum guess here.
+ stub_max_size -= 32 + 32 + 6;
m_max_memory_size = stub_max_size;
clayborg wrote:
> You need to check "
abidh updated this revision to Diff 84817.
abidh added a comment.
Added the check to avoid integer underflow.
https://reviews.llvm.org/D28808
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
Index: source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
=
abidh created this revision.
LLDB was using packet size advertised by the target as the max memory size to
write in one go. It is wrong because packets have other overhead apart from
memory payload. Also memory transferred through 'm' and 'M' packets needs 2
bytes in packet to transfer 1 of mem
abidh created this revision.
For bare-metal targets, lldb was missing a command like 'load' in gdb which can
be used to create executable image on the target. This was discussed in
http://lists.llvm.org/pipermail/lldb-dev/2016-December/011752.html
This diff adds an option to "target module load
This revision was automatically updated to reflect the committed changes.
Closed by commit rL291104: [lldb-mi] Fix implementation for a few mi commands
(authored by abidh).
Changed prior to commit:
https://reviews.llvm.org/D24711?vs=82654&id=83225#toc
Repository:
rL LLVM
https://reviews.llv
abidh added a comment.
> What do I do next? Could you help me commit and push this? since I don't have
> write access.
I will commit it for you.
https://reviews.llvm.org/D24711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists
abidh accepted this revision.
abidh added a comment.
Looks good.
Comment at: packages/Python/lldbsuite/test/tools/lldb-mi/main.cpp:22
{
-int a = 10;
+int a = 10;
+
This declaration looks redundant.
Comment at: tools/lldb-mi/MICmdCmd
abidh accepted this revision.
abidh added a reviewer: abidh.
abidh marked an inline comment as done.
abidh added a comment.
This revision is now accepted and ready to land.
Accepted in email.
https://reviews.llvm.org/D27759
___
lldb-commits mailing
abidh updated this revision to Diff 81576.
abidh added a comment.
Replaced /D with -D as per comments.
https://reviews.llvm.org/D27759
Files:
cmake/LLDBDependencies.cmake
cmake/modules/AddLLDB.cmake
cmake/modules/LLDBConfig.cmake
include/lldb/Host/windows/windows.h
source/API/SystemIn
abidh added a comment.
In https://reviews.llvm.org/D27759#622332, @labath wrote:
> Yeah, I meant using it everywhere as a generic "am I on windows, regardless
> of the compiler" check. (Assuming Zach is fine with that)
OK. If Zachary is fine with that then I can do that in a separate commit.
abidh added a comment.
> BTW, I am curious, are you planning on building python with mingw as well? If
> you are, I'd be interested in knowing how that works out.
I would like to do it but have not done it yet. I will keep you posted.
Comment at: cmake/modules/LLDBConfig.cmak
abidh created this revision.
abidh added reviewers: labath, zturner.
abidh added a subscriber: lldb-commits.
Herald added subscribers: mgorny, ki.stfu.
I was building lldb using cross mingw-w64 toolchain on Linux and observed some
issues. This is first patch in the series to fix that build. It mo
abidh accepted this revision.
abidh added a reviewer: abidh.
abidh added a comment.
This revision is now accepted and ready to land.
Accepted on email.
https://reviews.llvm.org/D27707
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://
abidh created this revision.
abidh added a reviewer: zturner.
abidh added a subscriber: lldb-commits.
This code was probably needed to support VS2013 and is not needed now. I have
built it with VS and mingw. Ok to remove it?
https://reviews.llvm.org/D27707
Files:
include/lldb/Host/windows/Po
26 matches
Mail list logo
