h-vetinari added inline comments.
Comment at: libunwind/src/CMakeLists.txt:28-35
# See add_asm_sources() in compiler-rt for explanation of this workaround.
# CMake doesn't work correctly with assembly on AIX. Workaround by compiling
# as C files as well.
if((APPLE AND CMAKE
h-vetinari added inline comments.
Comment at: libunwind/src/CMakeLists.txt:28-35
# See add_asm_sources() in compiler-rt for explanation of this workaround.
# CMake doesn't work correctly with assembly on AIX. Workaround by compiling
# as C files as well.
if((APPLE AND CMAKE
h-vetinari added a comment.
My point boils down to: "written using standard C++17
code" does not sound at all like "core language, no stdlib", but very much like
"core+stdlib".
This is also the first time this split becomes relevant AFAIK, because for
moving to C++14, the stdlib was ready basic
h-vetinari added a comment.
From the text you quoted:
> LLVM subprojects are written using standard C++17
code and avoid unnecessary vendor-specific extensions.
I don't think the standard library can be called a vendor-specific extension,
and so I think this still could/should be made clearer
h-vetinari added a comment.
It may be worth calling out that this is about C++17 core language and not the
standard library?
libstdcxx only finished C++17 support in GCC 12, and libcxx is still missing
various pieces even today (much less for Clang 5).
Repository:
rG LLVM Github Monorepo
C
