https://github.com/clayborg updated
https://github.com/llvm/llvm-project/pull/152618
>From b1a41aa0b3f65b5c72190a19091de88965d4fd6a Mon Sep 17 00:00:00 2001
From: Greg Clayton
Date: Thu, 7 Aug 2025 17:15:29 -0700
Subject: [PATCH] [NFC][lldb] Cleanup the ArchDefinitionEntry definitons.
This pat
clayborg wrote:
> I think this makes sense.
>
> Out of curiosity, what does clang-format do to the formatting?
It will complain or try to reformat. This allows lines to exceed the column
limit and also won't reformat any spacing.
https://github.com/llvm/llvm-project/pull/152618
__
@@ -488,22 +488,26 @@ class SymbolFile : public PluginInterface {
return false;
};
- /// Get number of loaded/parsed DWO files. This is emitted in "statistics
- /// dump"
+ /// Retrieves statistics about DWO files associated with this symbol file.
+ /// This function
@@ -612,21 +616,20 @@ class SymbolFileCommon : public SymbolFile {
const CompilerType &compiler_qual_type,
Type::ResolveState compiler_type_resolve_state,
uint32_t opaque_payload = 0) override {
- lldb:
@@ -1716,7 +1716,7 @@ SymbolFileDWARF
*SymbolFileDWARF::GetDIERefSymbolFile(const DIERef &die_ref) {
return this;
if (file_index) {
- // We have a SymbolFileDWARFDebugMap, so let it find the right file
+// We have a SymbolFileDWARFDebugMap, so let it find the r
@@ -612,21 +616,20 @@ class SymbolFileCommon : public SymbolFile {
const CompilerType &compiler_qual_type,
Type::ResolveState compiler_type_resolve_state,
uint32_t opaque_payload = 0) override {
- lldb:
@@ -1725,7 +1725,8 @@ SymbolFileDWARF
*SymbolFileDWARF::GetDIERefSymbolFile(const DIERef &die_ref) {
return GetDwpSymbolFile().get(); // DWP case
// Handle the .dwo file case correctly
-return DebugInfo().GetUnitAtIndex(*die_ref.file_index())
+return DebugIn
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/155023
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -597,7 +601,7 @@ class SymbolFileCommon : public SymbolFile {
return m_debug_info_had_variable_errors;
}
void SetDebugInfoHadFrameVariableErrors() override {
- m_debug_info_had_variable_errors = true;
+m_debug_info_had_variable_errors = true;
@@ -90,7 +90,7 @@
#include
#include
-//#define ENABLE_DEBUG_PRINTF // COMMENT OUT THIS LINE PRIOR TO CHECKIN
+// #define ENABLE_DEBUG_PRINTF // COMMENT OUT THIS LINE PRIOR TO CHECKIN
clayborg wrote:
Ditto (revert auto clang-format changes for stuff that isn
https://github.com/clayborg requested changes to this pull request.
One more round of changes just removing any auto clang-format changes that are
not part of this PR. When committing PRs to upstream, we want to make sure any
noise that isn't related to the PR is not part of the PR itself like
https://github.com/clayborg requested changes to this pull request.
One quick change suggested to re-use the new DWOStats struct instead of
creating 3 local variables.
https://github.com/llvm/llvm-project/pull/155023
___
lldb-commits mailing list
lld
@@ -155,6 +155,7 @@ struct ModuleStats {
bool debug_info_had_incomplete_types = false;
uint32_t dwo_file_count = 0;
uint32_t loaded_dwo_file_count = 0;
+ uint32_t dwo_error_count = 0;
clayborg wrote:
We can change these three lines to:
```
DWOStats dwo_
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/155023
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/154809
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
FYI: This could be upstreamed now
https://github.com/llvm/llvm-project/pull/152170
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-co
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/150149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/150268
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
I added Pavel Labath and David Blaikie in case they have any info on this.
The story if we have some RiscV code that is creating location values for
variables that use DW_OP_piece and they are using:
```
DW_OP_lit0, DW_OP_stack_value, DW_OP_piece 0x28
```
to try and zero fill i
@@ -1978,7 +1978,12 @@ llvm::Expected DWARFExpression::Evaluate(
// grows to the nearest host integer type.
llvm::APInt fail_value(1, 0, false);
llvm::APInt ap_int = scalar.UInt128(fail_value);
-assert(ap_int.getBitWidth() >= bit_
https://github.com/clayborg approved this pull request.
I am good with this. We should wait for anyone else to chime in for a day or
two.
https://github.com/llvm/llvm-project/pull/150149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/150149
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1978,7 +1978,12 @@ llvm::Expected DWARFExpression::Evaluate(
// grows to the nearest host integer type.
llvm::APInt fail_value(1, 0, false);
llvm::APInt ap_int = scalar.UInt128(fail_value);
-assert(ap_int.getBitWidth() >= bit_
@@ -965,6 +965,16 @@ Status PluginManager::SaveCore(const lldb::ProcessSP
&process_sp,
return error;
}
+ if (!options.GetProcess())
+options.SetProcess(process_sp);
clayborg wrote:
We should be doing this before calling SaveCore as what if this pr
@@ -965,6 +965,16 @@ Status PluginManager::SaveCore(const lldb::ProcessSP
&process_sp,
return error;
}
+ if (!options.GetProcess())
+options.SetProcess(process_sp);
+
+ // Make sure the process sp is the same as the one we are using.
+ if (options.GetProcess() !=
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/146777
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
> > Unfortunately there is no easy way to add testing for this. No RISCV
> > hardware at the disposal. I welcome the suggestions.
>
> Make a core file that does not include any internal data and then it can be
> tested on any system. If you have to satisfy internal policies aro
@@ -57,11 +57,12 @@ class EmulateInstructionRISCV : public EmulateInstruction {
static bool SupportsThisInstructionType(InstructionType inst_type) {
switch (inst_type) {
-case eInstructionTypeAny:
-case eInstructionTypePCModifying:
+case lldb_private::eInstru
https://github.com/clayborg commented:
This patch looks good to me unless we are trying to protect the ModuleList
contents during the notification to ensure it doesn't change before the
notification has been delivered. Jim and Jonas? Thoughts?
https://github.com/llvm/llvm-project/pull/148774
_
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/147775
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1321,10 +1321,11 @@ enum CompletionType {
eTypeCategoryNameCompletion = (1ul << 24),
eCustomCompletion = (1ul << 25),
eThreadIDCompletion = (1ul << 26),
+ eManagedPluginCompletion = (1ul << 27),
// This last enum element is just for input validation.
// Add new
https://github.com/clayborg requested changes to this pull request.
Make the process subclasses that save core files use the
`llvm::Expected GetMemoryRegionsToSave();`
from `SaveCoreOptions`. This will ensure everyone is using the same list.
https://github.com/llvm/llvm-project/pull/146777
___
https://github.com/clayborg requested changes to this pull request.
Remove flags from all APIs. Enable 64 bit for any non stack memory regions to
allow us to test the 64 bit memory regions all of the time.
https://github.com/llvm/llvm-project/pull/146777
___
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/148290
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/148290
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -49,6 +49,7 @@ enum class LLDBLog : Log::MaskType {
Watchpoints = Log::ChannelFlag<30>,
OnDemand = Log::ChannelFlag<31>,
Source = Log::ChannelFlag<32>,
+ Disassembler = Log::ChannelFlag<33>,
LLVM_MARK_AS_BITMASK_ENUM(OnDemand),
clayborg wrote:
I t
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/148290
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -1146,7 +1146,7 @@ class InstructionLLVMC : public lldb_private::Instruction
{
}
}
-if (Log *log = GetLog(LLDBLog::Process)) {
+if (Log *log = GetLog(LLDBLog::Disassembler)) {
clayborg wrote:
We do have the option to specify multiple fla
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/146166
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
This didn't come out right... This should be for my GPU branch only.
https://github.com/llvm/llvm-project/pull/146978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg closed
https://github.com/llvm/llvm-project/pull/146978
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -621,22 +623,25 @@ DataExtractor data(arg_data.GetBytes(), arg_data_size,
}
Environment &proc_env = process_info.GetEnvironment();
+ bool is_simulator = false;
while ((cstr = data.GetCStr(&offset))) {
clayborg wrote:
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/139174
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -621,22 +623,25 @@ DataExtractor data(arg_data.GetBytes(), arg_data_size,
}
Environment &proc_env = process_info.GetEnvironment();
+ bool is_simulator = false;
while ((cstr = data.GetCStr(&offset))) {
if (cstr[0] == '\0')
@@ -353,6 +386,8 @@ llvm::json::Value DebuggerStats::ReportStatistics(
for (const auto &symbol_module : symbol_modules.Modules())
module_stat.symfile_modules.push_back((intptr_t)symbol_module.get());
}
+ UpdateDwoFileCounts(sym_file, total_dwo_file_
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/144424
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -33,6 +33,37 @@ static void EmplaceSafeString(llvm::json::Object &obj,
llvm::StringRef key,
obj.try_emplace(key, llvm::json::fixUTF8(str));
}
+static void UpdateDwoFileCounts(SymbolFile *sym_file,
+uint32_t &total_dwo_file_count,
+
clayborg wrote:
> It also seems architecturally wrong to try to guess and influence what
> BreakpointResolvers do behind their backs. After all, the resolver might be
> just some Python Code you know nothing about. How would you instrument that?
> If I set a regular expression name breakpoint,
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/144119
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -633,6 +633,14 @@ lldb::SBFileSpec SBModule::GetSymbolFileSpec() const {
return sb_file_spec;
}
+lldb::SBFileSpecList SBModule::GetSeparateDebugInfoFiles() {
clayborg wrote:
lldb::SBModuleSpecList
https://github.com/llvm/llvm-project/pull/144119
___
@@ -287,6 +287,14 @@ class LLDB_API SBModule {
/// A const reference to the file specification object.
lldb::SBFileSpec GetSymbolFileSpec() const;
+ /// Get a list of filespecs associated with all the separate symbol files
+ /// associated with this module.
+ ///
+
@@ -31,6 +31,11 @@ SBFileSpecList::SBFileSpecList(const SBFileSpecList &rhs) {
m_opaque_up = clone(rhs.m_opaque_up);
}
+SBFileSpecList::SBFileSpecList(FileSpecList &&list)
+: m_opaque_up(new FileSpecList(std::move(list))) {
+ LLDB_INSTRUMENT_VA(this);
+}
+
-
@@ -223,6 +223,10 @@ class SymbolFileOnDemand : public lldb_private::SymbolFile
{
return m_sym_file_impl->SetDebugInfoHadFrameVariableErrors();
}
+ lldb_private::FileSpecList GetSeparateDebugInfoFiles() override {
clayborg wrote:
ModuleSpecList
https
@@ -482,6 +482,8 @@ class Module : public std::enable_shared_from_this,
const FileSpec &GetSymbolFileFileSpec() const { return m_symfile_spec; }
+ FileSpecList GetSeparateDebugInfoFiles();
clayborg wrote:
ModuleSpecList
https://github.com/llvm/llvm-proje
@@ -472,6 +473,16 @@ class SymbolFile : public PluginInterface {
return false;
};
+ /// Return a map of separate debug info files that are loaded.
+ ///
+ /// Unlike GetSeparateDebugInfo(), this function will only return the list of
+ /// files, if there are errors t
@@ -1706,6 +1706,8 @@ bool Target::SetArchitecture(const ArchSpec &arch_spec,
bool set_platform,
if (PlatformSP arch_platform_sp =
GetDebugger().GetPlatformList().GetOrCreate(other, {},
&platfo
clayborg wrote:
No comments, good to merge IMHO.
https://github.com/llvm/llvm-project/pull/143970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
clayborg wrote:
One idea is to add a new string method on the llvm::Triple class:
```
const std::string strNoObjectFormat() const;
```
And this would check if the object format is in the string in
`llvm::Triple::Data` and if so strip it and return it, else return the
`llvm::Triple::Data` as i
https://github.com/clayborg commented:
We really should get the object file format correct from a triple extracted
from a LLDB ObjectFile at all times. In the mach-o parser we know it is a
mach-o file, so we really should always set this IMHO to be as correct as
possible and possibly fix the L
clayborg wrote:
> The reason is that those files don't have load commands like
> `LC_BUILD_VERSION` or `LC_VERSION_MIN_*`
What kind of files don't have this `LC_VERSION_MIN_*` set? That seems like the
bug we should be fixing.
https://github.com/llvm/llvm-project/pull/143633
__
https://github.com/clayborg commented:
This seems ok, but we should get some ok from the owners or contributors to the
`llvm/lib/TargetParser/Triple.cpp` file.
https://github.com/llvm/llvm-project/pull/143633
___
lldb-commits mailing list
lldb-commit
@@ -45,9 +49,16 @@ struct Range {
friend bool operator==(const Range &lhs, const Range &rhs) {
return lhs.start == rhs.start && lhs.range_ref == rhs.range_ref;
}
+
+ friend bool operator<(const Range &lhs, const Range &rhs) {
+return lhs.start < rhs.start;
https://github.com/clayborg edited
https://github.com/llvm/llvm-project/pull/136040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
Just one nit in the less than operator.
https://github.com/llvm/llvm-project/pull/136040
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/l
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/143970
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -10,10 +10,10 @@
# Test plugin list without an argument will list all plugins.
plugin list
# CHECK-LABEL: plugin list
-# CHECK: system-runtime
-# CHECK: [+] systemruntime-macosx System runtime plugin for Mac OS
X native libraries
# CHECK: instrumentation-runtime
clayborg wrote:
> This seems like a generic module loading observer. I don't see anything JIT
> specific about it. Not saying a generic module loading observer is not a good
> idea. But calling it a JITLoader seems pretty confusing to me.
true, in the current form. Check out the comments in my
clayborg wrote:
> > This seems like a generic module loading observer. I don't see anything JIT
> > specific about it. Not saying a generic module loading observer is not a
> > good idea. But calling it a JITLoader seems pretty confusing to me.
>
> +1 on the name. The design seems very general
https://github.com/clayborg requested changes to this pull request.
Just add a quick test for this and it is ready to go.
https://github.com/llvm/llvm-project/pull/134133
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -486,6 +544,12 @@ class PluginManager {
static InstrumentationRuntimeCreateInstance
GetInstrumentationRuntimeCreateCallbackAtIndex(uint32_t idx);
+ static std::vector
+ GetInstrumentationRuntimePluginInfo();
clayborg wrote:
Did the system runtime stu
@@ -181,6 +181,56 @@ void PluginManager::Terminate() {
plugin_map.clear();
}
+llvm::ArrayRef PluginManager::GetPluginNamespaces() {
+ // Currently supported set of plugin namespaces. This will be expanded
+ // over time.
+ static PluginNamespace PluginNamespaces[] = {
+
@@ -46,12 +48,287 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
@@ -46,12 +48,287 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -46,12 +48,255 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
@@ -0,0 +1,52 @@
+# This test validates the plugin list command.
+# Currently it works only for system-runtime plugins and we only have one
+# system runtime plugin so testing is a bit limited.
+#
+# Note that commands that return errors will stop running a script, so we
+# have n
@@ -46,12 +48,255 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
@@ -46,12 +48,255 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
@@ -54,12 +57,67 @@ struct RegisteredPluginInfo {
bool enabled = false;
};
+// Define some data structures to describe known plugin "namespaces".
+// The PluginManager is organized into a series of static functions
+// that operate on different types of plugins. For example
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
The test is ok. Mach-o files have LC_SEGMENT_64 load commands, so no need to
change the test really. I mean, we can probably remove it and still have a
mach-o file, but not sure we need to.
https://github.com/llvm/llvm-project/pull/142704
@@ -120,6 +120,21 @@ TEST(Perf, RealPtraceScope) {
<< "Sensible values of ptrace_scope are between 0 and 3";
}
+TEST(Perf, RealPtraceScopeWhenNotExist) {
+ // We first check we can NOT read /proc/sys/kernel/yama/ptrace_scope
+ auto buffer_or_error =
+ errorOrToExp
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/142224
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -120,6 +120,21 @@ TEST(Perf, RealPtraceScope) {
<< "Sensible values of ptrace_scope are between 0 and 3";
}
+TEST(Perf, RealPtraceScopeWhenNotExist) {
+ // We first check we can NOT read /proc/sys/kernel/yama/ptrace_scope
+ auto buffer_or_error =
+ errorOrToExp
@@ -120,6 +120,21 @@ TEST(Perf, RealPtraceScope) {
<< "Sensible values of ptrace_scope are between 0 and 3";
}
+TEST(Perf, RealPtraceScopeWhenNotExist) {
+ // We first check we can NOT read /proc/sys/kernel/yama/ptrace_scope
+ auto buffer_or_error =
+ errorOrToExp
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/142200
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -46,12 +49,206 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
@@ -464,6 +466,24 @@ llvm::json::Value DebuggerStats::ReportStatistics(
}
}
+ if (include_plugins) {
+json::Object plugin_stats;
+for (const PluginNamespace &plugin_ns :
+ PluginManager::GetPluginNamespaces()) {
+ json::Array namespace_stats;
+
+
@@ -46,12 +49,206 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
@@ -174,12 +174,21 @@ struct StatisticsOptions {
return !GetSummaryOnly();
}
+ void SetIncludePlugins(bool value) { m_include_plugins = value; }
+ bool GetIncludePlugins() const {
+if (m_include_plugins.has_value())
+ return m_include_plugins.value();
+//
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/134418
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -46,12 +49,206 @@ class CommandObjectPluginLoad : public CommandObjectParsed
{
}
};
+namespace {
+// Helper function to perform an action on each matching plugin.
+// The action callback is given the containing namespace along with plugin info
+// for each matching plugi
https://github.com/clayborg approved this pull request.
https://github.com/llvm/llvm-project/pull/141995
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/clayborg approved this pull request.
Looks good. Watch the buildbot, and please run your tests on both macOS and
linux prior to merging to ensure we don't fail. I am a bit worried about system
runtime plug-ins causing symbols to be loaded on some configs.
https://github.com/
@@ -209,6 +209,26 @@ def test_default_no_run(self):
)
self.assertGreater(module_stats["symbolsLoaded"], 0)
clayborg wrote:
Same here, renamed "symbolTableSymbolCount"
https://github.com/llvm/llvm-project/pull/136795
___
https://github.com/clayborg requested changes to this pull request.
https://github.com/llvm/llvm-project/pull/136795
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -209,6 +209,26 @@ def test_default_no_run(self):
)
self.assertGreater(module_stats["symbolsLoaded"], 0)
+def test_default_no_run_no_preload_symbols(self):
+"""Test "statistics dump" without running the target and without
+preloadi
clayborg wrote:
Can we renamed `"symbolsLoaded"` to `"symbolTableSymbolCount"` and
`"totalSymbolsLoaded"` to `"totalSymbolTableSymbolCount"`? This would be more
consistent with the other symbol table statistics
https://github.com/llvm/llvm-project/pull/136226
__
@@ -45,9 +49,16 @@ struct Range {
friend bool operator==(const Range &lhs, const Range &rhs) {
return lhs.start == rhs.start && lhs.range_ref == rhs.range_ref;
}
+
+ friend bool operator<(const Range &lhs, const Range &rhs) {
+return lhs.start < rhs.start;
+ }
---
1 - 100 of 1860 matches
Mail list logo
