Re: [Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

2016-12-02 Thread Filipe Cabecinhas via lldb-commits
.Case("stack-use-after-return", "Use of returned stack memory") Maybe "Use of stack memory after (function) return"? (i couldn't decide whether to include "function". Either delete it or delete the parens. This is a very minor nit, so I'm ok with keeping the current wording if you prefer that.

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

2016-11-23 Thread Filipe Cabecinhas via lldb-commits
filcab added inline comments. Comment at: source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRuntime.cpp:220 + } else if (description == "stack-overflow") { +return "Stack overflow detected (recursion too deep)"; + } else if (description == "null-deref"

[Lldb-commits] [PATCH] D27017: Support more report types in AddressSanitizerRuntime.cpp

2016-11-23 Thread Filipe Cabecinhas via lldb-commits
filcab added a comment. I have some minor fixes I'd like to see. If it's prefixed by "Nit: " it's a really minor one and I'm ok with it as is if that's what you prefer. Thank you, Filipe Comment at: source/Plugins/InstrumentationRuntime/AddressSanitizer/AddressSanitizerRunti

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-19 Thread Filipe Cabecinhas via lldb-commits
filcab added a comment. Thanks a lot for working on this! Filipe https://reviews.llvm.org/D22463 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D22463: [RFC] Moving to GitHub Proposal: NOT DECISION!

2016-07-18 Thread Filipe Cabecinhas via lldb-commits
filcab added a subscriber: filcab. filcab added a comment. What about branches? I'm guessing we should expect the usual release branches. But will any person be able to create a branch? Will there be a policy, if this is the case? Is the policy enforceable? Comment at: docs/Pr