https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/136160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Closing in favor of the stack of patches here:
[[lldb][nfc] Factor out code from ThreadPlanStepOut ctor
#136159](https://github.com/llvm/llvm-project/pull/136159)
[[lldb][nfc] Split the constructor of ThreadPlanStepOut
#136160](https://github.com/llvm/llvm-project/pull/13
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/136163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/136161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Addressed review comments, rebased on top of main
https://github.com/llvm/llvm-project/pull/136163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/136163
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/136163
>From d1f15f7a23b75d7b68989ac84b1c4b5991fb120d Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 17 Apr 2025 09:36:22 -0700
Subject: [PATCH 1/2] [lldb] Create ThreadPlanStepOut ctor tha
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/136161
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/136160
>From 42850d46b705c239b099be8d102a3756a8fd5283 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Tue, 15 Apr 2025 10:20:41 -0700
Subject: [PATCH 1/3] [lldb][nfc] Factor out code from ThreadP
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/136160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/136159
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/136159
A future patch will need to create a new constructor for this class, and
extracting code out of its sole existing constructor will make this easier.
This commit creates a helper function for the code com
felipepiovezan wrote:
Closing in favor of the stack:
[[lldb][nfc] Factor out code from ThreadPlanStepOut ctor
#136159](https://github.com/llvm/llvm-project/pull/136159)
[[lldb][nfc] Split the constructor of ThreadPlanStepOut
#136160](https://github.com/llvm/llvm-project/pull/136160)
[[lldb][nfc
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/135866
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/131800
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
> > That's what QueueThreadPlanStepOutNoShouldStop is supposed to do, maybe
> > it's not working?
>
> There is only one constructor for step out, and it always skips those frames.
> So, yes, even in `QueueThreadPlanForStepOutNoShouldStop` we will skip over
> frames.
In
felipepiovezan wrote:
> That's what QueueThreadPlanStepOutNoShouldStop is supposed to do, maybe it's
> not working?
There is only one constructor for step out, and it always skips those frames.
So, yes, even in `QueueThreadPlanForStepOutNoShouldStop` we will skip over
frames.
https://github.
felipepiovezan wrote:
> The `frame_idx` parameter is the frame you step out to.
I don't think this is quite true, that parameter indicates where we step out
_from_. I know this distinction may look unimportant at first, but it is
exactly that distinction that gives the constructor space to ski
felipepiovezan wrote:
It's worth mentioning that the LLVM convention (as opposed to what is done in
the swift fork) is to avoid force-pushing.
Instead, you'd always add a new fixup commit (`git commit --fixup`) and squash
them when merging (note that, for llvm, github will force you into squas
felipepiovezan wrote:
>then it would queue up a ThreadPlanStepOut that would go to that frame.
To elaborate on this, today there is no constructor for StepOut that allows one
to specify a target frame. This is also something we would need to create for
that to work, right?
https://github.com
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/135869
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/135866
>From 3804a622a92ed541e4ee1a40298442e78b687507 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Tue, 15 Apr 2025 10:20:41 -0700
Subject: [PATCH] [lldb][nfc] Add customization flags for Thre
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/135866
ThreadPlanStepOut always skips over Hidden/Artificial frames when computing its
destination frame, without providing any customization of this behavior. This
is problematic for some plans like StepThroug
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/135637
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/135637
This is necessary so that LLDB does not select (or show the stop reason for) a
thread which stopped at an internal breakpoint.
Other than manual testing/inspection, which I've done, this does not seem to
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/135637
>From 0383630d48f60cf25d241deda909737869b65998 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Mon, 14 Apr 2025 08:56:55 -0700
Subject: [PATCH] [lldb] Override Should{Select,Show} in StopR
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/135296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/135296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/135296
>From b24dc5da70443eb15819c6134ddd38c84f86a5e5 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Wed, 9 Apr 2025 07:38:13 -0700
Subject: [PATCH] Reland "[lldb] Clear thread-creation breakpoi
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/135296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/135296
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/135296
This reapplies commit 232525f06942adb3b9977632e38dcd5f08c0642d.
The original commit triggered a sanitizer failure when Target was destroyed. In
Target::Destroy, `DeleteCurrentProcess` was called, but i
@@ -2074,6 +2076,64 @@ static const Definition *FindEntry(const llvm::StringRef
&format_str,
return parent;
}
+/// Parses a single highlighting format specifier.
+///
+/// Example syntax for such specifier:
+/// \code
+/// ${function.name-with-args:%highlight_basename(ansi.
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/134757
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Based on the 2013 commit that added those, I don't think there is a clean way
of testing this.
That said, since these methods simply forward to the underlying register
context, I think it's ok to rely on the lack of regression from the OS plugin
tests
https://github.com/
https://github.com/felipepiovezan approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/132127
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/134469
The UpdateRegisterContext method can be called from multiple threads.
>From ef59ad0f6522e5ca35cfeed562fc528b4732fb22 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 4 Apr 2025 18:28:
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/134469
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/134160
>From 48150d4bb0daf57b708f4fa86285f028eeff0da6 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Wed, 2 Apr 2025 09:28:56 -0700
Subject: [PATCH 1/2] [lldb][NFC] Move ShouldShow/ShouldSelect
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/134397
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/134397
>From e7689b631d898e4f2a6f2cff6e60c1a05a65c7ea Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 4 Apr 2025 07:56:38 -0700
Subject: [PATCH] [lldb] Clear thread-creation breakpoints in
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/134397
Currently, these breakpoints are being accumulated every time a new process if
created (e.g. through a `run`). Depending on the circumstances, the old
breakpoints are even left enabled, interfering with
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/134397
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/134160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/134160
>From 48150d4bb0daf57b708f4fa86285f028eeff0da6 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Wed, 2 Apr 2025 09:28:56 -0700
Subject: [PATCH 1/3] [lldb][NFC] Move ShouldShow/ShouldSelect
felipepiovezan wrote:
Addressed review comments
https://github.com/llvm/llvm-project/pull/134160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/134160
This NFC patch simplifies the main loop in HandleProcessStateChanged event by
moving duplicated code into the StopInfo class, also allowing StopInfo
subclasses to override behavior.
More specifically, t
felipepiovezan wrote:
This type of patch also slightly worries me in that it could make it harder to
unify the LLDB dwarf data structures with the LLVM ones
https://github.com/llvm/llvm-project/pull/131645
___
lldb-commits mailing list
lldb-commits@li
felipepiovezan wrote:
Should this also change the interface of DWAFExpressionList?
```
DWARFExpressionList(lldb::ModuleSP module_sp,
const plugin::dwarf::DWARFUnit *dwarf_cu,
lldb::addr_t func_file_addr)
: m_module_wp(module_sp), m_dwarf_cu(dwa
felipepiovezan wrote:
In order to preserve the two separate commits (and not squash them) I've merged
this into two separate PRs:
https://github.com/llvm/llvm-project/pull/132905
https://github.com/llvm/llvm-project/pull/132906
So I'll close this now.
https://github.com/llvm/llvm-project/pull/
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/132906
This commit makes ThreadMemory a real "forwarder" class by implementing the
missing queue methods: they will just call the corresponding backing thread
method.
To make this patch NFC(*) and not change t
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/132734
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/132906
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
This was reviewed and approved in
https://github.com/llvm/llvm-project/pull/132734
But, in order to preserve the small commits, I'm merging through separate PRs.
https://github.com/llvm/llvm-project/pull/132906
___
lldb-commits m
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/132905
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
This was reviewed and approved in
https://github.com/llvm/llvm-project/pull/132734
But, in order to preserve the small commits, I'm merging through separate PRs.
https://github.com/llvm/llvm-project/pull/132905
___
lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/132905
ThreadMemory attempts to be a class abstracting the notion of a "fake" Thread
that is backed by a "real" thread. According to its documentation, it is meant
to be a class forwarding most methods to the b
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/132734
Please read the two commit messages individually.
>From 00da78461321b019303ddffcec5620859829cd40 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Thu, 20 Mar 2025 14:59:33 -0300
Subject: [
felipepiovezan wrote:
> oh, that regression test will need to be added to the swiftlang cherrypick.
Nice! I've added it to that PR.
https://github.com/llvm/llvm-project/pull/132079
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://list
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/132079
These allow for more efficient saving/restoring state after an expression is
evaluated.
>From e619ec8d09fec2e0567ad6194f60968e89e40627 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Wed
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/131800
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/129937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan edited
https://github.com/llvm/llvm-project/pull/129937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan deleted
https://github.com/llvm/llvm-project/pull/129937
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -354,14 +354,13 @@ class Language : public PluginInterface {
virtual llvm::StringRef GetInstanceVariableName() { return {}; }
- /// Returns true if this SymbolContext should be ignored when setting
- /// breakpoints by line (number or regex). Helpful for languages that
@@ -354,14 +354,13 @@ class Language : public PluginInterface {
virtual llvm::StringRef GetInstanceVariableName() { return {}; }
- /// Returns true if this SymbolContext should be ignored when setting
- /// breakpoints by line (number or regex). Helpful for languages that
@@ -207,16 +207,15 @@ bool operator<(const SourceLoc lhs, const SourceLoc rhs) {
void BreakpointResolver::SetSCMatchesByLine(
SearchFilter &filter, SymbolContextList &sc_list, bool skip_prologue,
llvm::StringRef log_ident, uint32_t line, std::optional column) {
- llvm:
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/129937
This allows languages to make decisions based on the whole set of symbol
contexts, giving them strictly more power than when they are only allowed to
see one at a time.
>From 3d6a826964326a408b8e3a9d79c
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/129275
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/129275
>From cd6661b5fb7a9a71352c79740d4b0c0601e61d43 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 28 Feb 2025 09:11:11 -0800
Subject: [PATCH 1/4] [lldb] Add ability to inspect backing th
felipepiovezan wrote:
Linux bots seem to print the TID using decimal numbers, so I updated the regex.
https://github.com/llvm/llvm-project/pull/129275
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/list
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/129275
>From cd6661b5fb7a9a71352c79740d4b0c0601e61d43 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 28 Feb 2025 09:11:11 -0800
Subject: [PATCH 1/3] [lldb] Add ability to inspect backing th
https://github.com/felipepiovezan approved this pull request.
LGTM!
https://github.com/llvm/llvm-project/pull/129301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/129275
>From cd6661b5fb7a9a71352c79740d4b0c0601e61d43 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 28 Feb 2025 09:11:11 -0800
Subject: [PATCH 1/2] [lldb] Add ability to inspect backing th
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/129275
When OS plugins are present, it can be helpful to query information about the
backing thread behind an OS thread, if it exists. There is no mechanism to do
so prior to this commit.
As a first step, this
felipepiovezan wrote:
Yup, as Jason said, we have been thinking about this and we believe there may
be a better way of doing this! I'm going to close this PR for now
https://github.com/llvm/llvm-project/pull/128726
___
lldb-commits mailing list
lldb-c
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/128726
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/128724
This code is replicated in multiple places, and a subsequent commit would
introduce another copy of it in ThreadMemory.
>From e53d5e606da5703152759fa927ac066575b4ab11 Mon Sep 17 00:00:00 2001
From: Felip
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/128726
* One of the overloads of CreateStopReasonWithBreakpointSiteID was missing a
call to SetThreadHitBreakpointSite.
* ThreadMemory was missing a "DetectThreadStoppedAtUnexecutedBP" in its
CalculateStopInfo.
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/127922
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/126128
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/126128
These prevented ThreadMemory from correctly returning the Name/Queue/Info of
the backing thread.
Note about testing: this test only finds regressions if the system sets a name
or queue for the backing t
https://github.com/felipepiovezan approved this pull request.
LGTM! Thanks for improving this, this has fooled me once before 😅
https://github.com/llvm/llvm-project/pull/125969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.ll
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/125302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Rebased
https://github.com/llvm/llvm-project/pull/125302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/125302
>From a2c624aad7e1fd931bba98f2086732bda5059ef7 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 31 Jan 2025 12:28:45 -0800
Subject: [PATCH] [lldb] Improve isolation between Process plu
https://github.com/felipepiovezan closed
https://github.com/llvm/llvm-project/pull/125300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
felipepiovezan wrote:
Forcing push seems to have made it work
https://github.com/llvm/llvm-project/pull/125300
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/125300
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 31 Jan 2025 12:07:45 -0800
Subject: [PATCH 1/4] [lldb] Implement bidirectional access fo
felipepiovezan wrote:
Turns out github has been stuck for ours without picking up my pushed fixup
commit :/
https://github.com/user-attachments/assets/ef97e7b5-acd2-4812-a258-f3030615d51c";
/>
https://github.com/llvm/llvm-project/pull/125300
___
ll
felipepiovezan wrote:
> Reference in new issue
> This creates a shared_pointer loop between the two objects, which doesn't
> sound like a good design. Maybe one of the pointers ought to be weak?
great catch!, I'll fix that
https://github.com/llvm/llvm-project/pull/125300
___
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/125300
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 31 Jan 2025 12:07:45 -0800
Subject: [PATCH 1/3] [lldb] Implement bidirectional access fo
https://github.com/felipepiovezan updated
https://github.com/llvm/llvm-project/pull/125300
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep 17 00:00:00 2001
From: Felipe de Azevedo Piovezan
Date: Fri, 31 Jan 2025 12:07:45 -0800
Subject: [PATCH 1/2] [lldb] Implement bidirectional access fo
@@ -470,6 +470,18 @@ class Thread : public std::enable_shared_from_this,
virtual void ClearStackFrames();
+ /// Derived classes implementing SetBackingThread should use this to provide
+ /// bidirectional access to the Backing-Backed relationship.
+ void SetBackedThread(
@@ -72,12 +72,17 @@ class ThreadMemory : public lldb_private::Thread {
void ClearStackFrames() override;
- void ClearBackingThread() override { m_backing_thread_sp.reset(); }
+ void ClearBackingThread() override {
+if (m_backing_thread_sp)
+ m_backing_thread_sp->
felipepiovezan wrote:
Depends on https://github.com/llvm/llvm-project/pull/125300
https://github.com/llvm/llvm-project/pull/125302
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/125302
Generally speaking, process plugins (e.g. ProcessGDBRemote) should not be aware
of OS plugin threads. However, ProcessGDBRemote attempts to check for the
existence of OS threads when calculating stop inf
https://github.com/felipepiovezan created
https://github.com/llvm/llvm-project/pull/125300
This enables finding the backed thread from the backing thread without going
through the thread list, and it will be useful for subsequent commits.
>From 0c9d9ed5b1aa78f397e95c894def54ee627bea62 Mon Sep
https://github.com/felipepiovezan approved this pull request.
after staring at this long enough, I think this is fine, since the uint->int
conversion is done by apint
https://github.com/llvm/llvm-project/pull/125244
___
lldb-commits mailing list
lldb-
https://github.com/felipepiovezan approved this pull request.
https://github.com/llvm/llvm-project/pull/124811
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 517 matches
Mail list logo
