[Lldb-commits] [PATCH] D54074: CPlusPlusLanguage: Use new demangler API to implement type substitution

erik.pilkington added a comment. Looks good to me too, thanks! https://reviews.llvm.org/D54074 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D50473: [Demangle] Add another test for ItaniumPartialDemangler

erik.pilkington accepted this revision. erik.pilkington added a comment. This revision is now accepted and ready to land. LGTM, thanks for doing this! Comment at: unittests/Demangle/PartialDemangleTest.cpp:188 +size_t N = OriginalSize; +char *Res = D.getFunctionName(Buf

[Lldb-commits] [PATCH] D49990: Use rich mangling information in Symtab::InitNameIndexes()

erik.pilkington added inline comments. Comment at: source/Symbol/Symtab.cpp:274 + case ItaniumPartialDemangler: +m_IPD_buf = m_IPD->getFunctionBaseName(m_IPD_buf, &m_IPD_size); +return m_IPD_buf; sgraenitz wrote: > @erik.pilkington Is it acceptable/good

[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

erik.pilkington added inline comments. Comment at: source/Core/Mangled.cpp:310 +#elif defined(LLDB_USE_LLVM_DEMANGLER) +llvm::ItaniumPartialDemangler IPD; +bool demangle_err = IPD.partialDemangle(mangled_name); sgraenitz wrote: > erik.pilkington w

[Lldb-commits] [PATCH] D49612: Use LLVM's new ItaniumPartialDemangler in LLDB

erik.pilkington added a comment. In https://reviews.llvm.org/D49612#1171550, @sgraenitz wrote: > Quick local performance check doing `target create clang` in current review > version vs. master HEAD version (both loading the exact same release build of > clang) looks promising. It's faster alre