[Lldb-commits] [PATCH] D30984: Centralize libc++ test skipping logic

2017-03-29 Thread Eric Fiselier via Phabricator via lldb-commits
EricWF added a comment. In https://reviews.llvm.org/D30984#713490, @labath wrote: > In https://reviews.llvm.org/D30984#711806, @EricWF wrote: > > > I don't see anything wrong with this, but I only know libc++ and not LLDB. > > > I'm not sure why you ended up here. I think you have too wide phabri

[Lldb-commits] [PATCH] D30984: Centralize libc++ test skipping logic

2017-03-27 Thread Eric Fiselier via Phabricator via lldb-commits
EricWF added a comment. I don't see anything wrong with this, but I only know libc++ and not LLDB. > libc++'s atomic does not play well with gcc on linux It should... Can you elaborate on this issue? I suspect this may be a libc++ bug. https://reviews.llvm.org/D30984