[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

echristo added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:20 #include +#include #include echristo wrote: > echristo wrote: > > This is problematic in that sys/sysctl is deprecated on linux (causing > > warnings/

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

echristo added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:20 #include +#include #include This is problematic in that sys/sysctl is deprecated on linux (causing warnings/Werror failures). CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

echristo added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:20 #include +#include #include echristo wrote: > This is problematic in that sys/sysctl is deprecated on linux (causing > warnings/Werror failures). I'm

[Lldb-commits] [PATCH] D82238: lldb whitelist -> allowed

echristo created this revision. echristo added a reviewer: mehdi_amini. Herald added subscribers: aaron.ballman, atanasyan, jrtc27, kbarton, nemanjai, sdardis, mcrosier. Herald added a project: LLDB. echristo edited the summary of this revision. Herald added a subscriber: wuzish. As part of using

[Lldb-commits] [PATCH] D82236: blacklist -> exclusions: heap.py

echristo created this revision. echristo added a reviewer: mehdi_amini. Herald added subscribers: aaron.ballman, mcrosier. Herald added a project: LLDB. echristo edited the summary of this revision. As part of using inclusive language with the llvm project migrate away from the use of blacklist a

[Lldb-commits] [PATCH] D65410: [PassManager] First Pass implementation at -O1 pass pipeline

This revision was not accepted when it landed; it landed in state "Needs Revision". This revision was automatically updated to reflect the committed changes. Closed by commit rGfd39b1bb20ce: Revert "Revert "As a follow-up to my initial mail to llvm-dev here's a first… (authored by echristo). Hera

[Lldb-commits] [PATCH] D66795: [Mips] Use appropriate private label prefix based on Mips ABI

echristo added a comment. I kinda want the option to be encoded in the triple for earlier testing of linking issues, but for now this is probably OK. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D66795/new/ https://reviews.llvm.org/D66795

[Lldb-commits] [PATCH] D61737: [lldb] add -ex CLI option as alias to --one-line

echristo added a comment. In D61737#1497202 , @jingham wrote: > I would rather not clutter up the lldb command driver's options with gdb > command flags. That seems like it will make lldb harder to figure out and > reduce our freedom to choose reasonabl

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

echristo added a comment. In D54747#1315241 , @ruiu wrote: > But 2GB is perhaps still too big and I guess a large part of it can be for > dead sections. If we fix this, I'd like to fix it in a proper way so that we > can completely eliminate debug info f

[Lldb-commits] [PATCH] D54747: Discard debuginfo for object files empty after GC

echristo added a comment. In D54747#1312161 , @ruiu wrote: > Thank you for the patch. > > What you are doing in this patch is not too complicated and makes sense to > me. That said, if actual size saving is not significant as you said in > https://github