[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto max_instruction_size = g_vsc.target.GetMaximumOpcodeByteSize(); + const auto bytes_offset = -instruction_offset * max_instruction_size; + auto start_addr = base_addr - bytes_of

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto max_instruction_size = g_vsc.target.GetMaximumOpcodeByteSize(); + const auto bytes_offset = -instruction_offset * max_instruction_size; + auto start_addr = base_addr - bytes_of

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto bytes_offset = -instruction_offset * bytes_per_instruction; + auto start_addr = base_addr - bytes_offset; + const auto disassemble_bytes = instruction_count * bytes_per_instruc

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added a comment. In D140358#4045469 , @eloparco wrote: > In D140358#4045450 , @clayborg > wrote: > >> In D140358#4045442 , @eloparco >> wrote: >> >>> In D140358

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 488415. eloparco added a comment. Use single-line comments Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 Files: lldb/bindings/interface/SBTarget.i lldb/include

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added a comment. In D140358#4045450 , @clayborg wrote: > In D140358#4045442 , @eloparco > wrote: > >> In D140358#4045210 , @clayborg >> wrote: >> >>> Are you pl

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/include/lldb/API/SBTarget.h:844 + uint32_t GetMaximumOpcodeByteSize() const; + clayborg wrote: > Do we still need this API change with the new approach? We can't really use > this unless we include GetMinimumOp

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added a comment. In D140358#4045210 , @clayborg wrote: > Are you planning on updating the reverse disassembly code still on this patch? What do you mean by "reverse disassembly"? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added a comment. @jingham I added the test that was missing Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 ___ lldb-commits mailing list lldb-commits@

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 488117. eloparco added a comment. Add binding and test for SBTarget::GetMaximumOpcodeByteSize() Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 Files: lldb/binding

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 486794. eloparco added a comment. Fix disassemble on variable-length instructions and disassemble with positive offset Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D14035

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2194 + if (index == sb_instructions.size() + 1) { +fprintf(stderr, "current line not found in disassembled instructions\n"); +return response_instructions; eloparco wrote:

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2194 + if (index == sb_instructions.size() + 1) { +fprintf(stderr, "current line not found in disassembled instructions\n"); +return response_instructions; clayborg wrote:

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto bytes_offset = -instruction_offset * bytes_per_instruction; + auto start_addr = base_addr - bytes_offset; + const auto disassemble_bytes = instruction_count * bytes_per_instruc

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 486554. eloparco added a comment. Add integration tests for disassemble request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 Files: lldb/include/lldb/API/SBTarg

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 486553. eloparco added a comment. Add integration tests for disassemble request Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 Files: lldb/include/lldb/API/SBTarg

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 486514. eloparco added a comment. Remove printf usage Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 Files: lldb/include/lldb/API/SBTarget.h lldb/source/API/SBT

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2194 + if (index == sb_instructions.size() + 1) { +fprintf(stderr, "current line not found in disassembled instructions\n"); +return response_instructions; clayborg wrote:

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added inline comments. Comment at: lldb/tools/lldb-vscode/lldb-vscode.cpp:2177 + const auto bytes_offset = -instruction_offset * bytes_per_instruction; + auto start_addr = base_addr - bytes_offset; + const auto disassemble_bytes = instruction_count * bytes_per_instruc

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added a comment. @JDevlieghere let me know if there's anything I can do to make the review easier Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D140358/new/ https://reviews.llvm.org/D140358 ___ l

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco updated this revision to Diff 484579. eloparco added a comment. Avoid tracking stack frame boundaries. It is unnecessary and makes the disassembler functionality not work in multi-threaded programs. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco added a comment. That's how it currently looks like: F25758029: image.png I plan on adding support for disassembly in multi-threaded applications (now I only track the stack frame for the main thread in `g_curr_frame`). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D140358: [lldb-vscode] Add support for disassembly view

eloparco created this revision. Herald added a project: All. eloparco requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Implement DAP (Debug Adapter Protocol) for Disassemble Requests. Repository: rG LLVM Github Monorepo https://reviews.