@@ -737,6 +738,11 @@ class LLDB_API SBTarget {
lldb::SBBreakpoint BreakpointCreateBySBAddress(SBAddress &address);
+ lldb::SBBreakpoint
+ BreakpointCreateByFileAddress(const SBFileSpec &file_spec, addr_t file_addr,
+addr_t offset = 0,
+
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/148061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/148061
>From c9fc191e93381b90b67d72799bab1b9ea19b8c42 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 17 May 2025 23:49:10 +0200
Subject: [PATCH 01/19] [lldb-dap] Support persistent assembly breakpoints
---
lldb
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/142275
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/140470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/142275
>From 7d256c09cd9dbefb35fc852450b38943f5040777 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 31 May 2025 12:30:13 +0200
Subject: [PATCH] Adding const modifier to SBAddress methods
---
lldb/include/lldb/
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/142275
I don't know if adding `const` specifier is considered breaking the API, but if
not it could be useful as it allows for `lldb-dap` to change some objects to
`const &`
>From 85e5ac0369b3d2cb263b82912af90762545c
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/142259
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/142259
None
>From 8f7b6fc7f4bba8b6efe7912557d98c5e9fd634c3 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 31 May 2025 09:29:01 +0200
Subject: [PATCH] fix PATH_MAX missing in windows build
---
lldb/tools/lldb-d
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 87cf6aee70458b0e9bbc717ee9a5cf9b91b6242a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/8] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 01/12] Reuse creation of Source objects for assembly and
normal sou
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 01/11] Reuse creation of Source objects for assembly and
normal sou
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2caa403bd34f132198d4e531129529d86d5ae2e9 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/7] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 01/10] Reuse creation of Source objects for assembly and
normal sou
@@ -23,15 +19,23 @@ def test_disassemble(self):
self.set_source_breakpoints(source, [line_number(source, "//
breakpoint 1")])
self.continue_to_next_stop()
-_, pc_assembly = self.disassemble(frameIndex=0)
-self.assertIn("location", pc_assembly,
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/9] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/8] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/eronnen deleted
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
eronnen wrote:
oh, yeah I can move it
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -139,15 +141,16 @@ static DisassembledInstruction
ConvertSBInstructionToDisassembledInstruction(
disassembled_inst.instruction = std::move(instruction);
- auto line_entry = addr.GetLineEntry();
+ auto source = CreateSource(addr, target);
+ auto line_entry = GetLineEn
@@ -0,0 +1,17 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/7] Reuse creation of Source objects for assembly and normal
sourc
eronnen wrote:
@ashgti
If these tests still won't be stable in the bots maybe #140470 could further
stabilize them
https://github.com/llvm/llvm-project/pull/141983
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/6] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/5] Reuse creation of Source objects for assembly and normal
sourc
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/142017
Fix TypeSCript comparison (when defining an empty config string like
`commandEscapePrefix=""` it would skip it)
>From 8632a15c5fa4a11b1a108d9b763b9241b5a2bc41 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Th
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 4c20703077eb4bbee8cfeb59022dec89d8697d83 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal
sourc
eronnen wrote:
Currently I don't think it can live in lldb-dap, because both setting the
target and calculating the symbol context are private:
```cpp
sc.target_sp = target.GetSP();
SymbolContextItem scope = static_cast(resolve_scope);
if (m_opaque_up->IsVal
eronnen wrote:
Looking at the `SBTarget::ResolveSymbolContextForAddress()` implementation it
won't apply source maps correctly because it doesn't set the target to the
symbol context at any point. in order to apply the source maps you must have
`sc.target_sp
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/3] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -317,6 +317,8 @@ struct Source {
std::optional presentationHint;
// unsupported keys: origin, sources, adapterData, checksums
+
+ bool IsAssemblySource() const { return sourceReference.value_or(0) != 0; }
eronnen wrote:
:100:
https://github.com/llvm
@@ -558,28 +558,38 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -252,4 +252,11 @@ std::string GetSBFileSpecPath(const lldb::SBFileSpec
&file_spec) {
return path;
}
+lldb::SBLineEntry GetLineEntryForAddress(lldb::SBTarget &target,
+ lldb::SBAddress &address) {
+ lldb::SBSymbolContext sc =
+
@@ -250,14 +252,16 @@ protocol::Source CreateSource(const lldb::SBFileSpec
&file);
/// Create a "Source" JSON object as described in the debug adapter definition.
///
-/// \param[in] line_entry
-/// The LLDB line table to use when populating out the "Source"
-/// obje
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/2] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/141427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen approved this pull request.
https://github.com/llvm/llvm-project/pull/141537
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141427
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141424
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2039,7 +2039,17 @@ lldb::SBInstructionList
SBTarget::ReadInstructions(lldb::SBAddress base_addr,
const size_t bytes_read =
target_sp->ReadMemory(*addr_ptr, data.GetBytes(), data.GetByteSize(),
error, force_live_memory, &load_
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/141427
None
>From 12b61db385a595f1a9028c194322cb3d3c746f3c Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 25 May 2025 22:22:34 +0200
Subject: [PATCH] [lldb] add missing cmake build type argument
---
lldb/utils
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/141426
Refactor code revolving source objects such that most logics will be reused.
The main change is to expose a single `CreateSource(addr, target)` that can
return either a normal or an assembly source object, an
https://github.com/eronnen approved this pull request.
https://github.com/llvm/llvm-project/pull/141122
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141407
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/141407
The test fails because LLDB does not recognize any function which is not in the
symbol table on armv7
>From 27159c6f52e18bf3b11553ce380449b38689154d Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 25 May
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/140975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/141212
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/141212
https://lab.llvm.org/buildbot/#/builders/141/builds/8927/steps/6/logs/stdio
>From 660eeaef30c2d99f0ed571029f4f7d6783a36789 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Fri, 23 May 2025 10:44:09 +0200
Subject
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/138416
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140975
>From 419aa75b4f0d3fe54a3e08c8223906224bad2822 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Thu, 22 May 2025 02:44:31 +0200
Subject: [PATCH 1/3] [lldb-dap] attempt to fix test_disassemble
---
lldb/test/API/
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/140975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
eronnen wrote:
@medismailben I tested locally and now the test should be fixed
https://github.com/llvm/llvm-project/pull/140975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
eronnen wrote:
I Haven't attempted, unfortunately I only own a x64 laptop, I can attempt to
reproduce on a VM later
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
eronnen wrote:
@medismailben can you share the cmake build arguments that you use for mac?
https://github.com/llvm/llvm-project/pull/140975
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-
eronnen wrote:
@medismailben Unfortunately I dont own a mac so I can't really test but I think
maybe this patch should fix it: https://github.com/llvm/llvm-project/pull/140975
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing l
@@ -136,6 +136,7 @@ def __init__(
self.initialized = False
self.frame_scopes = {}
self.init_commands = init_commands
+self.resolved_breakpoints = set([])
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/140470
__
@@ -985,7 +1013,10 @@ def request_setBreakpoints(self, file_path, line_array,
data=None):
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
+response = self.send_recv(command_dict)
+breakpo
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 5c1d1854c3f93e081405e27fa0f14a3c02ef7cc7 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/6] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
@@ -1011,7 +1042,10 @@ def request_setFunctionBreakpoints(self, names,
condition=None, hitCondition=Non
"type": "request",
"arguments": args_dict,
}
-return self.send_recv(command_dict)
+response = self.send_recv(command_dict)
+
@@ -422,8 +431,27 @@ def wait_for_breakpoint_events(self, timeout:
Optional[float] = None):
if not event:
break
breakpoint_events.append(event)
+
+self._update_verified_breakpoints(
eronnen wrote:
:100:
https:
@@ -62,9 +64,13 @@ def set_source_breakpoints(self, source_path, lines,
data=None):
breakpoint_ids = []
for breakpoint in breakpoints:
breakpoint_ids.append("%i" % (breakpoint["id"]))
+if wait_for_resolve:
+self.wait_for_breakpoi
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/5] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
@@ -45,20 +43,34 @@ def run_test_evaluate_expressions(
enableAutoVariableSummaries=enableAutoVariableSummaries,
)
source = "main.cpp"
-self.set_source_breakpoints(
-source,
-[
-line_number(source, "// b
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/4] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/140852
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/140852
Fix https://lab.llvm.org/buildbot/#/builders/141/builds/8867
>From cb69d50e158d9197b6e0fdb997de0086da1b8afa Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 08:09:23 +0200
Subject: [PATCH] add @
@@ -78,8 +84,40 @@ def set_function_breakpoints(self, functions,
condition=None, hitCondition=None)
breakpoint_ids = []
for breakpoint in breakpoints:
breakpoint_ids.append("%i" % (breakpoint["id"]))
+if wait_for_resolve:
+self.w
@@ -1187,15 +1187,17 @@ def request_locations(self, locationReference):
}
return self.send_recv(command_dict)
-def request_testGetTargetBreakpoints(self):
+def request_testGetTargetBreakpoints(self, only_resolved=False):
eronnen wrote:
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2ee16e3911bd1c93618f63f5068dcdcaf389e46c Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/3] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140486
>From 3cfe849fee4f5d489a3205ae0d2a8cd0f26a1b76 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Tue, 20 May 2025 00:47:48 +0200
Subject: [PATCH 1/4] [lldb-dap] Fix disassemble request instruction offset
handling
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -349,6 +349,10 @@ class LLDB_API SBTarget {
SBError SetLabel(const char *label);
+ uint32_t GetMinimumOpcodeByteSize() const;
+
+ uint32_t GetMaximumOpcodeByteSize() const;
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/140486
__
eronnen wrote:
@JDevlieghere Fixed comments, sorry for the trouble. I'll try to pay extra
attention next time :)
https://github.com/llvm/llvm-project/pull/139969
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/
eronnen wrote:
@JDevlieghere I Tried to simplify the logics as much as I can in the way you
asked, handling the case of unfixed opcode size and disassembling backwards is
still a bit complex because there is the edge case where padding is needed, but
I hope it's readable enough now.
https://g
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
@@ -56,100 +54,204 @@ DisassembleRequestHandler::Run(const DisassembleArguments
&args) const {
}
}
+ int64_t instructionOffset = args.instructionOffset.value_or(0);
+ if (instructionOffset > 0) {
+lldb::SBInstructionList forward_insts = dap.target.ReadInstructions
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140486
>From 3cfe849fee4f5d489a3205ae0d2a8cd0f26a1b76 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Tue, 20 May 2025 00:47:48 +0200
Subject: [PATCH 1/3] [lldb-dap] Fix disassemble request instruction offset
handling
@@ -72,21 +99,29 @@ BreakpointLocationsRequestHandler::Run(
}
}
- // The line entries are sorted by addresses, but we must return the list
- // ordered by line / column position.
- std::sort(locations.begin(), locations.end());
- locations.erase(llvm::unique(location
@@ -948,13 +956,11 @@ def request_scopes(self, frameId):
command_dict = {"command": "scopes", "type": "request", "arguments":
args_dict}
return self.send_recv(command_dict)
-def request_setBreakpoints(self, file_path, line_array, data=None):
+def reque
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen ready_for_review
https://github.com/llvm/llvm-project/pull/140486
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 311 matches
Mail list logo
