https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/155097
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/155097
>From 17f91ec0bcbeda08201a39d28657d2268cebbb74 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 23 Aug 2025 12:44:27 +0200
Subject: [PATCH 1/3] use vscode theme colors for alternating symbol table
colors
-
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/155097
>From 17f91ec0bcbeda08201a39d28657d2268cebbb74 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 23 Aug 2025 12:44:27 +0200
Subject: [PATCH 1/3] use vscode theme colors for alternating symbol table
colors
-
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/155097
* apply odd table rows color from vscode theme
* apply hover color from vscode theme
[Screencast From 2025-08-23
14-48-44.webm](https://github.com/user-attachments/assets/a738ac3c-3e56-4a57-b713-7430c614c415)
eronnen wrote:
I see that these tests failed in a build run before I merged this commit here:
https://lab.llvm.org/buildbot/#/builders/195/builds/13641
https://github.com/llvm/llvm-project/pull/155021
___
lldb-commits mailing list
lldb-commits@lists.l
eronnen wrote:
Don't think I changed anything related, but checking
https://github.com/llvm/llvm-project/pull/155021
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/155021
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/155021
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/155021
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/155021
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/155021
>From 894e70274cd2ea71af854df6fc5f3c7575c15408 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Fri, 22 Aug 2025 21:31:04 +0200
Subject: [PATCH 1/3] Reapply "[lldb-dap] Add module symbol table viewer to VS
Code
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/155021
Re-land the symbol table feature in lldb-dap after it was reverted because of a
crash in the `aarch64` tests, which was caused by dereferencing
`SBSymbol::GetName` which might return `nullptr` for an invalid sy
eronnen wrote:
Seems it caused by invalid symbols with a `nullptr` name, I'll add handling to
symbols without names
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
eronnen wrote:
@JDevlieghere Added public functions to `SBSymbol` to convert from and to
lldb::SymbolType
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman
@@ -1,9 +1,110 @@
#include "Protocol/DAPTypes.h"
+#include "lldb/lldb-enumerations.h"
using namespace llvm;
namespace lldb_dap::protocol {
+static std::string SymbolTypeToString(lldb::SymbolType symbol_type) {
eronnen wrote:
:100:
https://github.com/ll
@@ -1,9 +1,110 @@
#include "Protocol/DAPTypes.h"
+#include "lldb/lldb-enumerations.h"
using namespace llvm;
namespace lldb_dap::protocol {
+static std::string SymbolTypeToString(lldb::SymbolType symbol_type) {
+ switch (symbol_type) {
+ case lldb::eSymbolTypeInvalid:
+
eronnen wrote:
> I haven't looked at the code yet, but based on the video, I'm assuming this
> happens "on demand", right? A user has to interact with the module view to
> request the symbols?
Yes, the user has to click on "Show Module Symbols" from the context menu of
the module tree or thro
@@ -594,6 +594,20 @@ class CancelRequestHandler : public
RequestHandler> {
+public:
+ using RequestHandler::RequestHandler;
+ static llvm::StringLiteral GetCommand() { return "moduleSymbols"; }
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/1
@@ -0,0 +1,37 @@
+"""
+Test lldb-dap moduleSymbols request
+"""
+
+import lldbdap_testcase
+
+
+class TestDAP_moduleSymbols(lldbdap_testcase.DAPTestCaseBase):
+def test_moduleSymbols(self):
+"""
+Test that the stack frame without a module still has assembly sou
@@ -146,6 +164,10 @@ export class DebugSessionTracker
this.logger.info(
`Session "${session.name}" exited with code ${exitCode}`,
);
+
+ this.sessionExited.fire(session);
+} else if (isEvent(message, "capabilities")) {
+ this.sessionGotCapabili
@@ -39,6 +45,9 @@ export class DebugSessionTracker
private modulesChanged = new vscode.EventEmitter<
vscode.DebugSession | undefined
>();
+ private sessionGotCapabilities =
eronnen wrote:
changed to `sessionReceivedCapabilities` is it ok?
And I don't
@@ -0,0 +1,89 @@
+//===-- ModuleSymbolsRequestHandler.cpp -===//
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.
@@ -46,6 +46,10 @@ ConfigurationDoneRequestHandler::Run(const
ConfigurationDoneArguments &) const {
// may have different capabilities than the final target.
SendTargetBasedCapabilities(dap);
+ /// Send custom capabilities to the client.
+ /// This is consumed by the ll
@@ -85,6 +85,12 @@ class LLDB_API SBSymbol {
SymbolType GetType();
+ /// Get the ID of this symbol, usually the original symbol table index. .
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/153836
@@ -0,0 +1,90 @@
+import type { CellComponent, ColumnDefinition } from "tabulator-tables";
+import type { DAPSymbolType } from ".."
+
+function get_tabulator_hexa_formatter(padding: number): (cell: CellComponent)
=> string {
+ return (cell: CellComponent) => {
+const val = c
@@ -981,6 +981,23 @@ struct WriteMemoryResponseBody {
};
llvm::json::Value toJSON(const WriteMemoryResponseBody &);
+struct DAPGetModuleSymbolsArguments {
+ /// The module UUID for which to retrieve symbols.
+ std::optional moduleId;
+
+ /// The module path.
+ std::optiona
@@ -0,0 +1,90 @@
+import type { CellComponent, ColumnDefinition } from "tabulator-tables";
+import type { DAPSymbolType } from ".."
+
+function get_tabulator_hexa_formatter(padding: number): (cell: CellComponent)
=> string {
+ return (cell: CellComponent) => {
+const val = c
@@ -259,19 +266,40 @@
{
"command": "lldb-dap.modules.copyProperty",
"title": "Copy Value"
+ },
+ {
+"command": "lldb-dap.modules.showSymbols",
+"title": "Show Module Symbols"
+ },
+ {
+"category": "lldb-dap",
+
@@ -0,0 +1,14 @@
+export {};
+
+/// The symbol type we get from the lldb-dap server
+export type DAPSymbolType = {
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
ll
@@ -0,0 +1,185 @@
+import * as vscode from "vscode";
+import { DebugProtocol } from "@vscode/debugprotocol";
+
+import { DebugSessionTracker } from "../debug-session-tracker";
+import { DisposableContext } from "../disposable-context";
+
+import { DAPSymbolType } from "..";
+
+exp
@@ -981,6 +981,23 @@ struct WriteMemoryResponseBody {
};
llvm::json::Value toJSON(const WriteMemoryResponseBody &);
+struct DAPGetModuleSymbolsArguments {
+ /// The module UUID for which to retrieve symbols.
+ std::optional moduleId;
eronnen wrote:
:100:
@@ -29,11 +29,15 @@
],
"devDependencies": {
"@types/node": "^18.19.41",
+"@types/tabulator-tables": "^6.2.10",
"@types/vscode": "1.75.0",
+"@types/vscode-webview": "^1.57.5",
"@vscode/debugprotocol": "^1.68.0",
"@vscode/vsce": "^3.2.2",
+"esbu
@@ -0,0 +1,185 @@
+import * as vscode from "vscode";
+import { DebugProtocol } from "@vscode/debugprotocol";
+
+import { DebugSessionTracker } from "../debug-session-tracker";
+import { DisposableContext } from "../disposable-context";
+
+import { DAPSymbolType } from "..";
+
+exp
@@ -21,7 +21,7 @@
#include
#include
-namespace lldb_dap::protocol {
+namespace lldb_dap::protocol::dap {
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-c
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -981,6 +981,23 @@ struct WriteMemoryResponseBody {
};
llvm::json::Value toJSON(const WriteMemoryResponseBody &);
+struct DAPGetModuleSymbolsArguments {
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/pull/153836
@@ -594,6 +594,17 @@ class CancelRequestHandler : public
RequestHandler> {
+public:
+ using RequestHandler::RequestHandler;
+ static llvm::StringLiteral GetCommand() { return "dapGetModuleSymbols"; }
eronnen wrote:
:100:
https://github.com/llvm/llvm-project/
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -981,6 +981,23 @@ struct WriteMemoryResponseBody {
};
llvm::json::Value toJSON(const WriteMemoryResponseBody &);
+struct DAPGetModuleSymbolsArguments {
+ /// The module UUID for which to retrieve symbols.
+ std::optional moduleId;
eronnen wrote:
I wanted
@@ -48,6 +48,38 @@ struct SourceLLDBData {
bool fromJSON(const llvm::json::Value &, SourceLLDBData &, llvm::json::Path);
llvm::json::Value toJSON(const SourceLLDBData &);
+struct DAPSymbol {
+ /// The symbol uid.
+ uint32_t userId;
+
+ /// True if this symbol is debug infor
@@ -48,6 +48,38 @@ struct SourceLLDBData {
bool fromJSON(const llvm::json::Value &, SourceLLDBData &, llvm::json::Path);
llvm::json::Value toJSON(const SourceLLDBData &);
+struct DAPSymbol {
+ /// The symbol uid.
+ uint32_t userId;
eronnen wrote:
it's the i
@@ -48,6 +48,38 @@ struct SourceLLDBData {
bool fromJSON(const llvm::json::Value &, SourceLLDBData &, llvm::json::Path);
llvm::json::Value toJSON(const SourceLLDBData &);
+struct DAPSymbol {
eronnen wrote:
:100: added the namespace
https://github.com/llvm/ll
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/153836
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen approved this pull request.
https://github.com/llvm/llvm-project/pull/153317
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/148061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
eronnen wrote:
@JDevlieghere Pinging in case you still would like to review :grimacing:
https://github.com/llvm/llvm-project/pull/148061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-com
eronnen wrote:
@jimingham I updated the PR to use the suggested `BreakpointCreateByName`
instead of the address resolver, add `m_offset_is_insn_count` and check the
disassemble result for errors when resolving with `m_offset_is_insn_count ==
true`
https://github.com/llvm/llvm-project/pull/148
eronnen wrote:
> From the issue, we can have persistent assembly source breakpoint if it is
> set from the disassembly view.
>
> We only create sourceReference and virtual disassembly file if there is no
> source file for that frame.
>
> we can store the necessary information in the adapter d
eronnen wrote:
@jimingham
I don't know if the `instructions_offset` parameter can be useful for other use
cases, but in order to resolve assembly breakpoints in future sessions under
the given protocol constraints I don't see another way .
In the Debug Adapter Protocol the only persistent da
@@ -737,6 +738,11 @@ class LLDB_API SBTarget {
lldb::SBBreakpoint BreakpointCreateBySBAddress(SBAddress &address);
+ lldb::SBBreakpoint
+ BreakpointCreateByFileAddress(const SBFileSpec &file_spec, addr_t file_addr,
+addr_t offset = 0,
+
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/148061
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/148061
>From c9fc191e93381b90b67d72799bab1b9ea19b8c42 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 17 May 2025 23:49:10 +0200
Subject: [PATCH 01/19] [lldb-dap] Support persistent assembly breakpoints
---
lldb
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/142275
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/140470
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/142275
>From 7d256c09cd9dbefb35fc852450b38943f5040777 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 31 May 2025 12:30:13 +0200
Subject: [PATCH] Adding const modifier to SBAddress methods
---
lldb/include/lldb/
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/142275
I don't know if adding `const` specifier is considered breaking the API, but if
not it could be useful as it allows for `lldb-dap` to change some objects to
`const &`
>From 85e5ac0369b3d2cb263b82912af90762545c
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/142259
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/142259
None
>From 8f7b6fc7f4bba8b6efe7912557d98c5e9fd634c3 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sat, 31 May 2025 09:29:01 +0200
Subject: [PATCH] fix PATH_MAX missing in windows build
---
lldb/tools/lldb-d
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 87cf6aee70458b0e9bbc717ee9a5cf9b91b6242a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/8] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/eronnen closed
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 01/12] Reuse creation of Source objects for assembly and
normal sou
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 01/11] Reuse creation of Source objects for assembly and
normal sou
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/140470
>From 2caa403bd34f132198d4e531129529d86d5ae2e9 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Sun, 18 May 2025 20:56:47 +0200
Subject: [PATCH 1/7] [lldb-dap] Attempt to synchronously wait for breakpoints
resol
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 01/10] Reuse creation of Source objects for assembly and
normal sou
@@ -23,15 +19,23 @@ def test_disassemble(self):
self.set_source_breakpoints(source, [line_number(source, "//
breakpoint 1")])
self.continue_to_next_stop()
-_, pc_assembly = self.disassemble(frameIndex=0)
-self.assertIn("location", pc_assembly,
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From cf84a67c669ef76ca0e5f5ec7dbc0c34a44a155a Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/9] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/8] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/eronnen deleted
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
@@ -0,0 +1,115 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
eronnen wrote:
oh, yeah I can move it
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -558,28 +559,30 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -139,15 +141,16 @@ static DisassembledInstruction
ConvertSBInstructionToDisassembledInstruction(
disassembled_inst.instruction = std::move(instruction);
- auto line_entry = addr.GetLineEntry();
+ auto source = CreateSource(addr, target);
+ auto line_entry = GetLineEn
@@ -0,0 +1,17 @@
+//===-- ProtocolUtils.cpp
-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/7] Reuse creation of Source objects for assembly and normal
sourc
eronnen wrote:
@ashgti
If these tests still won't be stable in the bots maybe #140470 could further
stabilize them
https://github.com/llvm/llvm-project/pull/141983
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/6] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From d57cd027fc66447651739fb8141c51d31688 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/5] Reuse creation of Source objects for assembly and normal
sourc
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
https://github.com/eronnen created
https://github.com/llvm/llvm-project/pull/142017
Fix TypeSCript comparison (when defining an empty config string like
`commandEscapePrefix=""` it would skip it)
>From 8632a15c5fa4a11b1a108d9b763b9241b5a2bc41 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Th
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 4c20703077eb4bbee8cfeb59022dec89d8697d83 Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal
sourc
eronnen wrote:
Currently I don't think it can live in lldb-dap, because both setting the
target and calculating the symbol context are private:
```cpp
sc.target_sp = target.GetSP();
SymbolContextItem scope = static_cast(resolve_scope);
if (m_opaque_up->IsVal
eronnen wrote:
Looking at the `SBTarget::ResolveSymbolContextForAddress()` implementation it
won't apply source maps correctly because it doesn't set the target to the
symbol context at any point. in order to apply the source maps you must have
`sc.target_sp
@@ -58,6 +59,9 @@ class LLDB_API SBAddress {
// "lldb::SBAddress SBTarget::ResolveLoadAddress (...)".
lldb::SBSymbolContext GetSymbolContext(uint32_t resolve_scope);
+ lldb::SBSymbolContext GetSymbolContext(const SBTarget &target,
+
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/4] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen updated
https://github.com/llvm/llvm-project/pull/141426
>From 79a0a7b83360a517b090dad297ccb5a5a7849d0f Mon Sep 17 00:00:00 2001
From: Ely Ronnen
Date: Wed, 21 May 2025 23:39:56 +0200
Subject: [PATCH 1/3] Reuse creation of Source objects for assembly and normal
sourc
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -317,6 +317,8 @@ struct Source {
std::optional presentationHint;
// unsupported keys: origin, sources, adapterData, checksums
+
+ bool IsAssemblySource() const { return sourceReference.value_or(0) != 0; }
eronnen wrote:
:100:
https://github.com/llvm
@@ -558,28 +558,38 @@ protocol::Source CreateAssemblySource(const
lldb::SBTarget &target,
return source;
}
-bool ShouldDisplayAssemblySource(
-const lldb::SBLineEntry &line_entry,
-lldb::StopDisassemblyType stop_disassembly_display) {
- if (stop_disassembly_display
@@ -252,4 +252,11 @@ std::string GetSBFileSpecPath(const lldb::SBFileSpec
&file_spec) {
return path;
}
+lldb::SBLineEntry GetLineEntryForAddress(lldb::SBTarget &target,
+ lldb::SBAddress &address) {
+ lldb::SBSymbolContext sc =
+
@@ -250,14 +252,16 @@ protocol::Source CreateSource(const lldb::SBFileSpec
&file);
/// Create a "Source" JSON object as described in the debug adapter definition.
///
-/// \param[in] line_entry
-/// The LLDB line table to use when populating out the "Source"
-/// obje
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/eronnen edited
https://github.com/llvm/llvm-project/pull/141426
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 361 matches
Mail list logo
