[Lldb-commits] [lldb] [lldb-dap] Show load addresses in disassembly (PR #136755)

2025-04-22 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/136755 Improves the lldb-dap disassembly by showing load addresses in disassembly, same as in a regular LLDB `disassemble` command by default. Before: ![Screenshot From 2025-04-22 21-33-56](https://github.com/user-a

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
@@ -163,6 +163,25 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) { + std::string stop_disassembly_display = "no-debuginfo"; // default value + lldb::SBCommandReturnObj

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 11e5a1b7cd10f722455efdc49adc24ed277f3dfc Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/4] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen deleted https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
@@ -163,6 +163,25 @@ GetEnvironmentFromArguments(const llvm::json::Object &arguments) { return envs; } +std::string GetStopDisassemblyDisplay(lldb::SBDebugger &debugger) { + std::string stop_disassembly_display = "no-debuginfo"; // default value eronnen wr

[Lldb-commits] [lldb] [lldb-dap] Show assembly depending on `stop-disassembly-display` settings (PR #136494)

2025-04-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number x64 (PR #136486)

2025-04-21 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/136486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Ely Ronnen via lldb-commits
eronnen wrote: Maybe this setting should be exposed in the vscode launch configuration so it will be more findable for users though https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://list

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 0bf4cfcbd1fe2a006a68cb6f85af9a09a49b47e7 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/3] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/136494 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Ely Ronnen via lldb-commits
eronnen wrote: I refactored the code now to use the `stop-assembly-display` setting, I think it makes sense to use it especially since it support the `no-source` value which was what I was looking for https://github.com/llvm/llvm-project/pull/136494

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From 0bf4cfcbd1fe2a006a68cb6f85af9a09a49b47e7 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH 1/3] fallback to assembly when source code is not available --- ll

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Ely Ronnen via lldb-commits
eronnen wrote: @jasonmolenda fair enough, but still as a user who would like to see assembly instead of an error when the source is not available I don't have any solution currently. If I were to check the `stop-disassembly-display` value when returning the source info, would that be acceptab

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number (PR #136486)

2025-04-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen edited https://github.com/llvm/llvm-project/pull/136486 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/136494 >From c7da2d8281823d689b85bc836f3ed947857aaa32 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 20 Apr 2025 17:07:09 +0200 Subject: [PATCH] fallback to assembly when source code is not available --- lldb/t

[Lldb-commits] [lldb] fallback to assembly when source code is not available (PR #136494)

2025-04-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/136494 Show assembly code when the source code for a frame is not available in the debugger machine Fix #136492 After the fix: [Screencast From 2025-04-20 18-00-30.webm](https://github.com/user-attachments/assets/1

[Lldb-commits] [lldb] [lldb-dap] fix wrong assembly line number (PR #136486)

2025-04-20 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/136486 Fix wrong assembly line number calculation that assumes the instruction size is `GetAddressByteSize() / 2` >From 0efcbcfa2383e8ffac29904af90313f04bcdfa4a Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 2

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-17 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/135565 >From 04e503abe160bc6a9214ad1f345ef90be1e8c7e0 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 13 Apr 2025 20:46:56 +0200 Subject: [PATCH 1/3] [lldb] returning command completions up to a maximum - Adding

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-17 Thread Ely Ronnen via lldb-commits
@@ -230,6 +232,9 @@ class SymbolCompleter : public Completer { // Now add the functions & symbols to the list - only add if unique: for (const SymbolContext &sc : sc_list) { +if (m_match_set.size() >= m_request.GetMaxNumberOfResultsToAdd())

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-15 Thread Ely Ronnen via lldb-commits
eronnen wrote: @JDevlieghere Revoled comments and added the `test_expr_completion_max_results` test https://github.com/llvm/llvm-project/pull/135565 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listi

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-15 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/135565 >From 79e1ae6ac953ab5d3e1eb3dae75745a01d7d7a56 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 13 Apr 2025 20:46:56 +0200 Subject: [PATCH 1/2] [lldb] returning command completions up to a maximum - Adding

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-13 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen updated https://github.com/llvm/llvm-project/pull/135565 >From 66333e243f22ca68e85dea1fe3c26b02203df975 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 13 Apr 2025 20:46:56 +0200 Subject: [PATCH] [lldb] returning command completions up to a maximum - Adding `max

[Lldb-commits] [lldb] [lldb] returning command completions up to a maximum (PR #135565)

2025-04-13 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/135565 - Adding `max_return_elements` field to `CompletionRequest`. - adding maximum checks to `SymbolCompleter` and `SourceFileCompleter`. Fixes #135553 >From 1b45ab684446f2ff67c8ab89d00422ffcf2f7734 Mon Sep 17 00:00

[Lldb-commits] [lldb] [lldb-dap] fix inconsistent debugAdapterHostname argument name (PR #135544)

2025-04-13 Thread Ely Ronnen via lldb-commits
https://github.com/eronnen created https://github.com/llvm/llvm-project/pull/135544 the argument is written as `debugAdapterHostname` in package.json but used as `debugAdapterHost` >From 2428391183090dd68a5433b8c3a89bf8ad326625 Mon Sep 17 00:00:00 2001 From: Ely Ronnen Date: Sun, 13 Apr 2025