[Lldb-commits] [PATCH] D159076: [lldb] Add DynamicLoader for FreeBSD Kernel post-mortem debug facility

emaste added inline comments. Comment at: lldb/source/Plugins/DynamicLoader/FreeBSD-Kernel/DynamicLoaderFreeBSDKernel.cpp:115-116 +// TODO: If we need to check unknow OS triple like armv7-unknown-unknown? +// TODO: I don't know if kFreeBSD is a type of FreeBSD and should

[Lldb-commits] [PATCH] D150032: [lldb, NetBSD] getValue => operator* for Optional migration

emaste added a comment. Herald added a subscriber: JDevlieghere. > because Phabricator is a PoS that converts patches to useless diffs FWIW the Phorge folks have taken an interest in these sorts of complaints brought by the FreeBSD community, e.g. https://we.phorge.it/Q46, https://we.phorge.it/

[Lldb-commits] [PATCH] D147300: [lldb] Fix build on older FreeBSD

emaste accepted this revision. emaste added a comment. In D147300#4236033 , @dim wrote: > LGTM, but if such SIGFPE's occur before the FPE_FLTIDO define was introduced, > can they ever have value 9? This is essentially a compile-time assertion to make su

[Lldb-commits] [PATCH] D146222: [lldb] Add compile time checks for signal codes when on the matching platform

emaste added inline comments. Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:14-16 +#ifndef SEGV_BNDERR +#define SEGV_BNDERR 3 +#endif I'm curious what this is for; we don't use it below? Repository: rG LLVM Github Monorepo CHANGES SINCE

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

emaste added a comment. FreeBSD LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146044/new/ https://reviews.llvm.org/D146044 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D146044: [lldb] Implement CrashReason using UnixSignals

emaste added inline comments. Comment at: lldb/source/Plugins/Process/Utility/FreeBSDSignals.cpp:20 + // SIGILL + AddSignalCode(4, 1 /*ILL_ILLOPC*/, "illegal instruction"); + AddSignalCode(4, 2 /*ILL_ILLOPN*/, "illegal instruction operand"); FreeBSD comment us

[Lldb-commits] [PATCH] D135030: [lldb] [gdb-remote] Abstract sending ^c packet into SendCtrlC() method

emaste added a comment. Maybe we want to call it SendInterrupt? Looks fine to me as a minor tidy-up either way. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D135030/new/ https://reviews.llvm.org/D135030 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D131075: [lldb] [gdb-remote] Send interrupt packets from async thread

emaste added a comment. With D131159 and D131160 in, where does that leave us wrt this change? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D131075/new/ https://reviews.llvm.org

[Lldb-commits] [PATCH] D126615: [lldb] Add an integration test for non-stop protocol

emaste added a comment. Looks reasonable to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D126615/new/ https://reviews.llvm.org/D126615 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

emaste added inline comments. Herald added a project: All. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp:128 + +#ifdef NT_ARM_ADDR_MASK + if (m_addr_mask_is_valid) andrew wrote: > emaste wrote: > > This `#define` is comi

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

emaste added a comment. We need to make sure a test covers this as well, perhaps just enabling lldb/test/API/functionalities/unwind/aarch64_unwind_pac/TestAArch64UnwindPAC.py? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D120485/new/ https://revie

[Lldb-commits] [PATCH] D120485: [lldb][Process/FreeBSD] Add support for address masks on aarch64

emaste added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSD/NativeRegisterContextFreeBSD_arm64.cpp:128 + +#ifdef NT_ARM_ADDR_MASK + if (m_addr_mask_is_valid) This `#define` is coming from our headers? We need to provide this constant within L

[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

emaste added a comment. ping CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90876/new/ https://reviews.llvm.org/D90876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D114967: [lldb] [Process/elf-core] Disable for FreeBSD vmcores

emaste added inline comments. Comment at: lldb/source/Plugins/Process/elf-core/ProcessElfCore.cpp:67 if (elf_header.Parse(data, &data_offset)) { +// Check whether we're dealing with a FreeBSD vmcore that needs +// to be handled via FreeBSDKernel plugin inst

[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

emaste accepted this revision. emaste added a comment. Fine with me, or maybe "A test for Darwin- (and prehaps Windows-)specific behavior." CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90876/new/ https://reviews.llvm.org/D90876 ___ lldb-com

[Lldb-commits] [PATCH] D110545: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test

This revision was automatically updated to reflect the committed changes. Closed by commit rG993ada05f5a0: [lldb] [unittests] Fix building the FreeBSD arm64 Register Context test (authored by andrew, committed by emaste). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D107475: [lldb] [gdb-remote] Use hexadecimal numbers in vFile packets for GDB compliance

emaste added a comment. LGTM, although in FreeBSD we don't have any backwards- or cross-compatibility issues to worry about. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107475/new/ https://reviews.llvm.org/D107475 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D101893: [Process/elf-core] Read PID from FreeBSD prpsinfo

emaste added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101893/new/ https://reviews.llvm.org/D101893 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D101086: [lldb] [Process/elf-core] Fix reading FPRs from FreeBSD/i386 cores

emaste added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D101086/new/ https://reviews.llvm.org/D101086 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D97230: [lldb] [test] Workaround symlink-related test failures

emaste added a comment. OK; I think this change is reasonable, I just want to make sure we don't completely lose the underlying issue. Let's make sure that we at least have a bug report to track it (i.e., let's not close llvm.org/pr48376 and llvm.org/pr48421 with "no longer fails" without havi

[Lldb-commits] [PATCH] D97210: [lldb] Rename NativeRegisterContext{Watchpoint => DBReg}_x86

emaste added a comment. No objection from me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97210/new/ https://reviews.llvm.org/D97210 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/ll

[Lldb-commits] [PATCH] D96548: [lldb] [Process/FreeBSDRemote] Introduce aarch64 hw break/watchpoint support

emaste added a comment. > I don't think it's very likely. @emaste, any opinion on this? I think it is fine to make this conditional on version. We are working on bringing arm64 to Tier-1 status in FreeBSD 13 (which will have the referenced kernel changes) and we can assume that as a minimum ver

[Lldb-commits] [PATCH] D97230: [lldb] [test] Workaround symlink-related test failures

emaste added a comment. I think it's valuable to avoid testing this (symlink issue) as a side effect of these test cases, but we should have an explicit test for this; it is an issue users could hit. Do you know if this is a bug specific to lldb's FreeBSD code (or do we just have a default sym

[Lldb-commits] [PATCH] D97114: [lldb] [docs] Update platform support status

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. FreeBSD changes LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D97114/new/ https://reviews.llvm.org/D97114 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D96555: [lldb] Remove the legacy FreeBSD plugin

emaste added inline comments. Comment at: lldb/tools/lldb-server/CMakeLists.txt:13 if(CMAKE_SYSTEM_NAME MATCHES "FreeBSD") - list(APPEND LLDB_PLUGINS -lldbPluginProcessFreeBSDRemote -lldbPluginProcessFreeBSD) + list(APPEND LLDB_PLUGINS lldbPluginProcessFreeBSDRemote)

[Lldb-commits] [PATCH] D96555: [lldb] Remove the legacy FreeBSD plugin

emaste added a comment. Not sure if you're missing something, but removing the old plugin LGTM Comment at: lldb/tools/lldb-server/CMakeLists.txt:13 if(CMAKE_SYSTEM_NAME MATCHES "FreeBSD") - list(APPEND LLDB_PLUGINS -lldbPluginProcessFreeBSDRemote -lldbPluginProcessFre

[Lldb-commits] [PATCH] D95297: [lldb] [Process/FreeBSDRemote] Introduce arm64 support

emaste added a comment. In D95297#2532026 , @mgorny wrote: > lldb-server. We're aiming towards removing the native plug-in soon. To add a little background, the FreeBSD Foundation is funding this effort to move all FreeBSD targets to lldb-server; amd64 a

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

emaste added inline comments. Comment at: lldb/source/Plugins/Process/POSIX/CrashReason.cpp:62 +#ifndef SEGV_MTEAERR +#define SEGV_MTEAERR 8 +#endif pcc wrote: > emaste wrote: > > emaste wrote: > > > This should perhaps include an `#ifdef LINUX`(sp?) somehow, sin

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

emaste added inline comments. Comment at: lldb/source/Plugins/Process/POSIX/CrashReason.cpp:62 +#ifndef SEGV_MTEAERR +#define SEGV_MTEAERR 8 +#endif emaste wrote: > This should perhaps include an `#ifdef LINUX`(sp?) somehow, since 8 and 9 are > not necessarily M

[Lldb-commits] [PATCH] D93495: CrashReason: Add MTE tag check faults to the list of crash reasons.

emaste added inline comments. Comment at: lldb/source/Plugins/Process/POSIX/CrashReason.cpp:62 +#ifndef SEGV_MTEAERR +#define SEGV_MTEAERR 8 +#endif This should perhaps include an `#ifdef LINUX`(sp?) somehow, since 8 and 9 are not necessarily MTEAERR / MTESERR o

[Lldb-commits] [PATCH] D92264: [lldb] [POSIX-DYLD] Update the cached exe path after attach

emaste added a comment. Seems reasonable to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92264/new/ https://reviews.llvm.org/D92264 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/

[Lldb-commits] [PATCH] D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Ah, of course. SGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92667/new/ https://reviews.llvm.org/D92667 ___ lldb-commits mailing lis

[Lldb-commits] [PATCH] D92667: [lldb] [Platform/POSIX] Use gdb-remote plugin when attaching

emaste added a comment. No objection here. I'm curious why the two modified tests work on Linux or NetBSD today though? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92667/new/ https://reviews.llvm.org/D92667 ___ lldb-commits mailing list ll

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

emaste added a comment. > One thing that FreeBSD should do, is to upgrade to the protocol version 1 > (stored in r_version), like Linux, NetBSD and OpenBSD. It looks like Linux has always used r_version=1 (since 1995). AFAICT we can just add r_ldbase and set version to 1. See https://reviews.fr

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

emaste added a comment. > One thing that FreeBSD should do, is to upgrade to the protocol version 1 > (stored in r_version), like Linux, NetBSD and OpenBSD. It looks like Linux has always used r_version=1 (since 1995). AFAICT we can just add r_ldbase and set version to 1. CHANGES SINCE LAST A

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

emaste added a comment. Link to Linux info: https://sourceware.org/gdb/wiki/LinkerInterface CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/D92187 ___ lldb-commits mailing list lldb-commits@lists.llvm.org htt

[Lldb-commits] [PATCH] D92187: [lldb] [FreeBSD] Fix establishing DT_NEEDED libraries from dyld

emaste added a subscriber: bsdjhb. emaste added a comment. I'm curious how gdb handles this, and asked @bsdjhb if he knows off hand. Is there a brief description of how this works on Linux and/or NetBSD? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92187/new/ https://reviews.llvm.org/

[Lldb-commits] [PATCH] D92314: [lldb] [Process/FreeBSDRemote] Implement GetLoadedModuleFileSpec() and GetFileLoadAddress()

emaste added a comment. No objection, but maybe add a comment explaining the status of this implementation? Does/will NetBSD do the same? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D92314/new/ https://reviews.llvm.org/D92314 ___ lldb-commi

[Lldb-commits] [PATCH] D91810: [lldb] [Process/FreeBSD] Fix 'process connect' plugin choice

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Looks ok to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91810/new/ https://reviews.llvm.org/D91810 ___ lldb-commits mailing list lldb

[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

emaste added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:19 -@expectedFailureAll(archs=['i386'], bugnumber="rdar://28656532") +@expectedFailureAll(archs=['i386'], +oslist=no_match(["freebsd"]), lab

[Lldb-commits] [PATCH] D91645: [lldb] [test] Un-XFAIL tests on freebsd/i386

emaste added inline comments. Comment at: lldb/test/API/functionalities/exec/TestExec.py:19 -@expectedFailureAll(archs=['i386'], bugnumber="rdar://28656532") +@expectedFailureAll(archs=['i386'], +oslist=no_match(["freebsd"]), Int

[Lldb-commits] [PATCH] D91065: [lldb] [test] Rename '.categories' to 'categories'

emaste added a comment. No objection from me but I haven't been sufficiently involved in lldb's tests to approve. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91065/new/ https://reviews.llvm.org/D91065 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D91076: [lldb] [Process/FreeBSDRemote] Correct DS/ES/FS/GS register sizes

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Agree that even if refactoring is needed correcting these makes sense. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D91076/new/ https://reviews.llvm.org/D91076 __

[Lldb-commits] [PATCH] D91003: [lldb] [test] Use skipUnlessDarwin for tests specific to Darwin

emaste added a comment. > In theory Obj-C is available on other systems Yes, in particular it should be possible on FreeBSD. I agree that an Obj-C-specific decorator would be best but it's a very low priority. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.l

[Lldb-commits] [PATCH] D90876: [lldb] [test] Improve comment on expr-after-step-after-crash tests

emaste added a comment. How does Windows fit into this? Other than that Q, LGTM. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90876/new/ https://reviews.llvm.org/D90876 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.

[Lldb-commits] [PATCH] D90863: [lldb] [Process/FreeBSDRemote] Remove thread name caching

emaste added a comment. Does Linux fetch each time also? I agree it's probably not worth the effort. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D90863/new/ https://reviews.llvm.org/D90863 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

emaste added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:955 -# Don't do lldb-server (llgs) tests on anything except Linux and Windows. +# Don't do lldb-server (llgs) tests on platforms not supporting it. configuration.dont_do_llgs_te

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

emaste accepted this revision. emaste added a comment. > What do you suggest? Is it fine to go with my results for as long as I work > on it? I can update it to match CI/buildbot results later. Yes absolutely. I pasted my results mainly as an FYI/for comparison, since I recall there were many i

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

emaste added a comment. When running locally with this change applied I get: Failed Tests (8): lldb-api :: commands/expression/multiline-completion/TestMultilineCompletion.py lldb-api :: functionalities/breakpoint/breakpoint_set_restart/TestBreakpointSetRestart.

[Lldb-commits] [PATCH] D90757: [lldb] Enable FreeBSDRemote plugin by default and update test status

emaste added a comment. I added comments in the now-dereferenced bugs linking back to this review - most of them were submitted by me, and I'll double check and close them once this lands. One minor update needed (restoring a comment that was partially deleted) Comment at: l

[Lldb-commits] [PATCH] D90454: [lldb] [Host/{free, net}bsd] Fix process matching by name

emaste added a comment. There is TestProcessAttach.py that has an @expectedFailureNetBSD but no FreeBSD annotation, as well as TestCompletion.py, but I don't see these in the failing list. `process attach -n foo` does fail for me on FreeBSD CHANGES SINCE LAST ACTION https://reviews.llvm.org

[Lldb-commits] [PATCH] D89859: Remove .svn from exclude list as we moved to git

emaste added a comment. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89859/new/ https://reviews.llvm.org/D89859 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-

[Lldb-commits] [PATCH] D89413: [lldb] [Process/FreeBSDRemote] Initial multithreading support

emaste added a comment. Looks fine to me CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89413/new/ https://reviews.llvm.org/D89413 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D89248: [lldb] [test/Register] Add read/write tests for multithreaded process

emaste added a comment. Looks reasonable to me and currently fails (as expected) on FreeBSD. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D89248/new/ https://reviews.llvm.org/D89248 ___ lldb-commits mailing list lldb-commits@lists.llvm.org ht

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

emaste added inline comments. Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:448-449 + +assert(info.xsave_mask & XFEATURE_ENABLED_X87); +assert(info.xsave_mask & XFEATURE_ENABLED_SSE); + mgorny wrote: > mgor

[Lldb-commits] [PATCH] D89193: [lldb] [Process/FreeBSDRemote] Support YMM reg via PT_*XSTATE

emaste added a comment. Looks OK Comment at: lldb/source/Plugins/Process/FreeBSDRemote/NativeRegisterContextFreeBSD_x86_64.cpp:448-449 + +assert(info.xsave_mask & XFEATURE_ENABLED_X87); +assert(info.xsave_mask & XFEATURE_ENABLED_SSE); + I wonder if the

[Lldb-commits] [PATCH] D88453: [lldb] Fix FreeBSD Arm Process Plugin build.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rGf794160c6cb7: [lldb] Fix FreeBSD Arm Process Plugin build (authored by emaste). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION h

[Lldb-commits] [PATCH] D77241: update eArgTypeScriptLang description to mention lua

This revision was automatically updated to reflect the committed changes. Closed by commit rG55e32e92cda7: [lldb] update eArgTypeScriptLang description to mention lua (authored by emaste). Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Repository: rG LLVM Github Monorepo

[Lldb-commits] [PATCH] D77241: update eArgTypeScriptLang description to mention lua

emaste updated this revision to Diff 254369. emaste added a comment. reword CHANGES SINCE LAST ACTION https://reviews.llvm.org/D77241/new/ https://reviews.llvm.org/D77241 Files: lldb/source/Interpreter/CommandObject.cpp Index: lldb/source/Interpreter/CommandObject.cpp ===

[Lldb-commits] [PATCH] D77241: update eArgTypeScriptLang description to mention lua

emaste created this revision. emaste added a reviewer: JDevlieghere. `--script-language python` and `--script-language lua` are now valid I went with lowercase to match the args https://reviews.llvm.org/D77241 Files: lldb/source/Interpreter/CommandObject.cpp Index: lldb/source/Interpreter/

[Lldb-commits] [PATCH] D32167: Add support for type units (.debug_types) to LLDB in a way that is compatible with DWARF 5

emaste added inline comments. Comment at: packages/Python/lldbsuite/test/make/Makefile.rules:197 +ifeq "$(DWARF_TYPE_UNITS)" "YES" + DEBUG_INFO_FLAG ?= -gdwarf-4 +else clayborg wrote: > aprantl wrote: > > This shouldn't be necessary on any platform LLDB car

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

This revision was automatically updated to reflect the committed changes. Closed by commit rL312431: Add test case for attach-by-pid from different cwd (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D32522?vs=113067&id=113671#toc Repository: rL LLVM https://reviews.

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

This revision was automatically updated to reflect the committed changes. Closed by commit rL312430: FreeBSD: attach to pid from different cwd (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D32271?vs=113664&id=113669#toc Repository: rL LLVM https://reviews.llvm.org/

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

emaste updated this revision to Diff 113664. emaste added a comment. correct variable https://reviews.llvm.org/D32271 Files: source/Host/freebsd/Host.cpp Index: source/Host/freebsd/Host.cpp === --- source/Host/freebsd/Host.cpp

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

emaste added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:44 +"""Test attach by process id""" +os.mkdir(os.path.join(os.getcwd(),'newdir')) + self.buildProgram('main.cpp',os.path.join(os.g

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

emaste added a comment. Testing this just now I got: FAIL: LLDB (/usr/bin/cc-x86_64) :: test_attach_to_process_from_different_dir_by_id (TestProcessAttach.ProcessAttachTestCase) == ERROR: test_attach_to_process

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

This revision was automatically updated to reflect the committed changes. Closed by commit rL311002: Make i386-*-freebsd expression work on JIT path (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D34776?vs=104984&id=111331#toc Repository: rL LLVM https://reviews.llv

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

emaste added a comment. Ping for two open questions https://reviews.llvm.org/D32522 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

This revision was automatically updated to reflect the committed changes. Closed by commit rL310591: Report inferior signals as signals, not exceptions, on FreeBSD (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D35223?vs=110438&id=110572#toc Repository: rL LLVM http

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

emaste accepted this revision. emaste added a comment. This revision is now accepted and ready to land. Still would appreciate diffs uploaded with full context - i.e., Note that you can upload patches created through various diff tools, including git and svn. To make reviews easier, please alw

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

emaste added a comment. I've committed this to FreeBSD's copy of lldb in r322326 . @labath if you're happy with this patch I will commit to lldb for @karnajitw. I'm not sure how the patch ended up with a conflict, but it's just a whitespace issue. https:/

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

emaste added a comment. > Actually, I think you probably need to extend the @skipIfLinux to apply to > freebsd as well. Oh, I mistook the source of the check_stop_reason assertion failure -- I thought it was asserting before the step. In this case I agree the test should be skipped on FreeBSD.

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

emaste added a comment. With this patch i386 test results are comparable to amd64, and I'm happy with it from a FreeBSD perspective (modulo the PlatformOpenBSD patch conflict). https://reviews.llvm.org/D34776 ___ lldb-commits mailing list lldb-comm

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

emaste added a comment. The change in PlatformOpenBSD.cpp failed to apply for me (although it was trivial to manually apply it). https://reviews.llvm.org/D34776 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

emaste added a comment. With this patch I observed three new failures on FreeBSD and three new unexpected passes on FreeBSD. An example of a new failure: == FAIL: test_inferior_crashing_expr_step_and_expr_dwarf (TestInferio

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

emaste added a comment. The patch LGTM, I will test it soon. Repository: rL LLVM https://reviews.llvm.org/D35223 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D35223: Report inferior SIGSEGV/SIGILL/SIGBUS/SIGFPE as a signal instead of an exception on freebsd

emaste added a comment. Sorry I missed this when first uploaded, I will look at it shortly. For future uploads can you kindly include full context, as described in https://llvm.org/docs/Phabricator.html? Repository: rL LLVM https://reviews.llvm.org/D35223

[Lldb-commits] [PATCH] D34776: Make i386-*-freebsd expression work on JIT path

emaste added a comment. Sorry I missed this when first uploaded, I will look at it shortly. For future uploads can you kindly include full context, as described in https://llvm.org/docs/Phabricator.html? https://reviews.llvm.org/D34776 ___ lldb-co

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

emaste accepted this revision. emaste added a comment. LGTM from the FreeBSD side. The launch code for FreeBSD came from the original (in-process) implementation that Linux and FreeBSD shared. https://reviews.llvm.org/D34236 ___ lldb-commits mailin

[Lldb-commits] [PATCH] D34236: Delete ProcessLauncherPosix

emaste added a comment. FreeBSD build and test in progress. https://reviews.llvm.org/D34236 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D34274: Remove home-grown thread-local storage wrappers

emaste added a comment. Fine from FreeBSD https://reviews.llvm.org/D34274 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

emaste added a comment. Generally LGTM with two questions inline. Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:45 +os.mkdir(os.path.join(os.getcwd(),'newdir')) +self.buildProgram('main.cpp','newdir/proc_attach')

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

emaste added a comment. In https://reviews.llvm.org/D32271#759361, @dim wrote: > As I found out in https://reviews.llvm.org/rL303015, the `KERN_PROC_PATHNAME` > has one drawback: if an executable file has multiple hard links, you will get > just one of its filenames as the result. Since that f

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

emaste added a comment. Two small nits noted inline, but now the test does not pass without https://reviews.llvm.org/D32271 and does with it. Note that in the "without" case it returned error rather than failing, perhaps related to the path issue I noted? Other than that issue I think this is

[Lldb-commits] [PATCH] D32820: Parallelize demangling

emaste added a comment. > Without tcmalloc, on Ubuntu 14.04, 40 core VM: 13% > With tcmalloc, on Ubuntu 14.04, 40 core VM: 24% (built using cmake ... > -DCMAKE_EXE_LINKER_FLAGS=-ltcmalloc_minimal, which amazingly only works when > building with clang, not gcc...) Do you have a brief set of ste

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

emaste requested changes to this revision. emaste added a comment. This revision now requires changes to proceed. This test passes even without the change in https://reviews.llvm.org/D32271, presumably because `exe = os.path.join(os.getcwd(), 'newdir/proc_attach')` is providing us with an absolu

[Lldb-commits] [PATCH] D32522: Test case for the issue raised in D32271

emaste added inline comments. Comment at: packages/Python/lldbsuite/test/functionalities/process_attach/TestProcessAttach.py:43 + def test_attach_to_process_frm_different_dir_by_id(self): + """Test attach by process id""" +os.mkdir(os.path.join(os.get

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

emaste added a comment. Test case in https://reviews.llvm.org/D32522 https://reviews.llvm.org/D32271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

emaste added a comment. In https://reviews.llvm.org/D32271#735098, @krytarowski wrote: > I have plan to revisit corresponding files in NetBSD and switch from kvm(3) > to sysctl(3). But this is lower priority than Process Plugin right now. Thanks for the note. I wasn't aware that you had that p

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

emaste updated this revision to Diff 96334. emaste added a comment. Slightly simpler approach after early returns added in https://reviews.llvm.org/rL301100 https://reviews.llvm.org/D32271 Files: source/Host/freebsd/Host.cpp Index: source/Host/freebsd/Host.cpp =

[Lldb-commits] [PATCH] D32271: Patch to Attach pid successfully from different dir

emaste added a comment. Sorry I've been away from LLDB for a bit, I will take a look at this soon. Repository: rL LLVM https://reviews.llvm.org/D32271 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D32125: [LLVM][MIPS] Fix different definition of off_t in LLDB and LLVM

emaste added a comment. In https://reviews.llvm.org/D32125#728166, @krytarowski wrote: > Is this just GNU specific? BSD moved to 64-bit off_t on 32-bit platforms 20+ > years ago. > > It's perhaps no-op, but it might be noted in the commit message what > platforms are supposed to be improved.

[Lldb-commits] [PATCH] D29667: Synchronize PlatformFreeBSD with Linux

This revision was automatically updated to reflect the committed changes. Closed by commit rL294340: Synchronize PlatformFreeBSD with Linux (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D29667?vs=87482&id=87490#toc Repository: rL LLVM https://reviews.llvm.org/D2966

[Lldb-commits] [PATCH] D29667: Synchronize PlatformFreeBSD with Linux

emaste created this revision. Inspired by https://reviews.llvm.org/rL294145 (https://reviews.llvm.org/D29266) for NetBSD, this reduces diffs between the FreeBSD and Linux/NetBSD Platform implementations. Further diff reduction will occur once FreeBSD switches to using the remote process plugin.

[Lldb-commits] [PATCH] D29347: Transform ProcessLauncherLinux to ProcessLauncherPosixFork

emaste added a comment. In https://reviews.llvm.org/D29347#662503, @labath wrote: > @emaste: I'd suggest switching freebsd over to this process launcher as well. > I think it's the last user of the ProcessLauncherPosix, and it would enable > us to get rid of it. Indeed. I won't be able to loo

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

This revision was automatically updated to reflect the committed changes. Closed by commit rL292937: FreeBSD ARM support for software single step (authored by emaste). Changed prior to commit: https://reviews.llvm.org/D25756?vs=79987&id=85581#toc Repository: rL LLVM https://reviews.llvm.org

[Lldb-commits] [PATCH] D27126: Merge Linux and FreeBSD arm register contexts

emaste added a comment. In https://reviews.llvm.org/D27126#609150, @labath wrote: > In https://reviews.llvm.org/D27126#607057, @dmikulin wrote: > > > I can run tests on 32bit ARM FreeBSD 11.RC3 rpi2, but without software > > single step not a lot of tests pass on ARM FreeBSD ;) > > Can we get h

[Lldb-commits] [PATCH] D25756: FreeBSD ARM support for software single step.

emaste added inline comments. Comment at: source/Plugins/Platform/FreeBSD/PlatformFreeBSD.cpp:551-557 +} else { + static const uint8_t g_arm_breakpoint_opcode[] = {0xFE,0xDE,0xFF,0xE7}; + size_t trap_opcode_size = sizeof(g_arm_breakpoint_opcode); + assert(bp_si

[Lldb-commits] [PATCH] D27126: Merge Linux and FreeBSD arm register contexts

emaste added a subscriber: dmikulin. emaste added a comment. I think @dmikulin might be able to test this https://reviews.llvm.org/D27126 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-c

[Lldb-commits] [PATCH] D27115: [cleanup] Fix typos in file headers

emaste added a comment. I checked the FreeBSD parts, looks good. Thanks for doing this! Repository: rL LLVM https://reviews.llvm.org/D27115 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/l

  1   2   >