[Lldb-commits] [PATCH] D74255: [LLDB] Add support for AVR breakpoints

2020-02-24 Thread Dylan McKay via Phabricator via lldb-commits
dylanmckay added a comment. > However, if we look at this locally, if the AVR architecture has a trap > opcode (maybe to implement __builtin_debugbreak() -- I am assuming that's > what 0x98 0x95 is), then I don't see a problem with this function returning > it. Chiming in from an AVR perspecti

[Lldb-commits] [PATCH] D73969: [LLDB] Let DataExtractor deal with two-byte addresses

2020-02-24 Thread Dylan McKay via Phabricator via lldb-commits
dylanmckay added a comment. This looks good to me from an AVR point of view. I don't have very much experience with LLDB however. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D73969/new/ https://reviews.llvm.org/D73969 _