DhruvSrivastavaX wrote:
Please re-run clang-format on the changes.
https://github.com/llvm/llvm-project/pull/134354
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
Sure, Thanks.
I have modified my test case for this one.
Please let me know your comments. @labath
https://github.com/llvm/llvm-project/pull/131304
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.or
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/131304
>From 106e137fea7d4b420ce3d97a8df16c3a91400997 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 14 Mar 2025 02:51:21 -0500
Subject: [PATCH 1/3] Support for XCOFF Sections
---
.../ObjectFile/
@@ -6,18 +6,172 @@
//
//===--===//
+#include
+#include
+#include
+
#include "lldb/Host/Host.h"
+#include "lldb/Host/linux/Support.h"
+#include "lldb/Utility/LLDBLog.h"
+#include "lldb/Utility/Log.h"
+#inc
@@ -6,18 +6,172 @@
//
//===--===//
+#include
+#include
+#include
+
DhruvSrivastavaX wrote:
You can remove this blank line and run clang format once to keep all the
includes together in o
@@ -141,6 +141,7 @@ else()
add_host_subdirectory(aix
aix/Host.cpp
aix/HostInfoAIX.cpp
+ linux/Support.cpp
DhruvSrivastavaX wrote:
In the original draft PR, we have a copy file from linux for aix as well.
Shall we use the linux version to
DhruvSrivastavaX wrote:
Hi Team,
@HemangGadhavi from my ibm aix team will be helping me out in some of the
merging process, as per our decided guidelines. Please provide your review.
Thanks!
Dhruv Srivastava
https://github.com/llvm/llvm-project/pull/134354
___
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/131304
>From 106e137fea7d4b420ce3d97a8df16c3a91400997 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 14 Mar 2025 02:51:21 -0500
Subject: [PATCH 1/3] Support for XCOFF Sections
---
.../ObjectFile/
DhruvSrivastavaX wrote:
Sure, Thanks.
I have modified my test case for this one.
https://github.com/llvm/llvm-project/pull/131304
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX closed
https://github.com/llvm/llvm-project/pull/132718
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/132718
>From c6392f75d270467300c5cf6cdbcfae088d1e48eb Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 24 Mar 2025 06:44:24 -0500
Subject: [PATCH 1/2] Minor AIX specific changes
---
lldb/source/Hos
@@ -19,7 +19,9 @@
#include
#include
#include
+#ifndef _AIX
#include
+#endif
DhruvSrivastavaX wrote:
Done, checked compilation on linux as well.
https://github.com/llvm/llvm-project/pull/132718
___
lldb-commits
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/132718
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
https://github.com/DhruvSrivastavaX closed
https://github.com/llvm/llvm-project/pull/132712
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/132712
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
DhruvSrivastavaX wrote:
These are the previous reference commits for the xcoff support:
[ca4cd08](https://github.com/llvm/llvm-project/commit/ca4cd08fb9d7a03fbd00bca05d5dbfa87cd6db4e),
[0c68606](https://github.com/llvm/llvm-project/commit/0c6860622c249ae7adc784c66a8d0b1335a9e7df)
https://githu
DhruvSrivastavaX wrote:
Hi @labath @DavidSpickett,
So please let me know if I should add more apis in this PR or this much
granularity is enough.
Also, we are working on 32-bit implementation as well, so I am thinking of
extending the xcoff for the 32 bit as well as it should not take much
a
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
DhruvSrivastavaX wrote:
Hi, @labath @DavidSpickett,
Resuming the conversation on XCOFF support. I have added support for reading
XCOFF sections using existing LLVM interfaces. I know there are gaps, so please
let me know your thoughts.
- Just FYI, I have only added implementation in CreateSe
https://github.com/DhruvSrivastavaX closed
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/131304
>From 106e137fea7d4b420ce3d97a8df16c3a91400997 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Fri, 14 Mar 2025 02:51:21 -0500
Subject: [PATCH 1/2] Support for XCOFF Sections
---
.../ObjectFile/
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/131304
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 01/13] Added base files for NativeProcess for AIX
--
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 01/12] Added base files for NativeProcess for AIX
--
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,330 @@
+//===-- NativeProcessAIX.cpp
--===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Ap
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 01/11] Added base files for NativeProcess for AIX
--
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 01/10] Added base files for NativeProcess for AIX
--
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX deleted
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,256 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,27 @@
+//===-- source/Host/aix/Host.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
https://github.com/DhruvSrivastavaX created
https://github.com/llvm/llvm-project/pull/130582
This PR is in reference to porting LLDB on AIX.
Link to discussions on llvm discourse and github:
1. https://discourse.llvm.org/t/port-lldb-to-ibm-aix/80640
2. https://github.com/llvm/llvm-project/issu
@@ -0,0 +1,109 @@
+//===-- source/Host/aix/Host.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,119 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/130582
>From 21fe9850c99b3eae4be65ac34c1f4f9c2d06ab2c Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 10 Mar 2025 05:39:52 -0500
Subject: [PATCH 1/3] Host.cpp base for AIX
---
lldb/source/Host/CMa
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/130582
>From 21fe9850c99b3eae4be65ac34c1f4f9c2d06ab2c Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 10 Mar 2025 05:39:52 -0500
Subject: [PATCH 1/4] Host.cpp base for AIX
---
lldb/source/Host/CMa
@@ -0,0 +1,66 @@
+//===-- source/Host/aix/Host.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/130582
>From 21fe9850c99b3eae4be65ac34c1f4f9c2d06ab2c Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 10 Mar 2025 05:39:52 -0500
Subject: [PATCH 1/5] Host.cpp base for AIX
---
lldb/source/Host/CMa
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 1/9] Added base files for NativeProcess for AIX
---
DhruvSrivastavaX wrote:
@labath @DavidSpickett
I am done with the update of the files, I have compiled and checked the changes
based on your mentioned comments.
The only doubt I have is am I required to replace Status with
llvm::Error/Expected at any other places too?
Please feel free go thro
DhruvSrivastavaX wrote:
> I don't know if you have worked on LLVM before but regardless, thank you for
> making use of the nice error handling patterns we have. Even if sometimes
> they're a bit too much.
> I don't have any major problems with this, just some style points and a
> couple of th
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 1/8] Added base files for NativeProcess for AIX
---
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 1/7] Added base files for NativeProcess for AIX
---
DhruvSrivastavaX wrote:
> I started reviewing this, but I got a feeling that you did not actually push
> the changes that you made.
>
> Does the PR accurately reflect the latest version of the patch?
Hi @labath , I am in the process of making the changes. will push them together
and post a co
@@ -0,0 +1,265 @@
+//===-- NativeProcessAIX.cpp ===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/118160
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,130 @@
+//===-- NativeProcessAIX.h -- -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
DhruvSrivastavaX wrote:
I have builT the lldb-server on AIX and added the changes accordingly, so that
we can restart the review on this.
I will be handling the pending comments on this PR next.
https://github.com/llvm/llvm-project/pull/118160
___
ll
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 1/6] Added base files for NativeProcess for AIX
---
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/118160
>From 03a290e9c748540b69ca6df7fa9c4481f9cdd3d0 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 30 Nov 2024 01:14:15 -0600
Subject: [PATCH 1/5] Added base files for NativeProcess for AIX
---
https://github.com/DhruvSrivastavaX closed
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -0,0 +1,155 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,13 @@
+add_definitions("-D_ALL_SOURCE")
DhruvSrivastavaX wrote:
Done, Thanks!
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/121273
>From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 28 Dec 2024 13:19:21 -0600
Subject: [PATCH 1/7] Introducing PlatformAIX from PlatformLinux
---
@@ -0,0 +1,72 @@
+//===-- PlatformAIX.h -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/121273
>From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 28 Dec 2024 13:19:21 -0600
Subject: [PATCH 1/6] Introducing PlatformAIX from PlatformLinux
---
@@ -0,0 +1,13 @@
+add_definitions("-D_ALL_SOURCE")
DhruvSrivastavaX wrote:
For this plugin, it is there for `MAP_ANONYMOUS`
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@li
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,72 @@
+//===-- PlatformAIX.h -*- C++ -*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apache
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -8,3 +8,4 @@ add_subdirectory(OpenBSD)
add_subdirectory(POSIX)
add_subdirectory(QemuUser)
add_subdirectory(Windows)
+add_subdirectory(AIX)
DhruvSrivastavaX wrote:
Yeay! 🙂
https://github.com/llvm/llvm-project/pull/121273
___
DhruvSrivastavaX wrote:
Hi @DavidSpickett @labath , Do let me know if this can be merged now
https://github.com/llvm/llvm-project/pull/121273
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb
@@ -0,0 +1,193 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,370 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/121273
>From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 28 Dec 2024 13:19:21 -0600
Subject: [PATCH 1/5] Introducing PlatformAIX from PlatformLinux
---
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/121273
>From 16107a423e30cc339b7529db35a75c3c26924146 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Sat, 28 Dec 2024 13:19:21 -0600
Subject: [PATCH 1/4] Introducing PlatformAIX from PlatformLinux
---
@@ -0,0 +1,370 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,43 @@
+//===-- HostInfoLinux.h -*- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
DhruvSrivastavaX wrote:
Already modified and merged
https://github.com/llvm
@@ -11,11 +11,11 @@
#include "lldb/lldb-defines.h"
-#if defined(_MSC_VER)
+#if defined(_MSC_VER) || defined(__AIX__)
#define REPLACE_GETOPT
#define REPLACE_GETOPT_LONG
#endif
-#if defined(_MSC_VER) || defined(__NetBSD__)
+#if defined(_MSC_VER) || defined(__NetBSD__) || def
@@ -0,0 +1,60 @@
+//===-- Ptrace.h *- C++
-*-===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apa
@@ -55,6 +55,9 @@
#elif defined(__APPLE__)
#include "lldb/Host/macosx/HostInfoMacOSX.h"
#define HOST_INFO_TYPE HostInfoMacOSX
+#elif defined(__AIX__)
DhruvSrivastavaX wrote:
Already merged
https://github.com/llvm/llvm-project/pull/106910
_
@@ -0,0 +1,370 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
@@ -0,0 +1,370 @@
+//===-- PlatformAIX.cpp -===//
+//
+// Part of the LLVM Project, under the Apache License v2.0 with LLVM
Exceptions.
+// See https://llvm.org/LICENSE.txt for license information.
+// SPDX-License-Identifier: Apach
DhruvSrivastavaX wrote:
Okay great. Thanks for explaining that!
I'll make sure that the final story reads well. (Especially if we go from X to
!X 🙂 )
And its always a plus to add footnotes to the post-merge discussion in such
cases.
https://github.com/llvm/llvm-project/pull/122301
__
DhruvSrivastavaX wrote:
> In future, please remember to remove anything from the commit message that
> was purely for the review process, or generally no longer applies to the code
> being landed. GitHub gives you a chance to do this just before the PR is
> merged.
>
> In this case it just me
https://github.com/DhruvSrivastavaX approved this pull request.
https://github.com/llvm/llvm-project/pull/122301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX closed
https://github.com/llvm/llvm-project/pull/122301
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX closed
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/6] Some base #if _AIX changes
---
.../Host/posix/
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/5] Some base #if _AIX changes
---
.../Host/posix/
@@ -14,6 +14,7 @@
#include
#include
+#include
DhruvSrivastavaX wrote:
Yes, it does not have any immediate need, but just keeping it in reference to
@labath's comment:
https://github.com/llvm/llvm-project/pull/120979#discussion_r1905127075
Possibly for fut
@@ -730,9 +730,21 @@ ConnectionStatus ConnectionFileDescriptor::ConnectFile(
struct termios options;
::tcgetattr(fd, &options);
-// Set port speed to maximum
+// Set port speed to the available maximum
+#ifdef B115200
::cfsetospeed(&options, B115200);
DhruvSrivastavaX wrote:
Updated the branch @labath @DavidSpickett
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DhruvSrivastavaX wrote:
Updated the branch
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/4] Some base #if _AIX changes
---
.../Host/posix/
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/3] Some base #if _AIX changes
---
.../Host/posix/
https://github.com/DhruvSrivastavaX updated
https://github.com/llvm/llvm-project/pull/120979
>From c8887adb58fc0042c99a66fbc436bc95361e9086 Mon Sep 17 00:00:00 2001
From: Dhruv-Srivastava
Date: Mon, 23 Dec 2024 10:22:40 -0600
Subject: [PATCH 1/3] Some base #if _AIX changes
---
.../Host/posix/
https://github.com/DhruvSrivastavaX commented:
Tested with AIX too. Thanks!
https://github.com/llvm/llvm-project/pull/121913
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -715,7 +715,7 @@ ConnectionFileDescriptor::ConnectFD(llvm::StringRef s,
ConnectionStatus ConnectionFileDescriptor::ConnectFile(
llvm::StringRef s, socket_id_callback_type socket_id_callback,
Status *error_ptr) {
-#if LLDB_ENABLE_POSIX
+#if LLDB_ENABLE_POSIX && !defin
https://github.com/DhruvSrivastavaX edited
https://github.com/llvm/llvm-project/pull/120979
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 344 matches
Mail list logo