[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

treapster abandoned this revision. treapster added a comment. Abandoning because @MaskRay already implemented it in D128029 and D128030 . Thanks for your time, @MaskRay! Repository: rG LLVM Github Monorepo CHANGES SINCE LA

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

treapster added a comment. In D127741#3583559 , @DavidSpickett wrote: > > I agree that objdump should have some kind of "max" setting, even a default. > However there will still need to be a way to test what I referred to. As you said, ` instructio

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

treapster added a comment. For now i'd like to hear more about possible clashing instruction encodings from @labrinea, and if it's not a concern, i think we can fix the tests if we remove `CHECK-UNKNOWN:` and only call objdump with `CHECK-INST`. What do you think? Repository: rG LLVM Github

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

treapster added a comment. Well, it broke a lot of tests that very explicitly checking that instructions are not disassembled without explicitly specified extensions, but i don't quite get the point of such tests. If new instructions were added by default in lldb, why can't we do the same with

[Lldb-commits] [PATCH] D127741: [Disassembler] Add +all CPU feature to subtargetInfo and use it for disassembling AArch64

treapster created this revision. treapster added a reviewer: rafaelauler. Herald added subscribers: jsji, ayermolo, pengfei, rupprecht, hiraditya, kristof.beyls. Herald added a reviewer: jhenderson. Herald added a reviewer: MaskRay. Herald added a reviewer: rafauler. Herald added a reviewer: Amir.