DemiMarie added a comment.
In https://reviews.llvm.org/D33213#873962, @jingham wrote:
> Pavel & Eugene haven't marked it accepted yet, but from the comments is looks
> like they are both okay with the change. So it looks to me like everything
> is done but checking the code in.
>
> If you have
DemiMarie added a comment.
Does this need any further action on my part?
https://reviews.llvm.org/D33213
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
DemiMarie updated this revision to Diff 110642.
DemiMarie added a comment.
Fix misleading comment for real
https://reviews.llvm.org/D33213
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdbserver.cpp
DemiMarie updated this revision to Diff 110636.
DemiMarie added a comment.
Delete misleading comment
https://reviews.llvm.org/D33213
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdbserver.cpp
==
DemiMarie updated this revision to Diff 108796.
DemiMarie added a comment.
Set FD_CLOEXEC on the communication fd
https://reviews.llvm.org/D33213
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdbserver.cpp
=
DemiMarie added a comment.
In https://reviews.llvm.org/D33213#820238, @clayborg wrote:
> So where did the other changes go where we use "--fd" for non Apple builds?
> Did those changes get lost? They will be needed.
>
> Are you able to run the test suite now?
I did. Not all tests passed, but
DemiMarie updated this revision to Diff 108214.
DemiMarie added a comment.
Actually use socketpair :)
https://reviews.llvm.org/D33213
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdbserver.cpp
=
DemiMarie updated this revision to Diff 108094.
DemiMarie added a comment.
Initalize connection_fd
Otherwise undefined behavior ensues whenever --fd is not passed to
lldb-server -g.
https://reviews.llvm.org/D33213
Files:
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdb
DemiMarie updated this revision to Diff 107805.
DemiMarie added a comment.
Fix connection when there is no host:port
https://reviews.llvm.org/D33213
Files:
source/Host/posix/ConnectionFileDescriptorPosix.cpp
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdbserver.cpp
=
DemiMarie updated this revision to Diff 107806.
DemiMarie added a comment.
Get rid of silly and bogus #error
https://reviews.llvm.org/D33213
Files:
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdbserver.cpp
===
DemiMarie added a comment.
In https://reviews.llvm.org/D33213#813037, @clayborg wrote:
> Before any changes are submitted, we assume you are getting a clean test
> suite run.
On my system, I get build failures in clang.
https://reviews.llvm.org/D33213
_
DemiMarie added a comment.
In https://reviews.llvm.org/D33213#806807, @clayborg wrote:
> Ah yes, I thought there was something missing...
I just made `--fd` an alias for `--pipe`.
https://reviews.llvm.org/D33213
___
lldb-commits mailing list
lldb
DemiMarie updated this revision to Diff 106708.
DemiMarie added a comment.
Make --fd an alias for --pipe
https://reviews.llvm.org/D33213
Files:
source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp
tools/lldb-server/lldb-gdbserver.cpp
Index: tools/lldb-server/lldb-gdbserver.cpp
=
13 matches
Mail list logo
