[Lldb-commits] [lldb] [llvm] [clang] [BOLT] Fix unconditional output of boltedcollection in merge-fdata (PR #78653)

https://github.com/dcci commented: LG https://github.com/llvm/llvm-project/pull/78653 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D76697: [lldb] Replace debug-only assert in AppleObjCTypeEncodingParser::BuildObjCObjectPointerType with lldbassert

davide added a comment. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D76697/new/ https://reviews.llvm.org/D76697 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide closed this revision. davide added a comment. Somebody will pick this up, probably in a different form. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82813/new/ https://reviews.llvm.org/D82813 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } shafik wrote: > labath wrote: > > davide wrote: > > > shafik wrote: > > > > Wouldn't it be better to turn `m_byt

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide added a subscriber: teemperor. davide added a comment. @labath something we noticed when finding this (and related bugs) is that `frame var` carries a decent diagnostic (int *) l_125 = and the expression parser returns just returns something not particularly useful: (lldb) p l_125

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide added inline comments. Comment at: lldb/source/Symbol/Type.cpp:378 m_byte_size_has_value = true; +return m_byte_size; } shafik wrote: > Wouldn't it be better to turn `m_byte_size` into an `Optional`? As this fix > shows this having

[Lldb-commits] [PATCH] D86436: [lldb] Fix Type::GetByteSize for pointer types

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I came to the same conclusion when analyzing https://bugs.llvm.org/show_bug.cgi?id=47257 (but you beat me to the punch). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION htt

[Lldb-commits] [lldb] 0cceb54 - [TestPtrRefsObjC] Prefer `command script import`.

Author: Davide Italiano Date: 2020-08-14T15:31:02-07:00 New Revision: 0cceb54366b406649fdfe7bb11b133ab96f3cd70 URL: https://github.com/llvm/llvm-project/commit/0cceb54366b406649fdfe7bb11b133ab96f3cd70 DIFF: https://github.com/llvm/llvm-project/commit/0cceb54366b406649fdfe7bb11b133ab96f3cd70

[Lldb-commits] [lldb] 8fcfe28 - [TestPtrRefs] Prefer `command script import`.

Author: Davide Italiano Date: 2020-08-14T15:30:31-07:00 New Revision: 8fcfe2862fd4fde4793e232cfeebe6c5540c80a5 URL: https://github.com/llvm/llvm-project/commit/8fcfe2862fd4fde4793e232cfeebe6c5540c80a5 DIFF: https://github.com/llvm/llvm-project/commit/8fcfe2862fd4fde4793e232cfeebe6c5540c80a5

[Lldb-commits] [PATCH] D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp

davide added a comment. In D85396#2198668 , @tschuett wrote: > auto_ptr is deprecated since C++11 and will be removed in C++17. @jasonmolenda you might want to use `std::unique_ptr` instead -- probably LLVM won't migrate to 17 for a while, but still. R

[Lldb-commits] [PATCH] D85396: Fix a small memory leak in VectorType.cpp and BlockPointer.cpp

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. This is correct to the best of my understanding. Thank you Jason. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85396/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D85388: [lldb] Fix bug in skipIfRosetta decorator

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. yes, this makes sense. We could refine the check in future. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D85388/new/ https://reviews.llvm.org/D85388 ___

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

davide added inline comments. Comment at: lldb/test/API/functionalities/data-formatter/valueobj-pass-by-reg/Makefile:2 +EXE := a.out +CFLAGS := -O1 + davide wrote: > This is fundamentally a no-go. Depending on the optimization pipeline passes > this in a regist

[Lldb-commits] [PATCH] D85376: Fix how ValueObjectChild handles bit-fields stored in a Scalar in UpdateValue()

davide requested changes to this revision. davide added inline comments. This revision now requires changes to proceed. Comment at: lldb/test/API/functionalities/data-formatter/valueobj-pass-by-reg/Makefile:2 +EXE := a.out +CFLAGS := -O1 + This is fundamentally

[Lldb-commits] [PATCH] D85049: Unify the code that updates the ArchSpec after finding a fat binary with how it is done for a lean binary

davide added inline comments. Comment at: lldb/source/Target/TargetList.cpp:110-111 +// architecture so that the platform matching can be more accurate. +if (!platform_arch.TripleOSWasSpecified() || +!platform_arch.TripleVendorWasSpecified()) { + prefer_platf

[Lldb-commits] [PATCH] D85365: [lldb] Modify the `skipIfRemote` decorator so we can skip all PExpect tests.

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. I assume we're still allowing to put the decorator on a test-by-test basis, and that seems the case from what I see. If so, LG. Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://r

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

davide closed this revision. davide added a comment. https://github.com/llvm/llvm-project/commit/57605758b5de3726eec1d6e587de1003af1ab5b7 CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84263/new/ https://reviews.llvm.org/D84263 ___ lldb-commit

[Lldb-commits] [lldb] 5760575 - [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

Author: Davide Italiano Date: 2020-07-30T16:21:05-07:00 New Revision: 57605758b5de3726eec1d6e587de1003af1ab5b7 URL: https://github.com/llvm/llvm-project/commit/57605758b5de3726eec1d6e587de1003af1ab5b7 DIFF: https://github.com/llvm/llvm-project/commit/57605758b5de3726eec1d6e587de1003af1ab5b7

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Reviewed by Jason privately. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84263/new/ https://reviews.llvm.org/D84263 ___ lldb-commits mai

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

davide updated this revision to Diff 282073. davide added a comment. Added the check that Jason requested. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84263/new/ https://reviews.llvm.org/D84263 Files: lldb/tools/debugserver/source/DNB.cpp lldb/tools/debugserver/source/debugserver

[Lldb-commits] [PATCH] D84272: Add checks for ValueObjectSP in Cocoa summary providers

davide requested changes to this revision. davide added a comment. This revision now requires changes to proceed. why? Do you have a testcase? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84272/new/ https://reviews.llvm.org/D84272 ___ lldb

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

davide added a comment. yeah, I think it's reasonable. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D84263/new/ https://reviews.llvm.org/D84263 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman

[Lldb-commits] [PATCH] D84263: [debugserver/Apple Silicon] Handoff connections when attaching to translated processes

davide created this revision. davide added a reviewer: jasonmolenda. When we detect a process that the native debugserver cannot handle, handoff the connection fd to the translated debugserver. https://reviews.llvm.org/D84263 Files: lldb/tools/debugserver/source/DNB.cpp lldb/tools/debugser

[Lldb-commits] [lldb] b1a6d37 - [PlatformMacOSX] Remove unused variable. NFC.

Author: Davide Italiano Date: 2020-07-20T14:50:59-07:00 New Revision: b1a6d373d5e0adbaa1ed70a9cadcfa84420a449f URL: https://github.com/llvm/llvm-project/commit/b1a6d373d5e0adbaa1ed70a9cadcfa84420a449f DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [lldb] cd05406 - [testsuite] Adapt lldb-server base test helper to run on arm64

Author: Davide Italiano Date: 2020-07-20T14:38:13-07:00 New Revision: cd05406b105334b01f0eae141e7e05d6fb4a2ecb URL: https://github.com/llvm/llvm-project/commit/cd05406b105334b01f0eae141e7e05d6fb4a2ecb DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [lldb] 001c8e1 - [PlatformDarwin] Add support for Apple Silicon.

Author: Davide Italiano Date: 2020-07-20T14:11:19-07:00 New Revision: 001c8e1fd9f09d3de9ff6e64bdac4b8ca681dfb4 URL: https://github.com/llvm/llvm-project/commit/001c8e1fd9f09d3de9ff6e64bdac4b8ca681dfb4 DIFF: https://github.com/llvm/llvm-project/commit/001c8e1fd9f09d3de9ff6e64bdac4b8ca681dfb4

[Lldb-commits] [lldb] 61cf9f4 - [ObjectFilePECOFF] Try to avoid unaligned access.

Author: Davide Italiano Date: 2020-07-14T18:53:23-07:00 New Revision: 61cf9f4e723bd9522757931706b208a1357c30ba URL: https://github.com/llvm/llvm-project/commit/61cf9f4e723bd9522757931706b208a1357c30ba DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [lldb] 3f2d880 - [ObjC] Wrap namespace-global structs in an anonymous namespace to avoid ODR violations

Author: Davide Italiano Date: 2020-07-14T11:26:20-07:00 New Revision: 3f2d880a932970d19bfed88c6900d50c9c3bc203 URL: https://github.com/llvm/llvm-project/commit/3f2d880a932970d19bfed88c6900d50c9c3bc203 DIFF: https://github.com/llvm/llvm-project/commit/3f2d880a932970d19bfed88c6900d50c9c3bc203

[Lldb-commits] [PATCH] D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations

This revision was automatically updated to reflect the committed changes. Closed by commit rG3f2d880a9329: [ObjC] Wrap namespace-global structs in an anonymous namespace to avoid ODR… (authored by davide). Herald added a project: LLDB. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACT

[Lldb-commits] [PATCH] D83796: [ObjC] Wrap namespace-global structure in an anonymous namespace to avoid ODR violations

davide created this revision. davide added a reviewer: teemperor. rdar://problem/65537147 https://reviews.llvm.org/D83796 Files: lldb/source/Plugins/Language/ObjC/NSArray.cpp lldb/source/Plugins/Language/ObjC/NSDictionary.cpp Index: lldb/source/Plugins/Language/ObjC/NSDictionary.cpp ==

[Lldb-commits] [PATCH] D83600: Add a decorator to skip tests when running under Rosetta

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Good, one minor suggestion. Comment at: lldb/packages/Python/lldbsuite/test/decorators.py:560 +return False +return platform.uname()[5] == "arm" and self.

[Lldb-commits] [PATCH] D83582: Fix nesting of #ifdef

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. LGTM CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83582/new/ https://reviews.llvm.org/D83582 ___ lldb-commits mailing list lldb-commits

[Lldb-commits] [PATCH] D83306: [lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)

davide added a comment. This broke macOS: http://green.lab.llvm.org/green/view/LLDB/job/lldb-cmake/22425/ I reverted it in: commit 27d52cd86a2cf82214b71519dffd450c54cf87ae (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jul 8 13:00:29 2020 -0

[Lldb-commits] [lldb] 27d52cd - Revert "[lldb/API] Overwrite variables with SBLaunchInfo::SetEnvironment(append=true)"

Author: Davide Italiano Date: 2020-07-08T13:09:24-07:00 New Revision: 27d52cd86a2cf82214b71519dffd450c54cf87ae URL: https://github.com/llvm/llvm-project/commit/27d52cd86a2cf82214b71519dffd450c54cf87ae DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

This revision was automatically updated to reflect the committed changes. davide marked an inline comment as done. Closed by commit rG5832473dcf4e: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed. (authored by davide). Herald added a project: LLDB. Repository: rG LLVM Gi

[Lldb-commits] [lldb] 4dba3f4 - [dotest] Log a warning when --server and --out-of-tree-debugserver are set

Author: Davide Italiano Date: 2020-07-07T15:03:08-07:00 New Revision: 4dba3f4e030a906f9ec7e940dfc4a57b94374154 URL: https://github.com/llvm/llvm-project/commit/4dba3f4e030a906f9ec7e940dfc4a57b94374154 DIFF: https://github.com/llvm/llvm-project/commit/4dba3f4e030a906f9ec7e940dfc4a57b94374154

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

This revision was automatically updated to reflect the committed changes. davide marked an inline comment as done. Closed by commit rG5832473dcf4e: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed. (authored by davide). Herald added a project: LLDB. Repository: rG LLVM Gi

[Lldb-commits] [lldb] 5832473 - Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

Author: Davide Italiano Date: 2020-07-07T15:01:21-07:00 New Revision: 5832473dcf4e5b22c9eb6381fb291be92f431208 URL: https://github.com/llvm/llvm-project/commit/5832473dcf4e5b22c9eb6381fb291be92f431208 DIFF: https://github.com/llvm/llvm-project/commit/5832473dcf4e5b22c9eb6381fb291be92f431208

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

davide added a comment. In D83327#2136842 , @jingham wrote: > In D83327#2136814 , @davide wrote: > > > Aside from cosmetics, I'm not entirely sure this is the correct fix. Why > > are we calling this code _at all_

[Lldb-commits] [PATCH] D83327: [lldb/Core] Fix incomplete type variable dereferencing crash.

davide added a comment. Aside from cosmetics, I'm not entirely sure this is the correct fix. Why are we calling this code _at all_ if the type is incomplete? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D83327/new/ https://reviews.llvm.org/D83327

[Lldb-commits] [PATCH] D43048: [lldb-test/WIP] Allow a way to test autocompletion

davide abandoned this revision. davide added a comment. Cleaning up my queue. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D43048/new/ https://reviews.llvm.org/D43048 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.l

[Lldb-commits] [lldb] 983a4b5 - Skip arm-(fp|gp)-read.test on Darwin.

Author: Davide Italiano Date: 2020-06-30T12:53:20-07:00 New Revision: 983a4b520ea384ac978cbfc40bb956fbb98cd735 URL: https://github.com/llvm/llvm-project/commit/983a4b520ea384ac978cbfc40bb956fbb98cd735 DIFF: https://github.com/llvm/llvm-project/commit/983a4b520ea384ac978cbfc40bb956fbb98cd735

[Lldb-commits] [lldb] 4f1f253 - [TestReturnValue] Skip based on architecutre, not platform.

Author: Davide Italiano Date: 2020-06-30T12:48:23-07:00 New Revision: 4f1f253ce509ebc20e1f7a2d8bb6885366b155f2 URL: https://github.com/llvm/llvm-project/commit/4f1f253ce509ebc20e1f7a2d8bb6885366b155f2 DIFF: https://github.com/llvm/llvm-project/commit/4f1f253ce509ebc20e1f7a2d8bb6885366b155f2

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3424 +if (Host::IsProcessTranslated(process_info)) { + FileSpec rosetta_debugserver("/Library/Apple/usr/libexec/oah/debugserver

[Lldb-commits] [PATCH] D82616: Improve the detection of iOS/tvOS/watchOS simulator binaries in debugserver and lldb

davide accepted this revision. davide added a comment. Thanks. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82616/new/ https://reviews.llvm.org/D82616 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Check whether a process is translated (Rosetta). + /// \arg process_info The info structure for the process queried. aprantl wrote: > Is

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/packages/Python/lldbsuite/test/dotest.py:366 -if args.server: +if args.server and not args.out_of_tree_debugserver: os.environ['LLDB_DEBUGSERVER_PATH'] = args.server ---

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/include/lldb/Host/Host.h:231 + /// Run a shell command. + /// \arg process_info The info structure for the process queried. Stale comment, I'll update CHANGES SINCE LAST

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide created this revision. davide added reviewers: aprantl, jasonmolenda. Nothing crazy here, just an organizational cleanup. https://reviews.llvm.org/D82813 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/common/Host.cpp lldb/source/Host/macosx/objcxx/Host.mm lldb/source/Plugi

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/ProcessGDBRemote.cpp:3444 +size_t bufsize = sizeof(processInfo); +if (sysctl(mib, (unsigned)(sizeof(mib)/sizeof(int)), &processInfo, + &

[Lldb-commits] [PATCH] D82813: [Apple Silicon] Rewrite part of the Rosetta support to be confined in Apple specific files

davide updated this revision to Diff 274253. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82813/new/ https://reviews.llvm.org/D82813 Files: lldb/include/lldb/Host/Host.h lldb/source/Host/common/Host.cpp lldb/source/Host/macosx/objcxx/Host.mm lldb/source/Plugins/Process/gdb-remot

[Lldb-commits] [PATCH] D82804: Do not set LLDB_DEBUGSERVER_PATH if --out-of-tree-debugserver is passed.

davide created this revision. davide added reviewers: vsk, aprantl, jasonmolenda. Now that there are two implementations of debugserver, one for native and the other for Rosetta [on Apple Silicon], this is needed. https://reviews.llvm.org/D82804 Files: lldb/packages/Python/lldbsuite/test/dot

[Lldb-commits] [lldb] 300bbbc - [ProcessGDBRemote] Get rid of an unused function.

Author: Davide Italiano Date: 2020-06-29T12:39:09-07:00 New Revision: 300bbbcb707ad08200543735326982664136d3bc URL: https://github.com/llvm/llvm-project/commit/300bbbcb707ad08200543735326982664136d3bc DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [lldb] c7eb06a - [test] XFail TestStepNoDebug based on arch rather than OS

Author: Davide Italiano Date: 2020-06-25T16:23:59-07:00 New Revision: c7eb06a880522867e7df3f025056f6c5b10d0eca URL: https://github.com/llvm/llvm-project/commit/c7eb06a880522867e7df3f025056f6c5b10d0eca DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [lldb] 38135b2 - [test] XFail TestSigtrampUnwind based on arch rather than OS

Author: Davide Italiano Date: 2020-06-25T16:22:52-07:00 New Revision: 38135b2a7fff008093c0ca020855373f33ec9b12 URL: https://github.com/llvm/llvm-project/commit/38135b2a7fff008093c0ca020855373f33ec9b12 DIFF: https://github.com/llvm/llvm-project/commit/38135b2a7fff008093c0ca020855373f33ec9b12

[Lldb-commits] [lldb] d358ec4 - [lldb/test] Skip TestBreakpointThumbCodesection on arm64.

Author: Davide Italiano Date: 2020-06-25T16:20:27-07:00 New Revision: d358ec463943878936080064d1c43afd8798aaf0 URL: https://github.com/llvm/llvm-project/commit/d358ec463943878936080064d1c43afd8798aaf0 DIFF: https://github.com/llvm/llvm-project/commit/d358ec463943878936080064d1c43afd8798aaf0

[Lldb-commits] [lldb] 0df7be2 - [lldb/test] XFAIL TestHWBreakMultiThread on arch rather platform.

Author: Davide Italiano Date: 2020-06-25T16:21:23-07:00 New Revision: 0df7be234412e60fbbaaf8c181fe2dfb3a2c1cc3 URL: https://github.com/llvm/llvm-project/commit/0df7be234412e60fbbaaf8c181fe2dfb3a2c1cc3 DIFF: https://github.com/llvm/llvm-project/commit/0df7be234412e60fbbaaf8c181fe2dfb3a2c1cc3

[Lldb-commits] [lldb] 47ac453 - [HostInfoMacOS] Parse correctly the triple for Apple Silicon.

Author: Davide Italiano Date: 2020-06-24T16:37:21-07:00 New Revision: 47ac45332e25c89d0ced5108c667fe92cf0f509a URL: https://github.com/llvm/llvm-project/commit/47ac45332e25c89d0ced5108c667fe92cf0f509a DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [lldb] 2010444 - [Apple Silicon] Handle macOS in PlatformDarwin

Author: Davide Italiano Date: 2020-06-24T16:35:36-07:00 New Revision: 2010444e5e5f2a310334e98d7a65667ed78d23ab URL: https://github.com/llvm/llvm-project/commit/2010444e5e5f2a310334e98d7a65667ed78d23ab DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [lldb] 58de2a3 - [ProcessGDBRemote] Placate the Windows buildbot.

Author: Davide Italiano Date: 2020-06-24T13:23:49-07:00 New Revision: 58de2a3851391dd9fa675ea6bcd26072a0638829 URL: https://github.com/llvm/llvm-project/commit/58de2a3851391dd9fa675ea6bcd26072a0638829 DIFF: https://github.com/llvm/llvm-project/commit/58de2a3851391dd9fa675ea6bcd26072a0638829

[Lldb-commits] [PATCH] D82493: [Apple Silicon] Debugging of process under Rosetta is supported

davide accepted this revision. davide added a comment. commit b4fdddf971b191aa9a6643ab637b87bc1d686254 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jun 24 12:25:01 2020 -0700 [Apple Silicon] Debugging of process under Rosetta is suppor

[Lldb-commits] [lldb] b4fdddf - [Apple Silicon] Debugging of process under Rosetta is supported.

Author: Davide Italiano Date: 2020-06-24T12:25:01-07:00 New Revision: b4fdddf971b191aa9a6643ab637b87bc1d686254 URL: https://github.com/llvm/llvm-project/commit/b4fdddf971b191aa9a6643ab637b87bc1d686254 DIFF: https://github.com/llvm/llvm-project/commit/b4fdddf971b191aa9a6643ab637b87bc1d686254

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide closed this revision. davide added a comment. commit fd19ddb8f2a2b082f492fc59f7f360adf3495701 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jun 24 12:18:29 2020 -0700 [Apple Silicon] Initial support for Rosetta Transla

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

davide added a comment. In D82491#2112269 , @jasonmolenda wrote: > LGTM. With p_flag, we only need to evaluate (processInfo.kp_proc.p_flag & > P_TRANSLATED) as a boolean, but that's a style pref as much as anything. Fair, let me change that. CHANGES

[Lldb-commits] [PATCH] D82493: [Apple Silicon] Debugging of process under Rosetta is supported

davide created this revision. davide added reviewers: jasonmolenda, friss, aprantl. Remove this early exit. It's vestigial from the ppc -> Intel transition, but it doesn't apply anymore: https://reviews.llvm.org/D82493 Files: lldb/source/Host/macosx/objcxx/Host.mm Index: lldb/source/Host/m

[Lldb-commits] [PATCH] D82491: [Apple Silicon] Initial support for Rosetta

_TRANSLATED) as a boolean, but that's a style pref as much as anything. Fair, let me change that. davide added a comment. commit fd19ddb8f2a2b082f492fc59f7f360adf3495701 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Wed Jun 24 12:18:29 2020 -0700

[Lldb-commits] [lldb] fd19ddb - [Apple Silicon] Initial support for Rosetta

Author: Davide Italiano Date: 2020-06-24T12:19:21-07:00 New Revision: fd19ddb8f2a2b082f492fc59f7f360adf3495701 URL: https://github.com/llvm/llvm-project/commit/fd19ddb8f2a2b082f492fc59f7f360adf3495701 DIFF: https://github.com/llvm/llvm-project/commit/fd19ddb8f2a2b082f492fc59f7f360adf3495701

[Lldb-commits] [lldb] 33ece57 - Generalize TestFormattersBoolRefPtr to work on Apple Silicon.

Author: Davide Italiano Date: 2020-06-23T12:45:31-07:00 New Revision: 33ece57241d8ad46cb91eca483f05515849a85e5 URL: https://github.com/llvm/llvm-project/commit/33ece57241d8ad46cb91eca483f05515849a85e5 DIFF: https://github.com/llvm/llvm-project/commit/33ece57241d8ad46cb91eca483f05515849a85e5

[Lldb-commits] [lldb] 63d5970 - [ObjectFileMachO] Check for TARGET_EMBEDDED instead of listing architectures.

Author: Davide Italiano Date: 2020-06-23T12:37:45-07:00 New Revision: 63d597093cccbb8d4962cf490e2d754a73a77e64 URL: https://github.com/llvm/llvm-project/commit/63d597093cccbb8d4962cf490e2d754a73a77e64 DIFF: https://github.com/llvm/llvm-project/commit/63d597093cccbb8d4962cf490e2d754a73a77e64

[Lldb-commits] [lldb] 3c79212 - [Host] Check for TARGET_OS_EMBEDDED instead of listing architectures.

Author: Davide Italiano Date: 2020-06-23T12:27:21-07:00 New Revision: 3c79212319d878b07ef259d735b52b379f774e25 URL: https://github.com/llvm/llvm-project/commit/3c79212319d878b07ef259d735b52b379f774e25 DIFF: https://github.com/llvm/llvm-project/commit/3c79212319d878b07ef259d735b52b379f774e25

[Lldb-commits] [PATCH] D82394: [debugserver] Initial support for Apple Silicon.

davide added a comment. commit 2276bb48be0175f96b1494ca67b7921f0d4e87d8 (HEAD -> master, origin/master, origin/HEAD) Author: Davide Italiano Date: Tue Jun 23 10:18:54 2020 -0700 [debugserver] Initial support for Apple Silicon. Set the correct os type in the a

[Lldb-commits] [PATCH] D82394: [debugserver] Initial support for Apple Silicon.

davide added a comment. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82394/new/ https://reviews.llvm.org/D82394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

[Lldb-commits] [PATCH] D82394: [debugserver] Initial support for Apple Silicon.

davide added a comment. Danke shoen CHANGES SINCE LAST ACTION https://reviews.llvm.org/D82394/new/ https://reviews.llvm.org/D82394 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

[Lldb-commits] [lldb] 2276bb4 - [debugserver] Initial support for Apple Silicon.

Author: Davide Italiano Date: 2020-06-23T10:47:16-07:00 New Revision: 2276bb48be0175f96b1494ca67b7921f0d4e87d8 URL: https://github.com/llvm/llvm-project/commit/2276bb48be0175f96b1494ca67b7921f0d4e87d8 DIFF: https://github.com/llvm/llvm-project/commit/2276bb48be0175f96b1494ca67b7921f0d4e87d8

[Lldb-commits] [lldb] c3f0d9f - [IRExecutionUnit] Early returns for clarity. NFCI.

Author: Davide Italiano Date: 2020-06-05T14:52:36-07:00 New Revision: c3f0d9f3d22d7a3770f2886df9c554e1c277e45a URL: https://github.com/llvm/llvm-project/commit/c3f0d9f3d22d7a3770f2886df9c554e1c277e45a DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [PATCH] D81119: [lldb] Fix SLEB128 decoding

davide added a comment. Greg & Pavel might have opinions on this patch. I'm not qualified to review it. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D81119/new/ https://reviews.llvm.org/D81119 ___ lldb

[Lldb-commits] [lldb] 7c1b060 - [IRInterpreter] Unused. Drive-by cleanup. NFCI.

Author: Davide Italiano Date: 2020-06-03T13:31:58-07:00 New Revision: 7c1b060c3c65cac50edec5cceb6653957c344d96 URL: https://github.com/llvm/llvm-project/commit/7c1b060c3c65cac50edec5cceb6653957c344d96 DIFF: https://github.com/llvm/llvm-project/commit/7c1b060c3c65cac50edec5cceb6653957c344d96

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

davide added a comment. This is great Adrian. I feel like there are several other instances of additions that should use `llvm::checkAdd` here instead of `+`. Is this the only UB triggered in the testsuite? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80955/new/ https://reviews.llvm.

[Lldb-commits] [PATCH] D80955: Fix UB in EmulateInstructionARM64.cpp

davide added inline comments. Comment at: lldb/source/Plugins/Instruction/ARM64/EmulateInstructionARM64.cpp:25 +#include + shafik wrote: > Why? also should be `cstdlib` in C++. It's just something shuffled around, probably a side effect of clang-format. CHAN

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

davide accepted this revision. davide added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/DataFormatters/Mock.h:1-8 +//===-- Mock.h --*- C++ -*-===// +// +// Part of the LLVM Projec

[Lldb-commits] [PATCH] D80150: [lldb/DataFormatter] Check for overflow when finding NSDate epoch

davide added a comment. Looking, as I touched `NSDate` last year. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D80150/new/ https://reviews.llvm.org/D80150 ___ lldb-commits mailing list lldb-commits@lis

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

davide added a comment. I'm curious what happens if you end up here with something like `_T`. Did you check? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/ https://reviews.llvm.org/D79823 __

[Lldb-commits] [PATCH] D79823: [lldb][Core] Remove dead codepath in Mangled

davide accepted this revision. davide added a comment. This revision is now accepted and ready to land. Presumably. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79823/new/ https://reviews.llvm.org/D79823

[Lldb-commits] [lldb] d606dcc - [TestIndirectSymbol] This tests an Apple-specific feature.

Author: Davide Italiano Date: 2020-05-05T13:14:05-07:00 New Revision: d606dcc65254b13e6238b69d8185d3667e850522 URL: https://github.com/llvm/llvm-project/commit/d606dcc65254b13e6238b69d8185d3667e850522 DIFF: https://github.com/llvm/llvm-project/commit/d606dcc65254b13e6238b69d8185d3667e850522

[Lldb-commits] [lldb] 48e5eed - [TestIndirectSymbols] This now runs and works on iOS (arm64).

Author: Davide Italiano Date: 2020-05-05T13:14:05-07:00 New Revision: 48e5eedab3aa170f880b333d5e38bbc6e72d4b8b URL: https://github.com/llvm/llvm-project/commit/48e5eedab3aa170f880b333d5e38bbc6e72d4b8b DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [lldb] 6951fe3 - [arm64] Remove an old special case that's not needed anymore.

Author: Davide Italiano Date: 2020-05-04T14:18:51-07:00 New Revision: 6951fe3989343c6605c397ac427acea4e39d2132 URL: https://github.com/llvm/llvm-project/commit/6951fe3989343c6605c397ac427acea4e39d2132 DIFF: https://github.com/llvm/llvm-project/commit/6951fe3989343c6605c397ac427acea4e39d2132

[Lldb-commits] [lldb] 30ddd4c - [ARM64] Remove more dead code. NFC.

Author: Davide Italiano Date: 2020-05-01T15:05:42-07:00 New Revision: 30ddd4ce19316fd2a8a50c5bc511433c87ecb95c URL: https://github.com/llvm/llvm-project/commit/30ddd4ce19316fd2a8a50c5bc511433c87ecb95c DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [lldb] 68f8e02 - [ARM64] Remove dead code.

Author: Davide Italiano Date: 2020-05-01T15:04:44-07:00 New Revision: 68f8e0264e297bf7abadb1ca3850949606bdb4f5 URL: https://github.com/llvm/llvm-project/commit/68f8e0264e297bf7abadb1ca3850949606bdb4f5 DIFF: https://github.com/llvm/llvm-project/commit/68f8e0264e297bf7abadb1ca3850949606bdb4f5

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

davide added a comment. Saleem is the right person to review this change. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78972/new/ https://reviews.llvm.org/D78972 ___ lldb-commits mailing list lldb-com

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

davide added a comment. I'm really worried about this change -- and we should think about it very carefully because it might cause the LLVM verifier to freak out -- or even worse, causing random crashes when executing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://

[Lldb-commits] [PATCH] D78972: Treat hasWeakODRLinkage symbols as external in REPL computations

davide added a comment. Weak functions can actually be overridden -- I'm really wondering whether this causes issues here. Do you have an example [even if it's in swift] of a symbol that's not exported correctly? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://review

[Lldb-commits] [PATCH] D78588: [lldb/Core] Check that ArchSpec is valid.

davide added a comment. What's exactly the testcase doing? Repository: rLLDB LLDB CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78588/new/ https://reviews.llvm.org/D78588 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

davide added a comment. This looks fine to me but please give Pavel another chance to look before committing. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D78396/new/ https://reviews.llvm.org/D78396 _

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

davide added a comment. This is almost ready. After we're done with this round of cosmetics, I'll take another look a the algorithm and sign off. Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.cpp:18-19 + return true; +else if (m_ptr_size == 8 && m_ht_64) +

[Lldb-commits] [PATCH] D78396: [lldb/Dataformatter] Add support for CoreFoundation Dictionaries and Sets

davide added a comment. Thanks for taking care of this. It's a lot of work. First round of comments. Comment at: lldb/source/Plugins/Language/ObjC/CFBasicHash.cpp:12 + +CFBasicHash::~CFBasicHash() { m_address = LLDB_INVALID_ADDRESS; } + Why do you need this? Ca

[Lldb-commits] [lldb] ce77900 - [DWARF] Rename a function and comment it for clarity.

Author: Davide Italiano Date: 2020-04-16T15:37:09-07:00 New Revision: ce7790044faa48a1ec49b6339797180e05520cef URL: https://github.com/llvm/llvm-project/commit/ce7790044faa48a1ec49b6339797180e05520cef DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [lldb] 1fae85a - [DWARF] Add instructions to regenerate this test, if needed.

Author: Davide Italiano Date: 2020-04-16T13:31:32-07:00 New Revision: 1fae85a8534ec51ca893899314bd244b3e9684c7 URL: https://github.com/llvm/llvm-project/commit/1fae85a8534ec51ca893899314bd244b3e9684c7 DIFF: https://github.com/llvm/llvm-project/commit/1fae85a8534ec51ca893899314bd244b3e9684c7

[Lldb-commits] [lldb] 8cac6d1 - [Shell] Remove incorrectly cargo-culted UNSUPPORTED.

Author: Davide Italiano Date: 2020-04-16T13:22:46-07:00 New Revision: 8cac6d1875e094f2b78621f3ff12e61553cd12ec URL: https://github.com/llvm/llvm-project/commit/8cac6d1875e094f2b78621f3ff12e61553cd12ec DIFF: https://github.com/llvm/llvm-project/commit

[Lldb-commits] [PATCH] D77698: [DWARF] Assign the correct scope to constant variables

davide marked an inline comment as done. davide added inline comments. Comment at: lldb/source/Plugins/SymbolFile/DWARF/DWARFDebugInfoEntry.cpp:1029 + return false; + +case DW_TAG_compile_unit: aprantl wrote: > To save everyone the trouble: > ``` > 0x000

Re: [Lldb-commits] [lldb] 680082a - [lldb/Reproducers] Add a small artificial delay before exiting

> On Apr 9, 2020, at 11:05, Jonas Devlieghere via lldb-commits > wrote: > > > Author: Jonas Devlieghere > Date: 2020-04-09T11:03:24-07:00 > New Revision: 680082a408dd2df7410d77696100eac8ce9d5530 > > URL: > https://github.com/llvm/llvm-project/commit/680082a408dd2df7410d77696100eac8ce9d5530

  1   2   3   4   5   6   7   8   9   10   >