[Lldb-commits] [PATCH] D138792: [AArch64] Improve TargetParser API

2023-01-13 Thread Daniel Kiss via Phabricator via lldb-commits
danielkiss added inline comments. Comment at: clang/lib/Basic/Targets/AArch64.cpp:532 getTargetDefinesARMV81A(Opts, Builder); -break; - case llvm::AArch64::ArchKind::ARMV8_2A: + if (*ArchInfo == llvm::AArch64::ARMV8_2A) getTargetDefinesARMV82A(Opts, Builder);

[Lldb-commits] [PATCH] D103626: [lldb][AArch64] Remove non address bits from memory read arguments

2021-12-16 Thread Daniel Kiss via Phabricator via lldb-commits
danielkiss accepted this revision. danielkiss added a comment. In D103626#2824083 , @DavidSpickett wrote: >> Maybe this is something worth considering for LLDB memory dumps? > > I'm working on that at the moment, it's on my github branch. This is what it

[Lldb-commits] [PATCH] D77044: Extend max register size to accommodate AArch64 SVE vector regs

2020-03-30 Thread Daniel Kiss via Phabricator via lldb-commits
danielkiss added inline comments. Comment at: lldb/source/Plugins/Process/gdb-remote/GDBRemoteCommunicationServerLLGS.cpp:2051 // Parse out the value. - uint8_t reg_bytes[32]; // big enough to support up to 256 bit ymmN register + uint8_t reg_bytes[256]; // big enough to su

[Lldb-commits] [PATCH] D71761: [lldb] Add a setting to not install the main executable

2020-01-20 Thread Daniel Kiss via Phabricator via lldb-commits
danielkiss updated this revision to Diff 239156. danielkiss added a comment. Patch is rebased due to conflict with the upstream changes. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71761/new/ https://reviews.llvm.org/D71761 Files: lldb/include/lldb/Target/Target.h lldb/packages/

[Lldb-commits] [PATCH] D71761: [lldb] Add a setting to not install the main executable

2020-01-14 Thread Daniel Kiss via Phabricator via lldb-commits
danielkiss added a comment. Thanks for the review, I have no push rights, could you please submit it on my behalf? Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D71761/new/ https://reviews.llvm.org/D71761

[Lldb-commits] [PATCH] D71761: [lldb] Add a setting to not install the main executable

2019-12-20 Thread Daniel Kiss via Phabricator via lldb-commits
danielkiss created this revision. danielkiss added reviewers: omjavaid, JDevlieghere, srhines. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. Add setting target.auto-install-main-executable that controls whether the main executable should be automatically installed when con