This revision was automatically updated to reflect the committed changes.
Closed by commit rG6006d43e2d7d: LLVM_FALLTHROUGH => [[fallthrough]]. NFC
(authored by craig.topper).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D150996/new/
https://reviews
craig.topper created this revision.
craig.topper added a reviewer: MaskRay.
Herald added subscribers: ThomasRaoux, kbarton, hiraditya, nemanjai.
Herald added a project: All.
craig.topper requested review of this revision.
Herald added a reviewer: zuban32.
Herald added subscribers: lldb-commits, cfe
craig.topper added a comment.
I posted https://reviews.llvm.org/D17 to get these in the frontend.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144366/new/
https://reviews.llvm.org/D144366
___
lldb-c
craig.topper added a comment.
These transforms are not valid without the `contract` fast math flag
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D144366/new/
https://reviews.llvm.org/D144366
___
lldb-comm
craig.topper added inline comments.
Herald added subscribers: Michael137, JDevlieghere.
Comment at: lldb/include/lldb/Target/Target.h:416
- void SetResultIsInternal(bool b) { m_result_is_internal = b; }
Unrelated?
Repository:
rG LLVM Github Monorepo
CHA
craig.topper added a comment.
I seem to be unable to pass `check-clang` after this. A lot of tests fail
because they can't find headers they need.
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D130586/new/
https://reviews.llvm.org/D130586
craig.topper added inline comments.
Comment at: clang/lib/Basic/Targets/RISCV.h:111
SizeType = UnsignedInt;
-resetDataLayout("e-m:e-p:32:32-i64:64-n32-S128");
}
Instead of creating new classes, could we have a branch on the Arch or
isLittleEndian por
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D109483/new/
https://reviews.llvm.org/D109483
___
craig.topper added a comment.
I think I read this patch too closely. I'll leave it up to you how much of this
you want to do.
Comment at: llvm/include/llvm/IR/Constants.h:206
/// Determine if the value is all ones.
bool isMinusOne() const { return Val.isAllOnesValue(); }
craig.topper added inline comments.
Comment at: llvm/include/llvm/ADT/APInt.h:384
/// value for the APInt's bit width.
bool isMaxValue() const { return isAllOnesValue(); }
isAllOnes()?
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
h
This revision was automatically updated to reflect the committed changes.
Closed by commit rGa58b62b4a2b9: [IR] Replace all uses of
CallBase::getCalledValue() with getCalledOperand(). (authored by craig.topper).
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.ll
craig.topper created this revision.
craig.topper added a reviewer: dblaikie.
Herald added subscribers: lldb-commits, cfe-commits, Kayjukh, frgossen,
grosul1, dantrushin, Joonsoo, kerbowa, liufengdb, lucyrfox, mgester,
arpith-jacob, csigg, nicolasvasilache, antiagainst, shauheen, jpienaar,
rriddl
craig.topper accepted this revision.
craig.topper added a comment.
This revision is now accepted and ready to land.
LGTM
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D78791/new/
https://reviews.llvm.org/D78791
___
craig.topper added a comment.
__builtin_cpu_init was added to clang between 5.0 and 6.0
https://reviews.llvm.org/D41962
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
craig.topper added a comment.
I don't know what platforms this needs to support. But __builtin_cpu_support
only works when compiled with clang or gcc. And it requires compiler-rt or
libgcc. I don't know if that's guaranteed to exist on Windows.
Repository:
rL LLVM
https://reviews.llvm.org/D
15 matches
Mail list logo
