[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-08-12 Thread Christian Kühnel via Phabricator via lldb-commits
kuhnel added a comment. @phosek sorry for the late reply, the builds on master are still green, so your changes are working on Windows as well. Thank you for the extra work! Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D79219/new/ https://reviews

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-08-10 Thread Christian Kühnel via Phabricator via lldb-commits
kuhnel added a comment. > Looking at the error, it seems like you have a 32-bit version of zlib > installed and in your search path on a 64-bit version of Windows. I'm not > quite sure how to handle that in CMake. For mlir-windows buildbot: I have no clue on what is installed there. For pre-me

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-08-10 Thread Christian Kühnel via Phabricator via lldb-commits
kuhnel added a comment. This patch broke the Windows compilation on buildbot and pre-merge testing . So I'll revert it to get pre-merge testing back online. Otherwise th

[Lldb-commits] [PATCH] D79219: [CMake] Simplify CMake handling for zlib

2020-08-10 Thread Christian Kühnel via Phabricator via lldb-commits
kuhnel added a comment. In D79219#2202048 , @phosek wrote: > How can I test this change on pre-merge bots? I haven't seen any builds > posted on this change before. You can just look at the mlir-windows buildbot, this also showed the failing build: http