boris.ulasevich added a comment.
FYI.
After r295088 commit Xcode project fails with "no such file or directory:
'/Users/boris/ws/lldb/lldb/source/Utility/ModuleCache.cpp'" message.
I think lldb.xcodeproj/project.pbxproj should be updated.
Repository:
rL LLVM
https://reviews.llvm.org/D29909
boris.ulasevich added a comment.
Yes, it is quite old story. Original issue was that breakpoint with false
condition resumes execution in spite of completed step plan. There was two
local fix proposals, but finally the issue was fixed by
StopInfoBreakpoint::PerformAction and Thread::GetStopInfo
boris.ulasevich added a comment.
ping!
https://reviews.llvm.org/D29144
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
boris.ulasevich added a comment.
In https://reviews.llvm.org/D29144#659052, @jingham wrote:
> What's special about the TestCallThatThrows test?
Good question! It must be related with SetIgnoreBreakpoints(True) option used
in the test: with this option StopInfoBreakpoint::PerformAction is not
boris.ulasevich updated this revision to Diff 86091.
boris.ulasevich added a comment.
I made another diff with using GetCompletedPlan call. Hope it makes the code
clear.
https://reviews.llvm.org/D29144
Files:
lldb/source/Target/Process.cpp
Index: lldb/source/Target/Process.cpp
boris.ulasevich added a comment.
In https://reviews.llvm.org/D29144#657798, @jingham wrote:
> When you go to pick the plan to report for the stop it should be the top of
> the completed plan stack, the "thread plan to call function". Why in this
> particular case is the bottom of the completed
boris.ulasevich added a comment.
I work on the case when we have two plans complete: internal breakpoint plus
our function call plan:
Active plan stack:
Element 0: Base thread plan.
Completed Plan Stack:
Element 0: Run to address: 0x00010e78be00 using breakpoint: 0 - but the
bre
boris.ulasevich created this revision.
Additional change for https://reviews.llvm.org/D26497,
https://reviews.llvm.org/D28945 - fix for TestCallThatThrows test fail (works
for Mac only).
Recent change of stop reason priorities affected function call mechanism: it is
important that CallFunction
boris.ulasevich updated this revision to Diff 85424.
boris.ulasevich added a comment.
description update
https://reviews.llvm.org/D28945
Files:
lldb/include/lldb/Target/Thread.h
lldb/include/lldb/Target/ThreadPlan.h
lldb/source/Target/Thread.cpp
Index: lldb/source/Target/Thread.cpp
boris.ulasevich added a comment.
In https://reviews.llvm.org/D28945#651806, @jingham wrote:
> The plans should do whatever cleanup they are going to do when they get
> popped, and should not rely on the destructors to do this work.
Yes, you already made a note a time ago:
r123869 | jingham |
boris.ulasevich added a comment.
> Jim should probably review this change.
Yes, thank you. We are in contact with Jim. And I see now I had put Jim to
Subscribers list instead of Revievers list :)
> That said, I don't see any failures on linux currently. Can you elaborate on
> which tests are f
boris.ulasevich created this revision.
boris.ulasevich added a project: LLDB.
Here is a fix for Ubuntu tests fails after the recent change
https://reviews.llvm.org/D26497 (https://reviews.llvm.org/D26497). The cause of
those fails is in internal call to mmap fuction which destroys
completed_pla
12 matches
Mail list logo
