augusto2112 wrote:
@JDevlieghere @felipepiovezan any suggestions on this, or can I merge it as is?
The other way to do this would be to allow already freed pointers, document it,
and be careful to never dereference it. That feels weird and wasteful though.
I guess a third possibility is add a
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/155006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/155006
Add a missing null check pointed out in the previous PR review, and actually
use the SharedModuleList class, which was introduced but unused.
>From 234e075c1dbdaacd2e1b4199ae983f5c4439223c Mon Sep 17 00:00:
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/153685
>From 3b98a9b4ac5d2966ff7aa5eaf508c4752219c943 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 14 Aug 2025 14:05:46 -0700
Subject: [PATCH 1/2] [lldb] Fix CXX's SymbolNameFitsToLanguage matching oth
@@ -105,7 +105,8 @@ CPlusPlusLanguage::GetFunctionNameInfo(ConstString name)
const {
bool CPlusPlusLanguage::SymbolNameFitsToLanguage(Mangled mangled) const {
const char *mangled_name = mangled.GetMangledName().GetCString();
- return mangled_name && Mangled::IsMangledName(
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/153685
The current implementation of
CPlusPlusLanguage::SymbolNameFitsToLanguage will return true if the symbol is
mangled for any language that lldb knows about.
>From 3b98a9b4ac5d2966ff7aa5eaf508c4752219c943 M
augusto2112 wrote:
ping @JDevlieghere @felipepiovezan :)
https://github.com/llvm/llvm-project/pull/152607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -755,6 +755,234 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the mo
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/152607
>From cf8f7b8fca2d4910425fe39cddd997652b444d58 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 7 Aug 2025 15:32:49 -0700
Subject: [PATCH 1/2] Reland "[NFC][lldb] Speed up lookup of shared modules"
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/152607
>From cf8f7b8fca2d4910425fe39cddd997652b444d58 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 7 Aug 2025 15:32:49 -0700
Subject: [PATCH 1/3] Reland "[NFC][lldb] Speed up lookup of shared modules"
@@ -755,6 +755,235 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the mo
augusto2112 wrote:
@JDevlieghere I addresses the comments you left on
https://github.com/llvm/llvm-project/pull/152054
https://github.com/llvm/llvm-project/pull/152607
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cg
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/152607
The previous commit was reverted because it broke a test on the bots.
Original commit message:
By profiling LLDB debugging a Swift application without a dSYM and a large
amount of .o files, I identified th
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/152582
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/152582
This reverts commit 229d86026fa0e5d9412a0d5004532f0d9733aac6.
>From 2c9d14251c8a5bd2354d2747d44b8bb7db30c3b1 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 7 Aug 2025 12:44:40 -0700
Subject: [PAT
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/152054
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the m
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the m
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the m
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the m
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the m
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the m
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the m
@@ -755,11 +755,237 @@ size_t ModuleList::GetIndexForModule(const Module
*module) const {
}
namespace {
+/// A wrapper around ModuleList for shared modules. Provides fast lookups for
+/// file-based ModuleSpec queries.
+class SharedModuleList {
+public:
+ /// Finds all the m
augusto2112 wrote:
> > By profiling LLDB debugging a Swift application without a dSYM and a large
> > amount of .o files, I identified that querying shared modules was the
> > biggest bottleneck when running "frame variable", and Clang types need to
> > be searched.
>
> Could you elaborate wh
@@ -186,8 +182,11 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
expr);
}
- dump_val_object(*valobj_sp);
- return;
+ bool failed = errorToBool(dump_val_object(*valobj_sp));
augusto2112 wro
@@ -182,11 +184,13 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
expr);
}
- bool failed = errorToBool(dump_val_object(*valobj_sp));
- if (!failed)
+ Error err = dump_val_object(*valobj_sp);
+ if (!er
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/151374
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -186,8 +182,11 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
expr);
}
- dump_val_object(*valobj_sp);
- return;
+ bool failed = errorToBool(dump_val_object(*valobj_sp));
augusto2112 wro
augusto2112 wrote:
> Here is the problem with types: initial scalar literal type, all the type
> promotions and conversions are done using `lldb::BasicType` enumeration
> types, and later converted to `CompilerType` using the `TypeSystem`. In C++,
> this works perfectly well, because in
> [`T
@@ -456,9 +464,13 @@ ExtractLibcxxStringInfo(ValueObject &valobj) {
if (!l)
return {};
- StringLayout layout = l->GetIndexOfChildWithName("__data_") == 0
-? StringLayout::DSC
-: StringLayout::CSD;
+ auto index_or_
@@ -14,6 +14,7 @@
#include "llvm/Support/Format.h"
#include "llvm/Support/FormatProviders.h"
#include "llvm/Support/FormatVariadicDetails.h"
+#include
augusto2112 wrote:
For llvm the standard is to include with `""` instead of `<>`
https://github.com/llvm/ll
@@ -14,6 +14,7 @@
#include "llvm/Support/Format.h"
#include "llvm/Support/FormatProviders.h"
#include "llvm/Support/FormatVariadicDetails.h"
+#include
augusto2112 wrote:
Also I'd move this up so so it's next to the other lldb imports
https://github.com/llvm/
@@ -489,7 +490,10 @@ llvm::Error Interpret(std::vector
&control,
TYPE_CHECK(Object, String);
auto name = data.Pop();
POP_VALOBJ(valobj);
-data.Push((uint64_t)valobj->GetIndexOfChildWithName(name));
+auto index_or_err = valobj->GetIndexOf
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/126333
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
Thanks @DavidSpickett
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/125143
>From 937fdeab0b8526bd4b0e951f939a74ae01b1020c Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Jan 2025 16:33:09 -0800
Subject: [PATCH] [lldb] Make ValueObjectDynamicValue::UpdateValue() point t
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/125143
>From e8124c1949a1957befd58a045c0e36f4f6e09274 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Jan 2025 16:33:09 -0800
Subject: [PATCH] [lldb] Make ValueObjectDynamicValue::UpdateValue() point t
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/125143
>From ceb193ba178a3ec71824f8137ea648d70a5b0a79 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Jan 2025 16:33:09 -0800
Subject: [PATCH] [lldb] Make ValueObjectDynamicValue::UpdateValue() point t
augusto2112 wrote:
Jim I was able to write a unit test.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/125143
>From a280e7bc731818143cc89f3ce1150694a44784b3 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Jan 2025 16:33:09 -0800
Subject: [PATCH 1/6] [lldb] Make ValueObjectDynamicValue::UpdateValue() poi
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/125143
>From 0c22a94214e97146b2592b77ac96255bdee47b0f Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Jan 2025 16:33:09 -0800
Subject: [PATCH 1/6] [lldb] Make ValueObjectDynamicValue::UpdateValue() poi
augusto2112 wrote:
To make sure I understand, you want me to write a unittest where I have a value
object, and make sure it's dynamic value object child uses the local buffer to
store the contents? What should I test? That it prints correctly?
https://github.com/llvm/llvm-project/pull/125143
_
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/125143
>From 0c22a94214e97146b2592b77ac96255bdee47b0f Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Jan 2025 16:33:09 -0800
Subject: [PATCH 1/4] [lldb] Make ValueObjectDynamicValue::UpdateValue() poi
augusto2112 wrote:
> What are the ownership rules for that reference to bytes that you are passing
> out? Who's keeping it alive and for how long?
Since `ValueObjectDynamicValue::UpdateValue` immediately copies the buffer over
I don't think that's a big concern...
I could change `ArrayRef` to
augusto2112 wrote:
Unfortunately I wasn't able to construct a test case that would trigger this
with upstream lldb.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-b
augusto2112 wrote:
Jim I updated the PR.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/125143
>From 0c22a94214e97146b2592b77ac96255bdee47b0f Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Thu, 30 Jan 2025 16:33:09 -0800
Subject: [PATCH 1/2] [lldb] Make ValueObjectDynamicValue::UpdateValue() poi
augusto2112 wrote:
Ok, fair point. I'll come up with a more robust solution.
https://github.com/llvm/llvm-project/pull/125143
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
> Maybe I'm missing something. In the host case, m_address is set to invalid,
> but m_value has the address in it and is a host address, so then we get to:
>
> // m_address could be invalid but we could still have a local buffer //
> containing the dynamic value. if ((m_addr
augusto2112 wrote:
> I worry a bit about the fact that in the host case, GetValueAsData is going
> to end up calling:
>
> ```
> memcpy(dst, reinterpret_cast(address), byte_size);
> ```
>
> where address is the host data buffer and byte_size is the size of the new
> dynamic type. But in the
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/125143
…uffer
ValueObjectDynamicValue::UpdateValue() assumes that the dynamic type found by
GetDynamicTypeAndAddress() would return an address in the inferior. This
commit makes it so it can deal with being pass
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/124971
>From c6a1cd5115894b9f075229e878796c8b343ecde9 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 29 Jan 2025 10:53:23 -0800
Subject: [PATCH 1/3] [NFC][lldb] Document a few ivars on the value object
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/124971
>From c6a1cd5115894b9f075229e878796c8b343ecde9 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 29 Jan 2025 10:53:23 -0800
Subject: [PATCH 1/2] [NFC][lldb] Document a few ivars on the value object
augusto2112 wrote:
Re-requesting review as I added more comments.
https://github.com/llvm/llvm-project/pull/124971
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/124971
>From c6a1cd5115894b9f075229e878796c8b343ecde9 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 29 Jan 2025 10:53:23 -0800
Subject: [PATCH] [NFC][lldb] Document a few ivars on the value object syste
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/124971
None
>From cd28fcaf8739a32897a09bd661cb805b3960a7c7 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Wed, 29 Jan 2025 10:53:23 -0800
Subject: [PATCH] [NFC][lldb] Document a few ivars on the value object
https://github.com/augusto2112 approved this pull request.
Maybe you can also add a doxygen comment explaining that it shouldn't be used
directly and use the lldbassert macro instead?
https://github.com/llvm/llvm-project/pull/123225
___
lldb-commits m
Author: Augusto Noronha
Date: 2025-01-15T15:19:30-08:00
New Revision: 3241d915b1b8257fd6234461b04e4775fc7ed9fb
URL:
https://github.com/llvm/llvm-project/commit/3241d915b1b8257fd6234461b04e4775fc7ed9fb
DIFF:
https://github.com/llvm/llvm-project/commit/3241d915b1b8257fd6234461b04e4775fc7ed9fb.dif
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/117452
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2726,39 +2726,8 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query,
TypeResults &results) {
TypeQuery query_full(query);
bool have_index_match = false;
m_index->GetTypesWithQuery(query_full, [&](DWARFDIE die) {
-// Check the language, but only if we have a
@@ -2790,7 +2759,7 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query,
TypeResults &results) {
// With -gsimple-template-names, a templated type's DW_AT_name will not
// contain the template parameters. Try again stripping '<' and anything
// after, filtering out
https://github.com/augusto2112 approved this pull request.
LGTM
https://github.com/llvm/llvm-project/pull/116989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -2790,7 +2759,7 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query,
TypeResults &results) {
// With -gsimple-template-names, a templated type's DW_AT_name will not
// contain the template parameters. Try again stripping '<' and anything
// after, filtering out
@@ -2726,39 +2726,8 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query,
TypeResults &results) {
TypeQuery query_full(query);
bool have_index_match = false;
m_index->GetTypesWithQuery(query_full, [&](DWARFDIE die) {
-// Check the language, but only if we have a
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/116989
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -130,6 +131,25 @@ void RenderDiagnosticDetails(Stream &stream,
}
stream << '\n';
+ // Reverse the order within groups of diagnostics that are on the same
column.
+ auto group = [](auto &ds) {
+uint16_t column = 0;
+std::vector result, group;
+for (auto d
@@ -130,6 +131,25 @@ void RenderDiagnosticDetails(Stream &stream,
}
stream << '\n';
+ // Reverse the order within groups of diagnostics that are on the same
column.
+ auto group = [](auto &ds) {
augusto2112 wrote:
I'd prefer to spell out the type of `d
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/116727
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/116711
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 edited
https://github.com/llvm/llvm-project/pull/114608
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -101,6 +101,10 @@ void CommandObjectDWIMPrint::DoExecute(StringRef command,
// Add a hint if object description was requested, but no description
// function was implemented.
auto maybe_add_hint = [&](llvm::StringRef output) {
+static bool note_shown = false;
+
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/114610
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
@@ -27,6 +27,12 @@ static llvm::raw_ostream &warning(Stream &strm) {
<< "warning: ";
}
+static llvm::raw_ostream ¬e(Stream &strm) {
augusto2112 wrote:
Since `note` is a function should it be capitalized to follow the LLDB style?
https://github.com/l
@@ -27,6 +27,12 @@ static llvm::raw_ostream &warning(Stream &strm) {
<< "warning: ";
}
+static llvm::raw_ostream ¬e(Stream &strm) {
augusto2112 wrote:
Actually `error` and `warning` are not capitalized, I guess we can either keep
all three lower cas
@@ -110,6 +110,11 @@ class CommandReturnObject {
void AppendMessageWithFormat(const char *format, ...)
__attribute__((format(printf, 2, 3)));
+ void AppendNote(llvm::StringRef in_string);
+
+ void AppendNoteWithFormat(const char *format, ...)
+ __attribute__((fo
https://github.com/augusto2112 approved this pull request.
Nice! This code lives upstream though so you'll need to open a patch there too
https://github.com/llvm/llvm-project/pull/114608
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https:/
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
Ok, I was able to add a test
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/113007
>From 7fc51bb1a812c5dd1bef8d96b51a17ff02eb23fc Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Tue, 22 Oct 2024 14:34:44 -0700
Subject: [PATCH] [lldb] Extend FindTypes to optionally search by mangled ty
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/113007
>From eab35bd50d89a16494d8f08421a12aef77356c43 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Tue, 22 Oct 2024 14:34:44 -0700
Subject: [PATCH 1/3] [lldb] Extend FindTypes to optionally search by mangle
augusto2112 wrote:
@Michael137 I wasn't able to run `yaml2obj` to convert back an object file that
contains debug info, I'm not sure if the issue is that `yaml2obj` doesn't
support something that's encoded in the debug info, or some bug with MachO.
This is the error:
```
error: wrote too much
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/113007
>From eab35bd50d89a16494d8f08421a12aef77356c43 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Tue, 22 Oct 2024 14:34:44 -0700
Subject: [PATCH 1/2] [lldb] Extend FindTypes to optionally search by mangle
@@ -1032,11 +1032,17 @@ void SymbolFileCTF::FindTypes(const
lldb_private::TypeQuery &match,
ConstString name = match.GetTypeBasename();
for (TypeSP type_sp : GetTypeList().Types()) {
-if (type_sp && type_sp->GetName() == name) {
- results.InsertUnique(type_sp);
-
@@ -2758,6 +2758,15 @@ void SymbolFileDWARF::FindTypes(const TypeQuery &query,
TypeResults &results) {
return true; // Keep iterating over index types, language mismatch.
}
+// Since mangled names are unique, we only need to check if the names are
+// the
https://github.com/augusto2112 approved this pull request.
https://github.com/llvm/llvm-project/pull/113891
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
> If we don't always want forward `disableASLR` we could instead flip the
> condition to:
>
> ```
> if not disableASLR:
> args_dict["disableASLR"] = disableASLR
> ```
>
> Any thoughts?
I think "if not" would make it more confusing. The way it is in this patch
seems fin
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/113007
>From eab35bd50d89a16494d8f08421a12aef77356c43 Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Tue, 22 Oct 2024 14:34:44 -0700
Subject: [PATCH] [lldb] Extend FindTypes to optionally search by mangled ty
https://github.com/augusto2112 updated
https://github.com/llvm/llvm-project/pull/113007
>From 7881a25f21ffabc97417a7daa38fe8148615d36c Mon Sep 17 00:00:00 2001
From: Augusto Noronha
Date: Tue, 22 Oct 2024 14:23:43 -0700
Subject: [PATCH] [lldb] Extend FindTypes to optionally search by mangled ty
Author: Augusto Noronha
Date: 2024-10-21T10:37:46-07:00
New Revision: 30a402833f50b14148c8b963f3ffaaeaeea5fd78
URL:
https://github.com/llvm/llvm-project/commit/30a402833f50b14148c8b963f3ffaaeaeea5fd78
DIFF:
https://github.com/llvm/llvm-project/commit/30a402833f50b14148c8b963f3ffaaeaeea5fd78.dif
https://github.com/augusto2112 closed
https://github.com/llvm/llvm-project/pull/113006
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
augusto2112 wrote:
This depends on https://github.com/llvm/llvm-project/pull/113006
https://github.com/llvm/llvm-project/pull/113007
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/113007
Swift types have mangled type names. This adds functionality to look up those
types through the FindTypes API by searching for the mangled type name instead
of the regular name.
>From eb1f2bbd08d7f50286f04
https://github.com/augusto2112 created
https://github.com/llvm/llvm-project/pull/113006
Swift types have mangled names, so there should be a way to read those from the
compiler type.
This patch upstreams these two changes from swiftlang/llvm-project (which were
added there since at least 2016
augusto2112 wrote:
I reverted both this commit and also
https://github.com/llvm/llvm-project/commit/b77fdf5799be6b29869f2f7969851709e03938ba,
so you'll need to add that change to your commit before merging again.
https://github.com/llvm/llvm-project/pull/99736
_
Author: Augusto Noronha
Date: 2024-10-10T15:05:58-07:00
New Revision: 2ff4c25b7efff64b3b662d0bedcfe7edebcf20b9
URL:
https://github.com/llvm/llvm-project/commit/2ff4c25b7efff64b3b662d0bedcfe7edebcf20b9
DIFF:
https://github.com/llvm/llvm-project/commit/2ff4c25b7efff64b3b662d0bedcfe7edebcf20b9.dif
Author: Augusto Noronha
Date: 2024-10-10T15:05:58-07:00
New Revision: f02252e1fd2965db007cf7be74c448b7a119c321
URL:
https://github.com/llvm/llvm-project/commit/f02252e1fd2965db007cf7be74c448b7a119c321
DIFF:
https://github.com/llvm/llvm-project/commit/f02252e1fd2965db007cf7be74c448b7a119c321.dif
augusto2112 wrote:
I'll revert it!
https://github.com/llvm/llvm-project/pull/99736
___
lldb-commits mailing list
lldb-commits@lists.llvm.org
https://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits
1 - 100 of 212 matches
Mail list logo
