[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

2023-04-18 Thread Ashay Rane via Phabricator via lldb-commits
ashay-github added a comment. The `llvm::byteswap()` fix is much nicer. Thanks for the change! No, this build error didn't show up on a bot (at least as far as I can tell). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148541/new/ https://reviews

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

2023-04-17 Thread Ashay Rane via Phabricator via lldb-commits
This revision was automatically updated to reflect the committed changes. Closed by commit rG7978abd5aef1: [lldb] fix build issue on MSVC because of missing byte-swap builtins (authored by ashay). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148541/

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

2023-04-17 Thread Ashay Rane via Phabricator via lldb-commits
ashay-github updated this revision to Diff 514341. ashay-github added a comment. Updated to check for builtins and use them, if available. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D148541/new/ https://reviews.llvm.org/D148541 Files: lldb/sou

[Lldb-commits] [PATCH] D148541: [lldb] fix build issue on MSVC because of missing byte-swap builtins

2023-04-17 Thread Ashay Rane via Phabricator via lldb-commits
ashay-github created this revision. ashay-github added reviewers: DavidSpickett, jasonmolenda, bulbazord. Herald added a project: All. ashay-github requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. The `__builtin_bswap{32,64}()` builtins (int