Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

2016-05-01 Thread Apelete Seketeli via lldb-commits
apelete added a comment. Waiting for review, could someone please have a look at this one ? http://reviews.llvm.org/D19086 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

2016-05-01 Thread Apelete Seketeli via lldb-commits
apelete updated this revision to Diff 55753. apelete added a comment. [clang-analyzer] fix warnings emitted on lldb code base Changes since last revision: - fast forward rebase on git master branch. http://reviews.llvm.org/D19086 Files: include/lldb/Utility/LLDBAssert.h source/API/SBThrea

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

2016-04-19 Thread Apelete Seketeli via lldb-commits
apelete added a comment. Ping :). Requested changes are done, could someone have a look have this one ? http://reviews.llvm.org/D19086 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-comm

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

2016-04-14 Thread Apelete Seketeli via lldb-commits
apelete marked 2 inline comments as done. apelete added a comment. http://reviews.llvm.org/D19086 ___ lldb-commits mailing list lldb-commits@lists.llvm.org http://lists.llvm.org/cgi-bin/mailman/listinfo/lldb-commits

Re: [Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

2016-04-14 Thread Apelete Seketeli via lldb-commits
apelete updated this revision to Diff 53774. apelete added a comment. [clang-analyzer] fix warnings emitted on lldb code base Following changes were done in this revision: - source/API/SBThread.cpp: swith if() statement conditions to branch out early, - source/Plugins/ABI/SysV-mips64/ABISysV_mip

[Lldb-commits] [PATCH] D19086: [clang-analyzer] fix warnings emitted on lldb code base

2016-04-13 Thread Apelete Seketeli via lldb-commits
apelete created this revision. apelete added a subscriber: lldb-commits. The following warnings were reported while running clang analyzer on LLDB code base: API: argument with 'nonnull' attribute passed null, on file: - source/Plugins/SymbolFile/DWARF/DWARFASTParserJava.cpp. Dead store: dead as

[Lldb-commits] [scan-build] Fix reported dead store, logic error and api bugs

2016-04-03 Thread Apelete Seketeli via lldb-commits
Hello, Here are a few changes that try to address some logic error bugs reported by running scan-build over the LLDB code base. I have no background in compiler technology and I may have been trying to fix false positives; here is a quick overview of what scan-build reported, let me know if the f