[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

asl added a comment. The test seems to rely on the presence of the linker for the desired target platform, so cannot be used on cross-compile environment. TEST 'lldb-shell :: SymbolFile/DWARF/x86/DW_OP_div-with-signed.s' FAILED Script: -- : 'RUN

[Lldb-commits] [PATCH] D147370: [lldb] fixing #61727 fixing incorrect variable displaying with DW_OP_div

asl added a comment. This seems to fail on ARM: https://lab.llvm.org/buildbot/#/builders/17/builds/37130 Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D147370/new/ https://reviews.llvm.org/D147370 ___ ll

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

This revision was landed with ongoing or failed builds. This revision was automatically updated to reflect the committed changes. Closed by commit rG8be139fc1251: [lldb] Add settings for expression evaluation memory allocations. (authored by kuilpd, committed by asl). Repository: rG LLVM Github

[Lldb-commits] [PATCH] D149262: [lldb] Add settings for expression evaluation memory allocations.

asl added inline comments. Comment at: lldb/source/Expression/IRMemoryMap.cpp:181 size_t alloc_size = back->second.m_size; auto arch = target_sp->GetArchitecture().GetTriple().getArch(); +uint64_t align = target_sp->GetExprAllocAlign(); is arch unus

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

asl added a comment. @kuilpd Please ensure that the patch is rebased into top of `main` and builds w/o errors / warnings. Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

This revision was automatically updated to reflect the committed changes. Closed by commit rG82c02b733c77: [lldb] Add support for MSP430 in LLDB. (authored by asl). Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

asl added a comment. Thanks @bulbazord @DavidSpickett ! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D146965/new/ https://reviews.llvm.org/D146965 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailma

[Lldb-commits] [PATCH] D146965: [lldb] Add support for MSP430 in LLDB.

asl added a comment. @JDevlieghere @bulbazord I don't think I know lldb codebase well enough to cover the complete review here. But from MSP430-standpoint things seem to be correct. Will you be able to review or suggest some other reviewers? Thanks! Repository: rG LLVM Github Monorepo CHAN

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

asl requested changes to this revision. asl added a comment. This revision now requires changes to proceed. Will you please check the comments and reword everything using proper terminology and new things we're having on GitHub? Comment at: clang/www/c_status.html:76 +The http

[Lldb-commits] [PATCH] D116351: Update Bug report URL to Github Issues

asl requested changes to this revision. asl added a subscriber: tstellar. asl added a comment. This revision now requires changes to proceed. Thanks for doing this! I added few notes on the way. Comment at: clang/www/c_status.html:76 +The https://bugs.llvm.org/";>LLVM bug track