[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

2023-05-22 Thread Aman LaChapelle via Phabricator via lldb-commits
bzcheeseman accepted this revision. bzcheeseman added a comment. This revision is now accepted and ready to land. LGTM Repository: rG LLVM Github Monorepo CHANGES SINCE LAST ACTION https://reviews.llvm.org/D150303/new/ https://reviews.llvm.org/D150303 _

[Lldb-commits] [PATCH] D150303: [LLDB] Add some declarations related to REPL support for mojo

2023-05-22 Thread Aman LaChapelle via Phabricator via lldb-commits
bzcheeseman added inline comments. Comment at: lldb/include/lldb/Expression/ExpressionTypeSystemHelper.h:30 - LLVMCastKind getKind() const { return m_kind; } - - ExpressionTypeSystemHelper(LLVMCastKind kind) : m_kind(kind) {} - - ~ExpressionTypeSystemHelper() = default; - -p

[Lldb-commits] [PATCH] D149312: [lldb] Create a way to force remove commands

2023-04-26 Thread Aman LaChapelle via Phabricator via lldb-commits
bzcheeseman accepted this revision. bzcheeseman added inline comments. This revision is now accepted and ready to land. Comment at: lldb/include/lldb/Interpreter/CommandInterpreter.h:329 + /// is provided, the command is removed regardless of its removable status. + bool Remove