[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-09-21 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 372770. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/Compile

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-09-21 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit added a comment. @Mordante Alfonso Gregory gfunni...@gmail.com CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llv

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-09-21 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit added a comment. @ldionne can you please please merge CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-09-07 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 370957. gAlfonso-bit added a comment. Rebase to Main @ldionne CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-09-05 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit added a comment. @ldionne update? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/listinf

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit added a comment. I don't think there are any other outstanding issues. Are we good to accept and merge? @ldionne CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit added a comment. @ldionne can we land this please? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bi

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 366671. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake compiler-rt/cmake

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 366497. gAlfonso-bit added a comment. Rebased to main CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/Compile

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365802. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockL

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 366014. gAlfonso-bit added a comment. Rebased CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockL

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit added a comment. @ldionne is this ok? any other changes? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit added a comment. So does that mean this is ready to land? CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365507. gAlfonso-bit added a comment. Rebase CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLL

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365275. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMockLLVMCMakeConfig.cmake compiler-rt/cmake

[Lldb-commits] [PATCH] D107717: [LLVM][CMake][NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit added a comment. Alright. Thank you! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 ___ lldb-commits mailing list lldb-commits@lists.llvm.org https://lists.llvm.org/cgi-bin/mailman/list

[Lldb-commits] [PATCH] D107717: [NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365039. Herald added a subscriber: JDevlieghere. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107717/new/ https://reviews.llvm.org/D107717 Files: clang/CMakeLists.txt clang/lib/Basic/CMakeLists.txt compiler-rt/cmake/Modules/CompilerRTMock

[Lldb-commits] [PATCH] D107717: [NFC] Resolve FIXME: Rename LLVM_CMAKE_PATH to LLVM_CMAKE_DIR throughout the project

2021-08-30 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit created this revision. gAlfonso-bit added a project: LLVM. Herald added subscribers: libcxx-commits, tstellar, mgorny. Herald added a reviewer: MaskRay. Herald added a project: libunwind. Herald added a reviewer: libunwind. gAlfonso-bit requested review of this revision. Herald added p

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-12 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit added a comment. Only clang-tidy is upset and it is falsely flagging "missing" files CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 ___ lldb-commits mailing list lldb-commits@lists.llvm

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-10 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit marked an inline comment as done. gAlfonso-bit added a comment. Addressed all issues! CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 ___ lldb-commits mailing list lldb-commits@lists.llv

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-10 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365497. gAlfonso-bit added a comment. Remove goto CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/include/lldb/Core/IOHandler.h lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-09 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365267. gAlfonso-bit added a comment. clang-tidy workaround CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/include/lldb/Core/IOHandler.h lldb/source/Core/IOHandler.cpp Index: lldb/so

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-09 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365220. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp ==

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-09 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365218. CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp ==

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-09 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit updated this revision to Diff 365217. gAlfonso-bit added a comment. Simplify function even further CHANGES SINCE LAST ACTION https://reviews.llvm.org/D107704/new/ https://reviews.llvm.org/D107704 Files: lldb/source/Core/IOHandler.cpp Index: lldb/source/Core/IOHandler.cpp ===

[Lldb-commits] [PATCH] D107704: [LLDB][NFC] Simplify IOHandler's getLine to avoid strange casts and redundant checks

2021-08-07 Thread Alf via Phabricator via lldb-commits
gAlfonso-bit created this revision. gAlfonso-bit requested review of this revision. Herald added a project: LLDB. Herald added a subscriber: lldb-commits. This is especially important at the end of the function, where originally there was a strange cast from optional to bool Repository: rG LL